{"thread":{"id":"44262","subject":"Problem with submodules","startedAt":"2016-10-09T14:42:37Z","lastAt":"2016-10-10T05:45:14Z","messageCount":5,"participants":["venv21@gmail.com","Dennis Kaarsemaker","Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"303678","messageId":"CAL4SumgJbrirymt5+iyNbpo++xXfzJZRiHDm8=0+eCArpCX=DA@mail.gmail.com","threadId":"44262","inReplyTo":null,"subject":"Problem with submodules","fromName":"venv21@gmail.com","fromEmail":"venv21@gmail.com","sentAt":"2016-10-09T14:41:45Z","receivedAt":"2016-10-09T14:42:37Z","isPatch":false,"sender":{"key":"venv21@gmail.com","avatar":null},"body":"Hi, I want to report a regression.\n\nAfter cloning for example https://git.gnome.org/browse/epiphany with\ngit 2.10 and running ./autogen.sh I get the following errors:\nhttp://pastebin.com/93AunRhu\n\nThe developer told me that it is probably not an issue caused by\nepiphany and I should try an older git version. I installed 2.7.2 and\nit works perfectly. So I think theres a bug in git 2.10.\n\nThanks and regards\n"},{"id":"303679","messageId":"1476035501.26041.1.camel@kaarsemaker.net","threadId":"44262","inReplyTo":"CAL4SumgJbrirymt5+iyNbpo++xXfzJZRiHDm8=0+eCArpCX=DA@mail.gmail.com","subject":"Re: Problem with submodules","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2016-10-09T17:51:41Z","receivedAt":"2016-10-09T17:51:50Z","isPatch":false,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"On Sun, 2016-10-09 at 16:41 +0200, venv21@gmail.com wrote:\n> Hi, I want to report a regression.\n> \n> After cloning for example https://git.gnome.org/browse/epiphany with\n> git 2.10 and running ./autogen.sh I get the following errors:\n> http://pastebin.com/93AunRhu\n> \n> The developer told me that it is probably not an issue caused by\n> epiphany and I should try an older git version. I installed 2.7.2 and\n> it works perfectly. So I think theres a bug in git 2.10.\n\nI can't reproduce the problem with git 2.10.1\n\nCan you share the .git/config file in your clone of epiphany please.\n\nD.\n"},{"id":"303681","messageId":"CAL4Sumj7r-RNXBi2Oh_=KAkcksM13sJjLzJEpszWXPXZ8hP6Kw@mail.gmail.com","threadId":"44262","inReplyTo":"1476035501.26041.1.camel@kaarsemaker.net","subject":"Re: Problem with submodules","fromName":"venv21@gmail.com","fromEmail":"venv21@gmail.com","sentAt":"2016-10-09T19:15:36Z","receivedAt":"2016-10-09T19:15:42Z","isPatch":false,"sender":{"key":"venv21@gmail.com","avatar":null},"body":"Sure, http://pastebin.com/bUFBDj0Q\n"},{"id":"303682","messageId":"CAL4Sumjc0Fo3JLBZxdM50Z3o8ZhGk731905Gxg=R=GXsPMKzmA@mail.gmail.com","threadId":"44262","inReplyTo":"CAL4Sumj7r-RNXBi2Oh_=KAkcksM13sJjLzJEpszWXPXZ8hP6Kw@mail.gmail.com","subject":"Re: Problem with submodules","fromName":"venv21@gmail.com","fromEmail":"venv21@gmail.com","sentAt":"2016-10-09T19:22:50Z","receivedAt":"2016-10-09T19:22:57Z","isPatch":false,"sender":{"key":"venv21@gmail.com","avatar":null},"body":"hm okay, it works with 2.10.0, when I remove the word 'epiphany' from\nthe urls in line 13 and 15\n\n2016-10-09 21:15 GMT+02:00 venv21@gmail.com <venv21@gmail.com>:\n> Sure, http://pastebin.com/bUFBDj0Q\n"},{"id":"303698","messageId":"CAGZ79kYVr9NwAQzMb8Gxo9CO8PDpzPBX1PUka4BCDugFeQm7Fw@mail.gmail.com","threadId":"44262","inReplyTo":"1476046602.26041.3.camel@kaarsemaker.net","subject":"Re: Problem with submodules","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-10-10T05:45:08Z","receivedAt":"2016-10-10T05:45:14Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Adding the list back on.\n\nOn Sun, Oct 9, 2016 at 1:56 PM, Dennis Kaarsemaker\n<dennis@kaarsemaker.net> wrote:\n> On Sun, 2016-10-09 at 21:15 +0200, venv21@gmail.com wrote:\n>> Sure, http://pastebin.com/bUFBDj0Q\n>\n> So you actually cloned from a path ending in epihany/, not epiphany.\n> Turns out the trainling slash matters when using relative urls for\n> submodules:\n>\n> $ cat test.sh\n> url=http://remote.example/repo\n>\n> for url in $url \"$url/\"; do\n>     echo \"Remote: $url\"\n>     rm -rf main\n>     git init -q main\n>     (\n>         cd main\n>         git remote add origin $url\n>         git init -q sub\n>         git -C sub commit --allow-empty -mtest\n>         printf '[submodule \"sub\"]\\n\\tpath = sub\\n\\t\\turl = ../sub\\n' > .gitmodules\n>         git add sub .gitmodules\n>         git commit -mtest\n>         git submodule init\n>     ) >/dev/null\n> done\n>\n> $ sh test.sh\n> Remote: http://remote.example/repo\n> Submodule 'sub' (http://remote.example/sub) registered for path 'sub'\n> Remote: http://remote.example/repo/\n> Submodule 'sub' (http://remote.example/repo/sub) registered for path 'sub'\n>\n> I don't know whether this is a bug or a feature. I find using relative\n> paths for submodules a pretty dodgy idea anyway and would fix up the\n> .gitmodules file.\n\nI disagree here, IMHO relative path/urls are better than absolute URLs as\nit allows to hand over a project to a different organisation that wants to have\nits own fork including submodule changes just easily (no need to muck around\nthe submodule config, \"it just works\" ;)\n\n>\n> Stefan, is it possible that this is a regression in the C rewrite?\n\nTotally possible!\n\nThanks for the regression test, I'll dive into the code tomorrow.\n\nThanks,\nStefan\n\n>\n> D.\n>\n"}]}