{"thread":{"id":"44197","subject":"[PATCH] tmp-objdir: mark some file local symbols static","startedAt":"2016-10-01T23:07:38Z","lastAt":"2016-10-02T12:13:19Z","messageCount":2,"participants":["Ramsay Jones","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"303057","messageId":"f5560f8b-75be-faa0-ce1c-5e2716ee82a5@ramsayjones.plus.com","threadId":"44197","inReplyTo":null,"subject":"[PATCH] tmp-objdir: mark some file local symbols static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-10-01T23:07:27Z","receivedAt":"2016-10-01T23:07:38Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Jeff,\n\nIf you need to re-roll your 'jk/quarantine-received-objects' branch,\ncould you please squash this into the relevant patches.\n\n[I also note that tmp_objdir_destroy(), declared to be part of the\npublic interface, is not currently called from outside tmp_objdir.c.\nDespite being unlikely, it is at least plausible that this function\nmay be useful in future. ;-) ]\n\nThanks!\n\nATB,\nRamsay Jones\n\n builtin/receive-pack.c | 2 +-\n tmp-objdir.c           | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/receive-pack.c b/builtin/receive-pack.c\nindex 25afa3f..4194088 100644\n--- a/builtin/receive-pack.c\n+++ b/builtin/receive-pack.c\n@@ -87,7 +87,7 @@ static enum {\n } use_keepalive;\n static int keepalive_in_sec = 5;\n \n-struct tmp_objdir *tmp_objdir;\n+static struct tmp_objdir *tmp_objdir;\n \n static enum deny_action parse_deny_action(const char *var, const char *value)\n {\ndiff --git a/tmp-objdir.c b/tmp-objdir.c\nindex 2181a42..3a58404 100644\n--- a/tmp-objdir.c\n+++ b/tmp-objdir.c\n@@ -17,7 +17,7 @@ struct tmp_objdir {\n  * more than one, and we can expand later if so.  You can have many such\n  * tmp_objdirs simultaneously in many processes, of course.\n  */\n-struct tmp_objdir *the_tmp_objdir;\n+static struct tmp_objdir *the_tmp_objdir;\n \n static void tmp_objdir_free(struct tmp_objdir *t)\n {\n-- \n2.10.0\n"},{"id":"303061","messageId":"20161002121311.4febd7jtc4yv5fev@sigill.intra.peff.net","threadId":"44197","inReplyTo":"f5560f8b-75be-faa0-ce1c-5e2716ee82a5@ramsayjones.plus.com","subject":"Re: [PATCH] tmp-objdir: mark some file local symbols static","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-10-02T12:13:12Z","receivedAt":"2016-10-02T12:13:19Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Oct 02, 2016 at 12:07:27AM +0100, Ramsay Jones wrote:\n\n> If you need to re-roll your 'jk/quarantine-received-objects' branch,\n> could you please squash this into the relevant patches.\n\nOops, thanks. Don't know how I missed both of these.\n\n> [I also note that tmp_objdir_destroy(), declared to be part of the\n> public interface, is not currently called from outside tmp_objdir.c.\n> Despite being unlikely, it is at least plausible that this function\n> may be useful in future. ;-) ]\n\nYeah, builtin/receive-pack is happy to just rely on process death to\ndestroy it, but I think it's good to keep open an option for somebody to\ndo:\n\n  if (error) {\n\ttmp_objdir_destroy(t);\n\treturn -1;\n  }\n\nor similar.\n\n-Peff\n"}]}