{"thread":{"id":"44123","subject":"[PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it","startedAt":"2016-09-21T08:45:33Z","lastAt":"2016-09-22T09:03:55Z","messageCount":5,"participants":["larsxschneider@gmail.com","stefan.naewe@atlas-elektronik.com","Lars Schneider","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"302254","messageId":"20160921084518.13091-1-larsxschneider@gmail.com","threadId":"44123","inReplyTo":null,"subject":"[PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-09-21T08:45:18Z","receivedAt":"2016-09-21T08:45:33Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider \n\nThe TravisCI macOS build is broken because homebrew (a macOS depedency\nmanager) changed its internal directory structure [1]. This is a problem\nbecause we modify the Perforce dependencies in the homebrew repository\nbefore installing them.\n\nFix it by asking homebrew for its path instead of hardcoding it.\n\n[1] https://github.com/Homebrew/brew/commit/0a09ae30f8b6117ad699b4a0439010738989c547\n\nSigned-off-by: Lars Schneider \n---\n\nHi Junio,\n\nthe problem affects all branches (pu, next, master, maint):\nhttps://travis-ci.org/git/git/branches\n\nIs it possible for this fix to graduate more quickly?\n\nThanks,\nLars\n\n .travis.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.travis.yml b/.travis.yml\nindex 477c3d2..37a1e1f 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -78,7 +78,7 @@ before_install:\n FORMULA=$1\n SHA=$(brew fetch --force $FORMULA 2>&1 | grep ^SHA256: | cut -d ' ' -f 2)\n sed -E -i.bak \"s/sha256 \\\"[0-9a-f]{64}\\\"/sha256 \\\"$SHA\\\"/g\" \\\n- /usr/local/Library/Taps/homebrew/homebrew-binary/$FORMULA.rb\n+ \"$(brew --repository homebrew/homebrew-binary)/$FORMULA.rb\"\n }\n brew update --quiet\n brew tap homebrew/binary --quiet\n--\n2.10.0\n\n"},{"id":"302257","messageId":"83e3049c-34ea-4440-7b4d-061cb98ba2dd@atlas-elektronik.com","threadId":"44123","inReplyTo":"20160921084518.13091-1-larsxschneider@gmail.com","subject":"Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it","fromName":"","fromEmail":"stefan.naewe@atlas-elektronik.com","sentAt":"2016-09-21T09:31:38Z","receivedAt":"2016-09-21T09:32:17Z","isPatch":true,"sender":{"key":"stefan.naewe@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4468?v=4"},"body":"In the Subject: s/the //\n\nAm 21.09.2016 um 10:45 schrieb larsxschneider@gmail.com:\n> From: Lars Schneider \n> \n> The TravisCI macOS build is broken because homebrew (a macOS depedency\n\ns/depedency/dependency/\n\n> manager) changed its internal directory structure [1]. This is a problem\n> because we modify the Perforce dependencies in the homebrew repository\n> before installing them.\n> \n> Fix it by asking homebrew for its path instead of hardcoding it.\n> \n> [1] https://github.com/Homebrew/brew/commit/0a09ae30f8b6117ad699b4a0439010738989c547\n> \n> Signed-off-by: Lars Schneider \n> ---\n> \n> Hi Junio,\n> \n> the problem affects all branches (pu, next, master, maint):\n> https://travis-ci.org/git/git/branches\n> \n> Is it possible for this fix to graduate more quickly?\n> \n> Thanks,\n> Lars\n> \n> .travis.yml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/.travis.yml b/.travis.yml\n> index 477c3d2..37a1e1f 100644\n> --- a/.travis.yml\n> +++ b/.travis.yml\n> @@ -78,7 +78,7 @@ before_install:\n> FORMULA=$1\n> SHA=$(brew fetch --force $FORMULA 2>&1 | grep ^SHA256: | cut -d ' ' -f 2)\n> sed -E -i.bak \"s/sha256 \\\"[0-9a-f]{64}\\\"/sha256 \\\"$SHA\\\"/g\" \\\n> - /usr/local/Library/Taps/homebrew/homebrew-binary/$FORMULA.rb\n> + \"$(brew --repository homebrew/homebrew-binary)/$FORMULA.rb\"\n> }\n> brew update --quiet\n> brew tap homebrew/binary --quiet\n> --\n> 2.10.0\n> \n> \n\n\n-- \n----------------------------------------------------------------\n/dev/random says: If winning isn't important then why keep score?\npython -c \"print '73746566616e2e6e616577654061746c61732d656c656b74726f6e696b2e636f6d'.decode('hex')\" \nGPG Key fingerprint = 2DF5 E01B 09C3 7501 BCA9 9666 829B 49C5 9221 27AF"},{"id":"302269","messageId":"14C21417-491B-4C8E-90FE-47154EEDD9FE@gmail.com","threadId":"44123","inReplyTo":"83e3049c-34ea-4440-7b4d-061cb98ba2dd@atlas-elektronik.com","subject":"Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-09-21T13:28:51Z","receivedAt":"2016-09-21T13:29:00Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\n> On 21 Sep 2016, at 11:31, stefan.naewe@atlas-elektronik.com wrote:\n> \n> In the Subject: s/the //\n> \n> Am 21.09.2016 um 10:45 schrieb larsxschneider@gmail.com:\n>> From: Lars Schneider \n>> \n>> The TravisCI macOS build is broken because homebrew (a macOS depedency\n> \n> s/depedency/dependency/\n\nThanks for spotting both errors!\n\n@Junio: Should I make a v2?\n\nThanks,\nLars\n"},{"id":"302290","messageId":"xmqqzin19pbj.fsf@gitster.mtv.corp.google.com","threadId":"44123","inReplyTo":"14C21417-491B-4C8E-90FE-47154EEDD9FE@gmail.com","subject":"Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-21T16:42:56Z","receivedAt":"2016-09-21T16:45:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lars Schneider writes:\n\n>> On 21 Sep 2016, at 11:31, stefan.naewe@atlas-elektronik.com wrote:\n>> \n>> In the Subject: s/the //\n>> \n>> Am 21.09.2016 um 10:45 schrieb larsxschneider@gmail.com:\n>>> From: Lars Schneider \n>>> \n>>> The TravisCI macOS build is broken because homebrew (a macOS depedency\n>> \n>> s/depedency/dependency/\n>\n> Thanks for spotting both errors!\n>\n> @Junio: Should I make a v2?\n\nNo. osx before_install stuff was in there since the very beginning,\ni.e. 522354d7 (\"Add Travis CI support\", 2015-11-27), so I guess this\nneeds to go to maint-2.7 and upwards, but I guess we should discourage\npeople to stay on an older maintenance track forever, so let's do\nthis only for 'maint' and upwards.\n"},{"id":"302365","messageId":"A1C0644E-095A-4903-AE86-72EAEFEB385B@gmail.com","threadId":"44123","inReplyTo":"xmqqzin19pbj.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH v1] travis-ci: ask homebrew for the its path instead of hardcoding it","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-09-22T09:03:45Z","receivedAt":"2016-09-22T09:03:55Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\n> On 21 Sep 2016, at 18:42, Junio C Hamano wrote:\n> \n> Lars Schneider writes:\n> \n>>> On 21 Sep 2016, at 11:31, stefan.naewe@atlas-elektronik.com wrote:\n>>> \n>>> In the Subject: s/the //\n>>> \n>>> Am 21.09.2016 um 10:45 schrieb larsxschneider@gmail.com:\n>>>> From: Lars Schneider \n>>>> \n>>>> The TravisCI macOS build is broken because homebrew (a macOS depedency\n>>> \n>>> s/depedency/dependency/\n>> \n>> Thanks for spotting both errors!\n>> \n>> @Junio: Should I make a v2?\n> \n> No. osx before_install stuff was in there since the very beginning,\n> i.e. 522354d7 (\"Add Travis CI support\", 2015-11-27), so I guess this\n> needs to go to maint-2.7 and upwards, but I guess we should discourage\n> people to stay on an older maintenance track forever, so let's do\n> this only for 'maint' and upwards.\n\nSound good to me.\n\nThank you,\nLars\n\n\nMinor nit: \nIf still possible and no trouble for you please do\n`s/the //` on the subject line of 72fa5cd29f2a9249462215109dbf41b4a6c0c768 (in PU)\n\n"}]}