{"thread":{"id":"44081","subject":"[PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers","startedAt":"2016-09-14T06:41:03Z","lastAt":"2016-09-14T19:11:19Z","messageCount":3,"participants":["Mike Ralphson","Junio C Hamano","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"301900","messageId":"01020157276d4d1f-9c995462-4aea-4949-8d29-3dbdbec77dd7-000000@eu-west-1.amazonses.com","threadId":"44081","inReplyTo":null,"subject":"[PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers","fromName":"Mike Ralphson","fromEmail":"mike.ralphson@gmail.com","sentAt":"2016-09-14T06:40:57Z","receivedAt":"2016-09-14T06:41:03Z","isPatch":true,"sender":{"key":"mike.ralphson@gmail.com","avatar":"https://avatars.githubusercontent.com/u/21603?v=4"},"body":"Two instances of %ld being used for unsigned longs\n\nSigned-off-by: Mike Ralphson <mike.ralphson@gmail.com>\n---\n vcs-svn/fast_export.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/vcs-svn/fast_export.c b/vcs-svn/fast_export.c\nindex bd0f2c2..97cba39 100644\n--- a/vcs-svn/fast_export.c\n+++ b/vcs-svn/fast_export.c\n@@ -73,7 +73,7 @@ void fast_export_begin_note(uint32_t revision, const char *author,\n \tstatic int firstnote = 1;\n \tsize_t loglen = strlen(log);\n \tprintf(\"commit %s\\n\", note_ref);\n-\tprintf(\"committer %s <%s@%s> %ld +0000\\n\", author, author, \"local\", timestamp);\n+\tprintf(\"committer %s <%s@%s> %lu +0000\\n\", author, author, \"local\", timestamp);\n \tprintf(\"data %\"PRIuMAX\"\\n\", (uintmax_t)loglen);\n \tfwrite(log, loglen, 1, stdout);\n \tif (firstnote) {\n@@ -107,7 +107,7 @@ void fast_export_begin_commit(uint32_t revision, const char *author,\n \t}\n \tprintf(\"commit %s\\n\", local_ref);\n \tprintf(\"mark :%\"PRIu32\"\\n\", revision);\n-\tprintf(\"committer %s <%s@%s> %ld +0000\\n\",\n+\tprintf(\"committer %s <%s@%s> %lu +0000\\n\",\n \t\t   *author ? author : \"nobody\",\n \t\t   *author ? author : \"nobody\",\n \t\t   *uuid ? uuid : \"local\", timestamp);\n\n--\nhttps://github.com/git/git/pull/293\n"},{"id":"301909","messageId":"xmqqeg4mscf1.fsf@gitster.mtv.corp.google.com","threadId":"44081","inReplyTo":"01020157276d4d1f-9c995462-4aea-4949-8d29-3dbdbec77dd7-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-14T15:56:18Z","receivedAt":"2016-09-14T15:56:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Ralphson <mike.ralphson@gmail.com> writes:\n\n> Two instances of %ld being used for unsigned longs.\n>\n> Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>\n> ---\n\nGood eyes.  Thanks for spotting.\n\n>  vcs-svn/fast_export.c | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/vcs-svn/fast_export.c b/vcs-svn/fast_export.c\n> index bd0f2c2..97cba39 100644\n> --- a/vcs-svn/fast_export.c\n> +++ b/vcs-svn/fast_export.c\n> @@ -73,7 +73,7 @@ void fast_export_begin_note(uint32_t revision, const char *author,\n>  \tstatic int firstnote = 1;\n>  \tsize_t loglen = strlen(log);\n>  \tprintf(\"commit %s\\n\", note_ref);\n> -\tprintf(\"committer %s <%s@%s> %ld +0000\\n\", author, author, \"local\", timestamp);\n> +\tprintf(\"committer %s <%s@%s> %lu +0000\\n\", author, author, \"local\", timestamp);\n>  \tprintf(\"data %\"PRIuMAX\"\\n\", (uintmax_t)loglen);\n>  \tfwrite(log, loglen, 1, stdout);\n>  \tif (firstnote) {\n> @@ -107,7 +107,7 @@ void fast_export_begin_commit(uint32_t revision, const char *author,\n>  \t}\n>  \tprintf(\"commit %s\\n\", local_ref);\n>  \tprintf(\"mark :%\"PRIu32\"\\n\", revision);\n> -\tprintf(\"committer %s <%s@%s> %ld +0000\\n\",\n> +\tprintf(\"committer %s <%s@%s> %lu +0000\\n\",\n>  \t\t   *author ? author : \"nobody\",\n>  \t\t   *author ? author : \"nobody\",\n>  \t\t   *uuid ? uuid : \"local\", timestamp);\n>\n> --\n> https://github.com/git/git/pull/293\n"},{"id":"301917","messageId":"20160914191110.exo4f3gr2wszf2sh@sigill.intra.peff.net","threadId":"44081","inReplyTo":"01020157276d4d1f-9c995462-4aea-4949-8d29-3dbdbec77dd7-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-09-14T19:11:10Z","receivedAt":"2016-09-14T19:11:19Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Sep 14, 2016 at 06:40:57AM +0000, Mike Ralphson wrote:\n\n> Two instances of %ld being used for unsigned longs\n\nObviously this is an improvement, but I'm kind of surprised that\ncompiler warnings didn't flag this. I couldn't find a \"-W\" combination\nthat noticed, though (at least not with gcc 6).\n\n-Peff\n"}]}