{"thread":{"id":"44074","subject":"[PATCH] pathspec: removed unnecessary function prototypes","startedAt":"2016-09-13T16:53:19Z","lastAt":"2016-09-14T19:30:56Z","messageCount":5,"participants":["Brandon Williams","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"301854","messageId":"1473785571-60439-1-git-send-email-bmwill@google.com","threadId":"44074","inReplyTo":null,"subject":"[PATCH] pathspec: removed unnecessary function prototypes","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2016-09-13T16:52:51Z","receivedAt":"2016-09-13T16:53:19Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"removed function prototypes from pathspec.h which don't have a\ncorresponding implementation.\n\nSigned-off-by: Brandon Williams <bmwill@google.com>\n---\n pathspec.h | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/pathspec.h b/pathspec.h\nindex 4a80f6f..59809e4 100644\n--- a/pathspec.h\n+++ b/pathspec.h\n@@ -96,7 +96,5 @@ static inline int ps_strcmp(const struct pathspec_item *item,\n \n extern char *find_pathspecs_matching_against_index(const struct pathspec *pathspec);\n extern void add_pathspec_matches_against_index(const struct pathspec *pathspec, char *seen);\n-extern const char *check_path_for_gitlink(const char *path);\n-extern void die_if_path_beyond_symlink(const char *path, const char *prefix);\n \n #endif /* PATHSPEC_H */\n-- \n2.8.0.rc3.226.g39d4020\n\n"},{"id":"301864","messageId":"20160913181552.74bhacoa2q76yv6k@sigill.intra.peff.net","threadId":"44074","inReplyTo":"1473785571-60439-1-git-send-email-bmwill@google.com","subject":"Re: [PATCH] pathspec: removed unnecessary function prototypes","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-09-13T18:15:53Z","receivedAt":"2016-09-13T18:16:01Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:\n\n> removed function prototypes from pathspec.h which don't have a\n> corresponding implementation.\n\nI'm always curious of the \"why\" in cases like this. Did we forget to add\nthem? Did they get renamed? Did they go away?\n\nLooks like the latter; 5a76aff (add: convert to use parse_pathspec,\n2013-07-14) just forgot to remove them.\n\n-Peff\n"},{"id":"301885","messageId":"xmqqh99jtn33.fsf@gitster.mtv.corp.google.com","threadId":"44074","inReplyTo":"20160913181552.74bhacoa2q76yv6k@sigill.intra.peff.net","subject":"Re: [PATCH] pathspec: removed unnecessary function prototypes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-13T23:08:16Z","receivedAt":"2016-09-13T23:08:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:\n>\n>> removed function prototypes from pathspec.h which don't have a\n>> corresponding implementation.\n>\n> I'm always curious of the \"why\" in cases like this. Did we forget to add\n> them? Did they get renamed? Did they go away?\n>\n> Looks like the latter; 5a76aff (add: convert to use parse_pathspec,\n> 2013-07-14) just forgot to remove them.\n\nThanks for digging.\n"},{"id":"301919","messageId":"20160914192341.mgpcc35kgmjqunbh@sigill.intra.peff.net","threadId":"44074","inReplyTo":"20160913181552.74bhacoa2q76yv6k@sigill.intra.peff.net","subject":"Re: [PATCH] pathspec: removed unnecessary function prototypes","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-09-14T19:23:41Z","receivedAt":"2016-09-14T19:23:49Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote:\n\n> On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:\n> \n> > removed function prototypes from pathspec.h which don't have a\n> > corresponding implementation.\n> \n> I'm always curious of the \"why\" in cases like this. Did we forget to add\n> them? Did they get renamed? Did they go away?\n> \n> Looks like the latter; 5a76aff (add: convert to use parse_pathspec,\n> 2013-07-14) just forgot to remove them.\n\nI should have done a better job of not just providing the answer, but\nshowing how. The easiest tool here is \"git log -S\":\n\n  git log -1 -p -Scheck_path_for_gitlink\n\n(and then you can see that the whole function went away there).\n\n-Peff\n"},{"id":"301921","messageId":"CAKoko1qKLPWZEZxzHkrpm-tvz4oLMf=odRLNSRgrHXPxGhHFvg@mail.gmail.com","threadId":"44074","inReplyTo":"20160914192341.mgpcc35kgmjqunbh@sigill.intra.peff.net","subject":"Re: [PATCH] pathspec: removed unnecessary function prototypes","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2016-09-14T19:30:49Z","receivedAt":"2016-09-14T19:30:56Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On Wed, Sep 14, 2016 at 12:23 PM, Jeff King <peff@peff.net> wrote:\n\n> On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote:\n> I should have done a better job of not just providing the answer, but\n> showing how. The easiest tool here is \"git log -S\":\n>\n>   git log -1 -p -Scheck_path_for_gitlink\n>\n> (and then you can see that the whole function went away there).\n>\n> -Peff\n\nPerfect thanks! There's still a lot of little features like this that\nI'm unaware\nof so I really appreciate the pointer.\n\n-Brandon\n"}]}