{"thread":{"id":"44047","subject":"[PATCH] git-gui: respect commit.gpgsign again","startedAt":"2016-09-09T12:28:49Z","lastAt":"2016-09-12T08:15:15Z","messageCount":5,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"301487","messageId":"550e7de5e08e53b5893e1ce021bffee468adfc9d.1473424091.git.johannes.schindelin@gmx.de","threadId":"44047","inReplyTo":null,"subject":"[PATCH] git-gui: respect commit.gpgsign again","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-09-09T12:28:24Z","receivedAt":"2016-09-09T12:28:49Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"As of v2.9.0, `git commit-tree` no longer heeds the `commit.gpgsign`\nconfig setting. This broke committing in Git GUI.\n\nThis fixes https://github.com/git-for-windows/git/issues/850\n\nSigned-off-by: Johannes Schindelin \n---\nPublished-As: https://github.com/dscho/git/releases/tag/git-gui-gpgsign-v1\nFetch-It-Via: git fetch https://github.com/dscho/git git-gui-gpgsign-v1\n\n git-gui/lib/commit.tcl | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl\nindex 864b687..01d2cc2 100644\n--- a/git-gui/lib/commit.tcl\n+++ b/git-gui/lib/commit.tcl\n@@ -369,6 +369,9 @@ A rescan will be automatically started now.\n \t# -- Create the commit.\n \t#\n \tset cmd [list commit-tree $tree_id]\n+\tif {[is_config_true commit.gpgsign]} {\n+\t\tlappend cmd -S\n+\t}\n \tforeach p [concat $PARENT $MERGE_HEAD] {\n \t\tlappend cmd -p $p\n \t}\n-- \n2.10.0.windows.1.10.g803177d\n\nbase-commit: 6ebdac1bab966b720d776aa43ca188fe378b1f4b\n"},{"id":"301539","messageId":"xmqqr38tapv0.fsf@gitster.mtv.corp.google.com","threadId":"44047","inReplyTo":"550e7de5e08e53b5893e1ce021bffee468adfc9d.1473424091.git.johannes.schindelin@gmx.de","subject":"Re: [PATCH] git-gui: respect commit.gpgsign again","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-09T18:29:39Z","receivedAt":"2016-09-09T18:29:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> As of v2.9.0, `git commit-tree` no longer heeds the `commit.gpgsign`\n> config setting. This broke committing in Git GUI.\n\nThanks. Will shift it up to apply to my copy of git-gui project and\nthen pull in the result.\n\n> git-gui/lib/commit.tcl | 3 +++\n> 1 file changed, 3 insertions(+)\n"},{"id":"301591","messageId":"alpine.DEB.2.20.1609100903010.129229@virtualbox","threadId":"44047","inReplyTo":"xmqqr38tapv0.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] git-gui: respect commit.gpgsign again","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-09-10T07:05:32Z","receivedAt":"2016-09-10T07:05:57Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Fri, 9 Sep 2016, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > As of v2.9.0, `git commit-tree` no longer heeds the `commit.gpgsign`\n> > config setting. This broke committing in Git GUI.\n> \n> Thanks. Will shift it up to apply to my copy of git-gui project and\n> then pull in the result.\n\nThanks. There are a couple more git-gui patches waiting for quite a long\ntime. So you prefer them still as patches to git-gui.git?\n\nAlso, I just noticed poor wording. Would you mind fixing it up by\n\n\ts/committing/& with GPG signature/\n\n?\n\nThanks,\nDscho\n"},{"id":"301672","messageId":"xmqqr38q6r5b.fsf@gitster.mtv.corp.google.com","threadId":"44047","inReplyTo":"alpine.DEB.2.20.1609100903010.129229@virtualbox","subject":"Re: [PATCH] git-gui: respect commit.gpgsign again","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-11T21:52:16Z","receivedAt":"2016-09-11T21:52:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Thanks. There are a couple more git-gui patches waiting for quite a long\n> time. So you prefer them still as patches to git-gui.git?\n\nI prefer not to have to worry about them myself ;-) That means that\neven if Pat steps down, the next maintainer for git-gui project\nwould not be me, so I wouldn't be making a unilateral decision to\nre-root git-gui.git project one-level down.\n\n> Also, I just noticed poor wording. Would you mind fixing it up by\n>\n> \ts/committing/& with GPG signature/\n\nOuch, I didn't notice. It's not in 'next' yet, so let me see if I\ncan futz with the history.\n\nThanks.\n"},{"id":"301692","messageId":"alpine.DEB.2.20.1609121013510.129229@virtualbox","threadId":"44047","inReplyTo":"xmqqr38q6r5b.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] git-gui: respect commit.gpgsign again","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-09-12T08:14:27Z","receivedAt":"2016-09-12T08:15:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Sun, 11 Sep 2016, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > Thanks. There are a couple more git-gui patches waiting for quite a long\n> > time. So you prefer them still as patches to git-gui.git?\n> \n> I prefer not to have to worry about them myself ;-) That means that\n> even if Pat steps down, the next maintainer for git-gui project\n> would not be me, so I wouldn't be making a unilateral decision to\n> re-root git-gui.git project one-level down.\n\nMakes sense.\n\n> > Also, I just noticed poor wording. Would you mind fixing it up by\n> >\n> > \ts/committing/& with GPG signature/\n> \n> Ouch, I didn't notice. It's not in 'next' yet, so let me see if I\n> can futz with the history.\n\nThank you!\nDscho\n"}]}