{"thread":{"id":"44007","subject":"[PATCH] Avoid hard-coded perl path in sha-bang","startedAt":"2016-09-05T15:38:08Z","lastAt":"2016-09-05T19:41:29Z","messageCount":2,"participants":["iblis","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"301098","messageId":"ddf84da5-036f-6e4f-839d-cef1f7ede4be@hs.ntnu.edu.tw","threadId":"44007","inReplyTo":"01020156faf163db-3a2e9796-3b12-43d2-90dd-2b843896a5b7-000000@eu-west-1.amazonses.com","subject":"[PATCH] Avoid hard-coded perl path in sha-bang","fromName":"iblis","fromEmail":"iblis@hs.ntnu.edu.tw","sentAt":"2016-09-05T15:28:18Z","receivedAt":"2016-09-05T15:38:08Z","isPatch":true,"sender":{"key":"iblis@hs.ntnu.edu.tw","avatar":null},"body":"Signed-off-by: Iblis Lin <iblis@hs.ntnu.edu.tw>\n\n---\n  contrib/diff-highlight/diff-highlight | 2 +-\n  1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highlight\nindex ffefc31..b57b0fd 100755\n--- a/contrib/diff-highlight/diff-highlight\n+++ b/contrib/diff-highlight/diff-highlight\n@@ -1,4 +1,4 @@\n-#!/usr/bin/perl\n+#!/usr/bin/env perl\n  \n  use 5.008;\n  use warnings FATAL => 'all';\n\n\n--\n\nIblis Lin\n\n"},{"id":"301114","messageId":"20160905194115.wn7uo2fnzolms6uy@vauxhall.crustytoothpaste.net","threadId":"44007","inReplyTo":"ddf84da5-036f-6e4f-839d-cef1f7ede4be@hs.ntnu.edu.tw","subject":"Re: [PATCH] Avoid hard-coded perl path in sha-bang","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2016-09-05T19:41:15Z","receivedAt":"2016-09-05T19:41:29Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Mon, Sep 05, 2016 at 11:28:18PM +0800, iblis wrote:\n> Signed-off-by: Iblis Lin <iblis@hs.ntnu.edu.tw>\n> \n> ---\n>  contrib/diff-highlight/diff-highlight | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highlight\n> index ffefc31..b57b0fd 100755\n> --- a/contrib/diff-highlight/diff-highlight\n> +++ b/contrib/diff-highlight/diff-highlight\n> @@ -1,4 +1,4 @@\n> -#!/usr/bin/perl\n> +#!/usr/bin/env perl\n>  use 5.008;\n>  use warnings FATAL => 'all';\n\nThis isn't consistent with what the other contrib scripts do, and\n/usr/bin/env perl isn't always the right perl for all situations.  What\nyou probably want is to do something like this, which is listed in the\nMakefile.\n\n# Individual rules to allow e.g.\n# \"make -C ../.. SCRIPT_PERL=contrib/foo/bar.perl build-perl-script\"\n# from subdirectories like contrib/*/\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: https://keybase.io/bk2204\n"}]}