{"thread":{"id":"44006","subject":"[PATCH 0/4] test suite: use the GIT_TRACE_CURL environment var","startedAt":"2016-09-05T10:24:55Z","lastAt":"2016-09-07T20:00:00Z","messageCount":9,"participants":["Elia Pinto","Eric Sunshine","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"301092","messageId":"20160905102444.3586-1-gitter.spiros@gmail.com","threadId":"44006","inReplyTo":null,"subject":"[PATCH 0/4] test suite: use the GIT_TRACE_CURL environment var","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-09-05T10:24:40Z","receivedAt":"2016-09-05T10:24:55Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Use the new GIT_TRACE_CURL environment variable in the test suite \ninstead of the deprecated GIT_CURL_VERBOSE.\n\nElia Pinto (4):\n  t5541-http-push-smart.sh: use the GIT_TRACE_CURL environment var\n  test-lib.sh: preserve GIT_TRACE_CURL from the environment\n  t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var\n  t5551-http-fetch-smart.sh: use the GIT_TRACE_CURL environment var\n\n t/t5541-http-push-smart.sh  |  2 +-\n t/t5550-http-fetch-dumb.sh  | 13 ++++++++-----\n t/t5551-http-fetch-smart.sh | 15 ++++++++++++---\n t/test-lib.sh               |  1 +\n 4 files changed, 22 insertions(+), 9 deletions(-)\n\n-- \n2.10.0.308.gf73994d\n\n"},{"id":"301093","messageId":"20160905102444.3586-2-gitter.spiros@gmail.com","threadId":"44006","inReplyTo":"20160905102444.3586-1-gitter.spiros@gmail.com","subject":"[PATCH 1/4] t5541-http-push-smart.sh: use the GIT_TRACE_CURL environment var","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-09-05T10:24:41Z","receivedAt":"2016-09-05T10:25:00Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Use the new GIT_TRACE_CURL environment variable instead\nof the deprecated GIT_CURL_VERBOSE.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5541-http-push-smart.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh\nindex 4840c71..d38bf32 100755\n--- a/t/t5541-http-push-smart.sh\n+++ b/t/t5541-http-push-smart.sh\n@@ -74,7 +74,7 @@ test_expect_success 'push to remote repository (standard)' '\n \ttest_tick &&\n \tgit commit -m path2 &&\n \tHEAD=$(git rev-parse --verify HEAD) &&\n-\tGIT_CURL_VERBOSE=1 git push -v -v 2>err &&\n+\tGIT_TRACE_CURL=true git push -v -v 2>err &&\n \t! grep \"Expect: 100-continue\" err &&\n \tgrep \"POST git-receive-pack ([0-9]* bytes)\" err &&\n \t(cd \"$HTTPD_DOCUMENT_ROOT_PATH\"/test_repo.git &&\n-- \n2.10.0.308.gf73994d\n\n"},{"id":"301094","messageId":"20160905102444.3586-3-gitter.spiros@gmail.com","threadId":"44006","inReplyTo":"20160905102444.3586-1-gitter.spiros@gmail.com","subject":"[PATCH 2/4] test-lib.sh: preserve GIT_TRACE_CURL from the environment","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-09-05T10:24:42Z","receivedAt":"2016-09-05T10:25:03Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Turning on this variable can be useful when debugging http\ntests. It can break a few tests in t5541 if not set\nto an absolute path but it is not a variable\nthat the user is likely to have enabled accidentally.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/test-lib.sh | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex d731d66..986eba1 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -89,6 +89,7 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $(\"$PERL_PATH\" -e '\n \t\tUNZIP\n \t\tPERF_\n \t\tCURL_VERBOSE\n+\t\tTRACE_CURL\n \t));\n \tmy @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);\n \tprint join(\"\\n\", @vars);\n-- \n2.10.0.308.gf73994d\n\n"},{"id":"301095","messageId":"20160905102444.3586-4-gitter.spiros@gmail.com","threadId":"44006","inReplyTo":"20160905102444.3586-1-gitter.spiros@gmail.com","subject":"[PATCH 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-09-05T10:24:43Z","receivedAt":"2016-09-05T10:25:09Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Use the new GIT_TRACE_CURL environment variable instead\nof the deprecated GIT_CURL_VERBOSE.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5550-http-fetch-dumb.sh | 13 ++++++++-----\n 1 file changed, 8 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh\nindex 3484b6f..75694ad 100755\n--- a/t/t5550-http-fetch-dumb.sh\n+++ b/t/t5550-http-fetch-dumb.sh\n@@ -263,15 +263,18 @@ check_language () {\n \t\t>expect\n \t\t;;\n \t?*)\n-\t\techo \"Accept-Language: $1\" >expect\n+\t\techo \"=> Send header: Accept-Language: $1\" >expect\n \t\t;;\n \tesac &&\n-\tGIT_CURL_VERBOSE=1 \\\n+\tGIT_TRACE_CURL=true \\\n \tLANGUAGE=$2 \\\n \tgit ls-remote \"$HTTPD_URL/dumb/repo.git\" >output 2>&1 &&\n \ttr -d '\\015' <output |\n \tsort -u |\n-\tsed -ne '/^Accept-Language:/ p' >actual &&\n+\tsed -ne '/^=> Send header: Accept-Language:/ p' >actual &&\n+\tcp expect expect.$$ &&\n+\tcp actual actual.$$ &&\n+\tcp output output.$$ &&\n \ttest_cmp expect actual\n }\n \n@@ -295,8 +298,8 @@ ja;q=0.95, zh;q=0.94, sv;q=0.93, pt;q=0.92, nb;q=0.91, *;q=0.90\" \\\n '\n \n test_expect_success 'git client does not send an empty Accept-Language' '\n-\tGIT_CURL_VERBOSE=1 LANGUAGE= git ls-remote \"$HTTPD_URL/dumb/repo.git\" 2>stderr &&\n-\t! grep \"^Accept-Language:\" stderr\n+\tGIT_TRACE_CURL=true LANGUAGE= git ls-remote \"$HTTPD_URL/dumb/repo.git\" 2>stderr &&\n+\t! grep \"^=> Send header: Accept-Language:\" stderr\n '\n \n stop_httpd\n-- \n2.10.0.308.gf73994d\n\n"},{"id":"301096","messageId":"20160905102444.3586-5-gitter.spiros@gmail.com","threadId":"44006","inReplyTo":"20160905102444.3586-1-gitter.spiros@gmail.com","subject":"[PATCH 4/4] t5551-http-fetch-smart.sh: use the GIT_TRACE_CURL environment var","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-09-05T10:24:44Z","receivedAt":"2016-09-05T10:25:12Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Use the new GIT_TRACE_CURL environment variable instead\nof the deprecated GIT_CURL_VERBOSE.\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n t/t5551-http-fetch-smart.sh | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)\n\ndiff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh\nindex 2f375eb..1ec5b27 100755\n--- a/t/t5551-http-fetch-smart.sh\n+++ b/t/t5551-http-fetch-smart.sh\n@@ -43,12 +43,21 @@ cat >exp <<EOF\n < Content-Type: application/x-git-upload-pack-result\n EOF\n test_expect_success 'clone http repository' '\n-\tGIT_CURL_VERBOSE=1 git clone --quiet $HTTPD_URL/smart/repo.git clone 2>err &&\n+\tGIT_TRACE_CURL=true git clone --quiet $HTTPD_URL/smart/repo.git clone 2>err &&\n \ttest_cmp file clone/file &&\n \ttr '\\''\\015'\\'' Q <err |\n \tsed -e \"\n \t\ts/Q\\$//\n \t\t/^[*] /d\n+\t\t/^== Info:/d\n+\t\t/^=> Send header, /d\n+\t\t/^=> Send header:$/d\n+\t\t/^<= Recv header, /d\n+\t\t/^<= Recv header:$/d\n+\t\ts/=> Send header: //\n+\t\ts/= Recv header://\n+\t\t/^<= Recv data/d\n+\t\t/^=> Send data/d\n \t\t/^$/d\n \t\t/^< $/d\n \n@@ -261,9 +270,9 @@ test_expect_success CMDLINE_LIMIT \\\n '\n \n test_expect_success 'large fetch-pack requests can be split across POSTs' '\n-\tGIT_CURL_VERBOSE=1 git -c http.postbuffer=65536 \\\n+\tGIT_TRACE_CURL=true git -c http.postbuffer=65536 \\\n \t\tclone --bare \"$HTTPD_URL/smart/repo.git\" split.git 2>err &&\n-\tgrep \"^> POST\" err >posts &&\n+\tgrep \"^=> Send header: POST\" err >posts &&\n \ttest_line_count = 2 posts\n '\n \n-- \n2.10.0.308.gf73994d\n\n"},{"id":"301097","messageId":"CAPig+cTsCDpCQ9j82OEa13YBYswDKfYd_dc1QbxRSRk3wiOhHw@mail.gmail.com","threadId":"44006","inReplyTo":"20160905102444.3586-4-gitter.spiros@gmail.com","subject":"Re: [PATCH 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2016-09-05T13:43:14Z","receivedAt":"2016-09-05T13:43:21Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Sep 5, 2016 at 6:24 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:\n> Use the new GIT_TRACE_CURL environment variable instead\n> of the deprecated GIT_CURL_VERBOSE.\n>\n> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>\n> ---\n> diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh\n> @@ -263,15 +263,18 @@ check_language () {\n>                 >expect\n>                 ;;\n>         ?*)\n> -               echo \"Accept-Language: $1\" >expect\n> +               echo \"=> Send header: Accept-Language: $1\" >expect\n>                 ;;\n>         esac &&\n> -       GIT_CURL_VERBOSE=1 \\\n> +       GIT_TRACE_CURL=true \\\n>         LANGUAGE=$2 \\\n>         git ls-remote \"$HTTPD_URL/dumb/repo.git\" >output 2>&1 &&\n>         tr -d '\\015' <output |\n>         sort -u |\n> -       sed -ne '/^Accept-Language:/ p' >actual &&\n> +       sed -ne '/^=> Send header: Accept-Language:/ p' >actual &&\n> +       cp expect expect.$$ &&\n> +       cp actual actual.$$ &&\n> +       cp output output.$$ &&\n\nWhat are these three cp's about? They don't seem to be related to the\nstated changes. Are they leftover debugging gunk?\n\n>         test_cmp expect actual\n>  }\n>\n> @@ -295,8 +298,8 @@ ja;q=0.95, zh;q=0.94, sv;q=0.93, pt;q=0.92, nb;q=0.91, *;q=0.90\" \\\n>  '\n>\n>  test_expect_success 'git client does not send an empty Accept-Language' '\n> -       GIT_CURL_VERBOSE=1 LANGUAGE= git ls-remote \"$HTTPD_URL/dumb/repo.git\" 2>stderr &&\n> -       ! grep \"^Accept-Language:\" stderr\n> +       GIT_TRACE_CURL=true LANGUAGE= git ls-remote \"$HTTPD_URL/dumb/repo.git\" 2>stderr &&\n> +       ! grep \"^=> Send header: Accept-Language:\" stderr\n>  '\n>\n>  stop_httpd\n"},{"id":"301110","messageId":"CA+EOSBki1E8HJ1DMuAuQaB6sBcUjvQLA5xUWdF9G+6+HRQUD7g@mail.gmail.com","threadId":"44006","inReplyTo":"CAPig+cTsCDpCQ9j82OEa13YBYswDKfYd_dc1QbxRSRk3wiOhHw@mail.gmail.com","subject":"Re: [PATCH 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2016-09-05T19:09:23Z","receivedAt":"2016-09-05T19:09:28Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"2016-09-05 15:43 GMT+02:00 Eric Sunshine <sunshine@sunshineco.com>:\n> On Mon, Sep 5, 2016 at 6:24 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:\n>> Use the new GIT_TRACE_CURL environment variable instead\n>> of the deprecated GIT_CURL_VERBOSE.\n>>\n>> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>\n>> ---\n>> diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh\n>> @@ -263,15 +263,18 @@ check_language () {\n>>                 >expect\n>>                 ;;\n>>         ?*)\n>> -               echo \"Accept-Language: $1\" >expect\n>> +               echo \"=> Send header: Accept-Language: $1\" >expect\n>>                 ;;\n>>         esac &&\n>> -       GIT_CURL_VERBOSE=1 \\\n>> +       GIT_TRACE_CURL=true \\\n>>         LANGUAGE=$2 \\\n>>         git ls-remote \"$HTTPD_URL/dumb/repo.git\" >output 2>&1 &&\n>>         tr -d '\\015' <output |\n>>         sort -u |\n>> -       sed -ne '/^Accept-Language:/ p' >actual &&\n>> +       sed -ne '/^=> Send header: Accept-Language:/ p' >actual &&\n>> +       cp expect expect.$$ &&\n>> +       cp actual actual.$$ &&\n>> +       cp output output.$$ &&\n>\n> What are these three cp's about? They don't seem to be related to the\n> stated changes. Are they leftover debugging gunk?\nYes, i am very sorry. My bad. I will repost. Thanks\n\n\n>\n>>         test_cmp expect actual\n>>  }\n>>\n>> @@ -295,8 +298,8 @@ ja;q=0.95, zh;q=0.94, sv;q=0.93, pt;q=0.92, nb;q=0.91, *;q=0.90\" \\\n>>  '\n>>\n>>  test_expect_success 'git client does not send an empty Accept-Language' '\n>> -       GIT_CURL_VERBOSE=1 LANGUAGE= git ls-remote \"$HTTPD_URL/dumb/repo.git\" 2>stderr &&\n>> -       ! grep \"^Accept-Language:\" stderr\n>> +       GIT_TRACE_CURL=true LANGUAGE= git ls-remote \"$HTTPD_URL/dumb/repo.git\" 2>stderr &&\n>> +       ! grep \"^=> Send header: Accept-Language:\" stderr\n>>  '\n>>\n>>  stop_httpd\n"},{"id":"301307","messageId":"xmqqpoofmuru.fsf@gitster.mtv.corp.google.com","threadId":"44006","inReplyTo":"CA+EOSBki1E8HJ1DMuAuQaB6sBcUjvQLA5xUWdF9G+6+HRQUD7g@mail.gmail.com","subject":"Re: [PATCH 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-07T18:25:57Z","receivedAt":"2016-09-07T18:26:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto <gitter.spiros@gmail.com> writes:\n\n>>> +       cp expect expect.$$ &&\n>>> +       cp actual actual.$$ &&\n>>> +       cp output output.$$ &&\n>>\n>> What are these three cp's about? They don't seem to be related to the\n>> stated changes. Are they leftover debugging gunk?\n> Yes, i am very sorry. My bad. I will repost. Thanks\n\nNevertheless, thanks for these clean-ups.  Will discard this round\nwaiting for a reroll.\n"},{"id":"301321","messageId":"xmqqeg4vlbxv.fsf@gitster.mtv.corp.google.com","threadId":"44006","inReplyTo":"xmqqpoofmuru.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 3/4] t5550-http-fetch-dumb.sh: use the GIT_TRACE_CURL environment var","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-07T19:58:04Z","receivedAt":"2016-09-07T20:00:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> Elia Pinto <gitter.spiros@gmail.com> writes:\n>\n>>>> +       cp expect expect.$$ &&\n>>>> +       cp actual actual.$$ &&\n>>>> +       cp output output.$$ &&\n>>>\n>>> What are these three cp's about? They don't seem to be related to the\n>>> stated changes. Are they leftover debugging gunk?\n>> Yes, i am very sorry. My bad. I will repost. Thanks\n>\n> Nevertheless, thanks for these clean-ups.  Will discard this round\n> waiting for a reroll.\n\nNevermind.  I see you rerolled only this one labeled as \"v1 3/4\";\npicked up the rest from this series and combined with that reroll.\n\nThanks.\n\n\n"}]}