{"thread":{"id":"43956","subject":"[PATCH v1] pack-protocol: fix maximum pkt-line size","startedAt":"2016-08-29T17:55:20Z","lastAt":"2016-08-31T05:42:13Z","messageCount":2,"participants":["larsxschneider@gmail.com","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"300475","messageId":"20160829175509.69050-1-larsxschneider@gmail.com","threadId":"43956","inReplyTo":null,"subject":"[PATCH v1] pack-protocol: fix maximum pkt-line size","fromName":"","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-08-29T17:55:09Z","receivedAt":"2016-08-29T17:55:20Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"From: Lars Schneider <larsxschneider@gmail.com>\n\nAccording to LARGE_PACKET_MAX in pkt-line.h the maximal length of a\npkt-line packet is 65520 bytes. The pkt-line header takes 4 bytes and\ntherefore the pkt-line data component must not exceed 65516 bytes.\n\nSigned-off-by: Lars Schneider <larsxschneider@gmail.com>\n---\n\nThis patch was part of my \"Git filter protocol\" series [1]. Stefan\nsuggested to submit this patch individually as it is not strictly\nrequired in the series [2].\n\nThanks,\nLars\n\n\n[1] http://public-inbox.org/git/20160825110752.31581-1-larsxschneider@gmail.com/\n[2] http://public-inbox.org/git/CAGZ79kaJn-yf28+Ls2JyqSs6Jt-Oj2JW-sAXQn-Oe5xaxSyjMQ@mail.gmail.com/\n\n\n Documentation/technical/protocol-common.txt | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/technical/protocol-common.txt b/Documentation/technical/protocol-common.txt\nindex bf30167..ecedb34 100644\n--- a/Documentation/technical/protocol-common.txt\n+++ b/Documentation/technical/protocol-common.txt\n@@ -67,9 +67,9 @@ with non-binary data the same whether or not they contain the trailing\n LF (stripping the LF if present, and not complaining when it is\n missing).\n\n-The maximum length of a pkt-line's data component is 65520 bytes.\n-Implementations MUST NOT send pkt-line whose length exceeds 65524\n-(65520 bytes of payload + 4 bytes of length data).\n+The maximum length of a pkt-line's data component is 65516 bytes.\n+Implementations MUST NOT send pkt-line whose length exceeds 65520\n+(65516 bytes of payload + 4 bytes of length data).\n\n Implementations SHOULD NOT send an empty pkt-line (\"0004\").\n\n--\n2.9.2\n\n"},{"id":"300625","messageId":"CAGZ79kYv1o1M5KiR0yQeUUsZLo_VFbyDRNGSwPqjvV_s5HkFEw@mail.gmail.com","threadId":"43956","inReplyTo":"20160829175509.69050-1-larsxschneider@gmail.com","subject":"Re: [PATCH v1] pack-protocol: fix maximum pkt-line size","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-08-31T05:39:14Z","receivedAt":"2016-08-31T05:42:13Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Mon, Aug 29, 2016 at 10:55 AM,  <larsxschneider@gmail.com> wrote:\n> From: Lars Schneider <larsxschneider@gmail.com>\n>\n> According to LARGE_PACKET_MAX in pkt-line.h the maximal length of a\n> pkt-line packet is 65520 bytes. The pkt-line header takes 4 bytes and\n> therefore the pkt-line data component must not exceed 65516 bytes.\n>\n> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>\n> ---\n>\n> This patch was part of my \"Git filter protocol\" series [1]. Stefan\n> suggested to submit this patch individually as it is not strictly\n> required in the series [2].\n>\n> Thanks,\n> Lars\n>\n>\n> [1] http://public-inbox.org/git/20160825110752.31581-1-larsxschneider@gmail.com/\n> [2] http://public-inbox.org/git/CAGZ79kaJn-yf28+Ls2JyqSs6Jt-Oj2JW-sAXQn-Oe5xaxSyjMQ@mail.gmail.com/\n>\n>\n>  Documentation/technical/protocol-common.txt | 6 +++---\n>  1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/Documentation/technical/protocol-common.txt b/Documentation/technical/protocol-common.txt\n> index bf30167..ecedb34 100644\n> --- a/Documentation/technical/protocol-common.txt\n> +++ b/Documentation/technical/protocol-common.txt\n> @@ -67,9 +67,9 @@ with non-binary data the same whether or not they contain the trailing\n>  LF (stripping the LF if present, and not complaining when it is\n>  missing).\n>\n> -The maximum length of a pkt-line's data component is 65520 bytes.\n> -Implementations MUST NOT send pkt-line whose length exceeds 65524\n> -(65520 bytes of payload + 4 bytes of length data).\n> +The maximum length of a pkt-line's data component is 65516 bytes.\n> +Implementations MUST NOT send pkt-line whose length exceeds 65520\n> +(65516 bytes of payload + 4 bytes of length data).\n>\n>  Implementations SHOULD NOT send an empty pkt-line (\"0004\").\n>\n\nThis looks good,\n\nThanks,\nStefan\n\n> --\n> 2.9.2\n>\n"}]}