{"thread":{"id":"43950","subject":"Re: [Ksummit-discuss] checkkpatch (in)sanity ?","startedAt":"2016-08-28T19:53:10Z","lastAt":"2016-08-28T21:58:04Z","messageCount":4,"participants":["Joe Perches","Jiri Kosina","Dennis Kaarsemaker"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"300374","messageId":"1472413969.26978.108.camel@perches.com","threadId":"43950","inReplyTo":"alpine.DEB.2.10.1608281152080.3321@hadrien","subject":"Re: [Ksummit-discuss] checkkpatch (in)sanity ?","fromName":"Joe Perches","fromEmail":"joe@perches.com","sentAt":"2016-08-28T19:52:49Z","receivedAt":"2016-08-28T19:53:10Z","isPatch":false,"sender":{"key":"joe@perches.com","avatar":"https://avatars.githubusercontent.com/u/13122723?v=4"},"body":"On Sun, 2016-08-28 at 11:59 +0200, Julia Lawall wrote:\n> On Sun, 28 Aug 2016, Alexey Dobriyan wrote:\n[]\n> > The problem is that c-h.pl generates noise in the commit history and\n> > makes git-blame less useful than it can be.\n> \n> Could it be that this is a problem with git blame, rather than with\n> checkpatch?  Last year there was a discussion on this list about how there\n> is an option to git blame that will cause it to step through the history,\n> and not show only the most recent patch that has modified a given line.\n\nIt is more or less an ease-of-use limitation of git blame.\n\nThere are some that want an ncurses only version of git blame\nthat could\nuse arrow-key style navigation for historical commit\nline-ranges.\n\ngit gui blame kind of works, but it's not ncurses/text based.\ngit-cola kind of works too, but it's not text based either.\n\nAre there other existing tools for blame history viewing?\n"},{"id":"300375","messageId":"alpine.LNX.2.00.1608282234290.22028@cbobk.fhfr.pm","threadId":"43950","inReplyTo":"1472413969.26978.108.camel@perches.com","subject":"Re: [Ksummit-discuss] checkkpatch (in)sanity ?","fromName":"Jiri Kosina","fromEmail":"jikos@kernel.org","sentAt":"2016-08-28T20:35:24Z","receivedAt":"2016-08-28T20:35:56Z","isPatch":false,"sender":{"key":"jikos@kernel.org","avatar":null},"body":"On Sun, 28 Aug 2016, Joe Perches wrote:\n\n> Are there other existing tools for blame history viewing?\n\nfugitive vim plugin has 'Gblame' command, which I personally find rather \nuseful, and given the text-oriented nature could potentially be useful for \nyour needs.\n\n-- \nJiri Kosina\nSUSE Labs\n\n"},{"id":"300377","messageId":"1472419498.4265.16.camel@kaarsemaker.net","threadId":"43950","inReplyTo":"1472413969.26978.108.camel@perches.com","subject":"Re: [Ksummit-discuss] checkkpatch (in)sanity ?","fromName":"Dennis Kaarsemaker","fromEmail":"dennis@kaarsemaker.net","sentAt":"2016-08-28T21:24:58Z","receivedAt":"2016-08-28T21:25:22Z","isPatch":false,"sender":{"key":"dennis@kaarsemaker.net","avatar":"https://avatars.githubusercontent.com/u/200649?v=4"},"body":"On zo, 2016-08-28 at 12:52 -0700, Joe Perches wrote:\n> On Sun, 2016-08-28 at 11:59 +0200, Julia Lawall wrote:\n> > \n> > On Sun, 28 Aug 2016, Alexey Dobriyan wrote:\n> []\n> > \n> > > \n> > > The problem is that c-h.pl generates noise in the commit history\n> > > and\n> > > makes git-blame less useful than it can be.\n> > Could it be that this is a problem with git blame, rather than with\n> > checkpatch?  Last year there was a discussion on this list about\n> > how there\n> > is an option to git blame that will cause it to step through the\n> > history,\n> > and not show only the most recent patch that has modified a given\n> > line.\n> It is more or less an ease-of-use limitation of git blame.\n> \n> There are some that want an ncurses only version of git blame\n> that could\n> use arrow-key style navigation for historical commit\n> line-ranges.\n> \n> git gui blame kind of works, but it's not ncurses/text based.\n> git-cola kind of works too, but it's not text based either.\n> \n> Are there other existing tools for blame history viewing?\n\ntig has a neat way of doing blame history digging: do a `tig blame\nfilename`, select a line and hit the comma key to re-blame from the\nparent of the commit that was blamed for that line.\n\n(hat tip to Jeff King who pointed out this trick recently)\n\nD.\n"},{"id":"300378","messageId":"1472421462.26978.134.camel@perches.com","threadId":"43950","inReplyTo":"1472419498.4265.16.camel@kaarsemaker.net","subject":"Re: [Ksummit-discuss] checkkpatch (in)sanity ?","fromName":"Joe Perches","fromEmail":"joe@perches.com","sentAt":"2016-08-28T21:57:42Z","receivedAt":"2016-08-28T21:58:04Z","isPatch":false,"sender":{"key":"joe@perches.com","avatar":"https://avatars.githubusercontent.com/u/13122723?v=4"},"body":"On Sun, 2016-08-28 at 23:24 +0200, Dennis Kaarsemaker wrote:\n\n> > There are some that want an ncurses only version of git blame\n> > that could use arrow-key style navigation for historical commit\n> > line-ranges.\n> > \n> > git gui blame kind of works, but it's not ncurses/text based.\n> > git-cola kind of works too, but it's not text based either.\n> > \n> > Are there other existing tools for blame history viewing?\n> tig has a neat way of doing blame history digging: do a `tig blame\n> filename`, select a line and hit the comma key to re-blame from the\n> parent of the commit that was blamed for that line.\n\nThanks, of course I neglected to mention tig.\n\nWhat I think some here want is the ability to view\nback and forth from old to new rather than just split\nthe window horizontally with the commit content.\n\nBasically, apply the patch hunks for a specific range\nto see color coded changes rather just show the entire\npatch in a separate view.\n\nSure, seeing the commit log and patch is useful.\n\nSeeing the block of code pre and post patch for the\nspecific section can be more useful.\n\n"}]}