{"thread":{"id":"4395","subject":"Re: [PATCH, take 2] Add example xinetd(8) configuration to Documentation/everyday.txt","startedAt":"2006-06-05T00:54:15Z","lastAt":"2006-06-05T13:12:37Z","messageCount":3,"participants":["Horst von Brand","Junio C Hamano","Dmitry V. Levin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"21242","messageId":"200606050054.k550sFCC018490@laptop11.inf.utfsm.cl","threadId":"4395","inReplyTo":"ldv@altlinux.org","subject":"Re: [PATCH, take 2] Add example xinetd(8) configuration to Documentation/everyday.txt","fromName":"Horst von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2006-06-05T00:54:15Z","receivedAt":"2006-06-05T00:54:15Z","isPatch":true,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"Dmitry V. Levin wrote:\n> It is a bad advice to run git-daemon as root.\n\nRight, my bad. Fixed patch below.\n[Really dumb question: How do you separate comments, like this, from the\n commit itself? Here done with dashes.]\n--------\nAdd example xinetd(8) configuration to Documentation/everyday.txt\n\nMany Linux distributions use xinetd(8), not inetd(8).\nGive a sample configuration file.\n\nSigned-off-by: Horst H. von Brand \n---\n Documentation/everyday.txt | 23 +++++++++++++++++++++++\n 1 files changed, 23 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/everyday.txt b/Documentation/everyday.txt\nindex 2ad2d61..ffba543 100644\n--- a/Documentation/everyday.txt\n+++ b/Documentation/everyday.txt\n@@ -377,6 +377,29 @@ git\tstream\ttcp\tnowait\tnobody \\\n +\n The actual configuration line should be on one line.\n \n+Run git-daemon to serve /pub/scm from xinetd.::\n++\n+------------\n+$ cat /etc/xinetd.d/git-daemon\n+# default: off\n+# description: The git server offers access to git repositories\n+service git\n+{\n+ disable = no\n+ type = UNLISTED\n+ port = 9418\n+ socket_type = stream\n+ wait = no\n+ user = root\n+ server = /usr/bin/git-daemon\n+ server_args = --inetd --syslog --export-all --base-path=/pub/scm\n+ log_on_failure += USERID\n+}\n+------------\n++\n+Check your xinetd(8) documentation and setup, this is from a Fedora system.\n+Others might be different.\n+\n Give push/pull only access to developers.::\n +\n ------------\n-- \n1.3.3.g16a4\n"},{"id":"21243","messageId":"7vbqt875te.fsf@assigned-by-dhcp.cox.net","threadId":"4395","inReplyTo":"200606050054.k550sFCC018490@laptop11.inf.utfsm.cl","subject":"Re: [PATCH, take 2] Add example xinetd(8) configuration to Documentation/everyday.txt","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-05T01:24:29Z","receivedAt":"2006-06-05T01:24:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I do not know if the above address again bounces for me, but you\nwill see that on the list I presume...\n\n> [Really dumb question: How do you separate comments, like this, from the\n> commit itself? Here done with dashes.]\n\nThere are two ways often used on this list.\n\n(1) Traditional, \"really automatable and nicer to the\n maintainer\" style.\n\n\tFrom xxx\n Subject: [PATCH] Add example xinetd(8) config...\n\n Commit log comes here, without the cover letter\n material.\n\n Signed-off-by: A U Thor \n\t---\n\t * Cover letter material comes here, before the usual\n diffstat and patch\n\n Documentation/everyday.txt | 23 +++++++++++++++++++++++\n 1 files changed, 23 insertions(+), 0 deletions(-)\n\n diff --git a/Documentation/everyday.txt b/Documenta...\n\tindex 2ad2d61..ffba543 100644\n\n Two points to observe:\n\n - Subject: should be changed to match the first line of the\n commit log message you would want to see, as needed.\n\n - cover letter material comes after the \"---\\n\" line.\n\n When the cover letter material is short, this is often\n preferred, since I can just run \"git am\" on the whole thing\n and everything after the first \"^---\", including your cover\n letter material, is omitted from the log message. It is,\n however, like top-posting and becomes harder to follow if\n the cover letter material gets long, in which case I\n personally prefer style (2) (but do not send style (2) to\n Linus).\n\n(2) e-mail style, but NEVER use \"---\" (or longer) marker between\n cover letter and the commit log.\n\n\tFrom xxx\n Subject: Re: some earlier discussion topic\n\n\tLonger discussion, rambling, quotes, and cover letter\n\tmaterial.\n\n\t-- >8 -- cut here -- >8 --\n [PATCH] Add example xinetd(8) config...\n\n Commit log comes here.\n\n Signed-off-by: A U Thor \n\t---\n Documentation/everyday.txt | 23 +++++++++++++++++++++++\n 1 files changed, 23 insertions(+), 0 deletions(-)\n\n diff --git a/Documentation/everyday.txt b/Documenta...\n\tindex 2ad2d61..ffba543 100644\n\n When the cover letter material is long, this is easier to\n read, because it avoids the problems associated with\n top-posting. However, when I apply this with \"git am\", I\n would need to go interactive and remove everything before\n the scissors line by hand.\n\nUsual patch application toolchain (either git-applymbox or\ngit-am) first splits your message at the first \"^---\" or \"^diff\n-\", and uses the part before that line to form the commit log\nmessage (together with what you have on the \"Subject:\" line).\nThe rest is fed to git-apply. What this means is that you do\nnot have to use the scissors logo (the tool does not know about\nit), but it is _absolutely_ necessary not to use anything that\nwould usually signal the tool of the commit log message in place\nof the scissors. If you have the cover letter first and then\n\"---\" or \"-----\" followed by the commit message after that, the\ncommit log message will be taken from the \"discussion, rambling,\nquotes, and cover letter material\" part and the real commit log\nyou wanted to have will not be seen at all, which needs to be\nhand fixed.\n"},{"id":"21259","messageId":"20060605131237.GA31565@basalt.office.altlinux.org","threadId":"4395","inReplyTo":"200606050054.k550sFCC018490@laptop11.inf.utfsm.cl","subject":"Re: [PATCH, take 2] Add example xinetd(8) configuration to Documentation/everyday.txt","fromName":"Dmitry V. Levin","fromEmail":"ldv@altlinux.org","sentAt":"2006-06-05T13:12:37Z","receivedAt":"2006-06-05T13:12:37Z","isPatch":true,"sender":{"key":"ldv@altlinux.org","avatar":"https://avatars.githubusercontent.com/u/5281408?v=4"},"body":"On Sun, Jun 04, 2006 at 08:54:15PM -0400, Horst von Brand wrote:\n> Dmitry V. Levin wrote:\n> > It is a bad advice to run git-daemon as root.\n> \n> Right, my bad. Fixed patch below.\n[...]\n> + user = root\n\nReally?\n\n\n-- \nldv\n"}]}