{"thread":{"id":"43922","subject":"[PATCH] Documentation/git-patch-id: give working code example","startedAt":"2016-08-24T12:57:30Z","lastAt":"2016-08-24T16:26:35Z","messageCount":2,"participants":["Michael J Gruber","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"300046","messageId":"5d33c4682e6251fc724b35c6f1c2f2a477a41b0a.1472043384.git.git@drmicha.warpmail.net","threadId":"43922","inReplyTo":null,"subject":"[PATCH] Documentation/git-patch-id: give working code example","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2016-08-24T12:56:52Z","receivedAt":"2016-08-24T12:57:30Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"As it stands, the documentation gives the impression that\n\ngit diff-tree <treeish> | git patch-id\n\nwould be a working invocation of git patch-id, leaving the novice user\nin the dark.\n\nMake it explicit that 'git diff-tree -p' would be the command to use.\n\nSigned-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n---\n Documentation/git-patch-id.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt\nindex cf71fba..67f8e28 100644\n--- a/Documentation/git-patch-id.txt\n+++ b/Documentation/git-patch-id.txt\n@@ -21,7 +21,7 @@ have the same \"patch ID\" are almost guaranteed to be the same thing.\n \n IOW, you can use this thing to look for likely duplicate commits.\n \n-When dealing with 'git diff-tree' output, it takes advantage of\n+When dealing with 'git diff-tree -p' output, it takes advantage of\n the fact that the patch is prefixed with the object name of the\n commit, and outputs two 40-byte hexadecimal strings.  The first\n string is the patch ID, and the second string is the commit ID.\n-- \n2.10.0.rc0.268.ge3ba28a\n\n"},{"id":"300074","messageId":"xmqqfupurvgv.fsf@gitster.mtv.corp.google.com","threadId":"43922","inReplyTo":"5d33c4682e6251fc724b35c6f1c2f2a477a41b0a.1472043384.git.git@drmicha.warpmail.net","subject":"Re: [PATCH] Documentation/git-patch-id: give working code example","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-08-24T16:18:56Z","receivedAt":"2016-08-24T16:26:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael J Gruber <git@drmicha.warpmail.net> writes:\n\n> As it stands, the documentation gives the impression that\n>\n> git diff-tree <treeish> | git patch-id\n>\n> would be a working invocation of git patch-id, leaving the novice user\n> in the dark.\n>\n> Make it explicit that 'git diff-tree -p' would be the command to use.\n\nI take the lack of <treeish> as a strong hint that it is not meant\nto be the full command line but merely there to make the command the\ndescription talks about stand out from others (i.e. \"This\ndescription does not apply to 'diff-files' or 'diff-cache' output\").\n\nSo I would think it is fine as-is.\n\nHaving said that, if we were to change something, I would rather\nreplace the mention of \"diff-tree\" with something like \"git show\" or\n\"git log -p\", neither of which were even present in their current\nform back when this piece of text was written.\n\n>\n> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n> ---\n>  Documentation/git-patch-id.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt\n> index cf71fba..67f8e28 100644\n> --- a/Documentation/git-patch-id.txt\n> +++ b/Documentation/git-patch-id.txt\n> @@ -21,7 +21,7 @@ have the same \"patch ID\" are almost guaranteed to be the same thing.\n>  \n>  IOW, you can use this thing to look for likely duplicate commits.\n>  \n> -When dealing with 'git diff-tree' output, it takes advantage of\n> +When dealing with 'git diff-tree -p' output, it takes advantage of\n>  the fact that the patch is prefixed with the object name of the\n>  commit, and outputs two 40-byte hexadecimal strings.  The first\n>  string is the patch ID, and the second string is the commit ID.\n"}]}