{"thread":{"id":"43762","subject":"[PATCH 2/5] upload-pack: Check for NOT_SHALLOW flag before sending a shallow to the client.","startedAt":"2006-11-24T14:58:25Z","lastAt":"2006-11-24T14:58:25Z","messageCount":1,"participants":["Alexandre Julliard"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"298189","messageId":"87wt5kuc1a.fsf@wine.dyndns.org","threadId":"43762","inReplyTo":null,"subject":"[PATCH 2/5] upload-pack: Check for NOT_SHALLOW flag before sending a shallow to the client.","fromName":"Alexandre Julliard","fromEmail":"julliard@winehq.org","sentAt":"2006-11-24T14:58:25Z","receivedAt":"2006-11-24T14:58:25Z","isPatch":true,"sender":{"key":"julliard@winehq.org","avatar":null},"body":"A commit may have been put on the shallow list, and then reached from\nanother branch and marked NOT_SHALLOW without being removed from the\nlist.\n\nSigned-off-by: Alexandre Julliard <julliard@winehq.org>\n---\n upload-pack.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/upload-pack.c b/upload-pack.c\nindex d5b4750..d4a7b62 100644\n--- a/upload-pack.c\n+++ b/upload-pack.c\n@@ -565,7 +565,7 @@ static void receive_needs(void)\n \t\t\tSHALLOW, NOT_SHALLOW);\n \t\twhile (result) {\n \t\t\tstruct object *object = &result->item->object;\n-\t\t\tif (!(object->flags & CLIENT_SHALLOW)) {\n+\t\t\tif (!(object->flags & (CLIENT_SHALLOW|NOT_SHALLOW))) {\n \t\t\t\tpacket_write(1, \"shallow %s\",\n \t\t\t\t\t\tsha1_to_hex(object->sha1));\n \t\t\t\tregister_shallow(object->sha1);\n-- \n1.4.4.1.ga335e\n\n-- \nAlexandre Julliard\n"}]}