{"thread":{"id":"43740","subject":"Re: Problem compiling: that perl thing again","startedAt":"2006-12-08T20:49:49Z","lastAt":"2006-12-08T21:26:30Z","messageCount":2,"participants":["Luben Tuikov","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"298280","messageId":"7vvekmgljm.fsf@assigned-by-dhcp.cox.net","threadId":"43740","inReplyTo":"805469.91804.qm@web31805.mail.mud.yahoo.com","subject":"Re: Problem compiling: that perl thing again","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-12-08T20:49:49Z","receivedAt":"2006-12-08T20:49:49Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> Over the last 2 months each time I pull, check out next and compile,\n> I'm seeing _some_ kind of problem with compiling the perl section\n> of git.  Sometimes git-reset --hard, or a fresh checkout, or git-clean\n> resolve the situation.  But not this time.\n> ...\n> So, where is \"perl.mak\"?\n\nThis particular breakage cannot be \"last two months\", but there\nwas a recent breakage by commit f848718a last week on the 'master'\nbranch.\n\n---\nJunio C Hamano <junkio@cox.net> writes:\n> merlyn@stonehenge.com (Randal L. Schwartz) writes:\n>\n>>>>>>> \"Alex\" == Alex Riesen <raa.lkml@gmail.com> writes:\n>>\n>> Alex> Strange. You seem to have the old, generated Makefile you perl/\n>> Alex> directory. Haven't your pull failed? If so, I suspect that\n>>\n>> Alex>  rm perl/Makefile\n>> Alex>  git reset --hard\n>> Alex>  git pull git...\n>>\n>> I ended up having to do another reset afterward.\n>>\n>> Definitely something went weird when Makefile was removed\n>> from .gitignore.\n>\n> Yes, perl/Makefile is getting overwritten by what Makefile.PL\n> generates.  I thought the point of Alex's patch was to have it\n> muck with perl.mak and leave the tracked Makefile alone?\n\nNow, I am CLUELESS about what MakeMaker does, but would this\nhelp?\n\n--- \ndiff --git a/perl/Makefile b/perl/Makefile\nindex bd483b0..099beda 100644\n--- a/perl/Makefile\n+++ b/perl/Makefile\n@@ -29,7 +29,7 @@ $(makfile): ../GIT-CFLAGS Makefile\n \techo '\techo $(instdir_SQ)' >> $@\n else\n $(makfile): Makefile.PL ../GIT-CFLAGS\n-\t'$(PERL_PATH_SQ)' $< FIRST_MAKEFILE='$@' PREFIX='$(prefix_SQ)'\n+\t'$(PERL_PATH_SQ)' $< PREFIX='$(prefix_SQ)'\n endif\n \n # this is just added comfort for calling make directly in perl dir\ndiff --git a/perl/Makefile.PL b/perl/Makefile.PL\nindex de73235..4168775 100644\n--- a/perl/Makefile.PL\n+++ b/perl/Makefile.PL\n@@ -24,5 +24,6 @@ WriteMakefile(\n \tNAME            => 'Git',\n \tVERSION_FROM    => 'Git.pm',\n \tPM\t\t=> \\%pm,\n+\tMAKEFILE\t=> 'perl.mak',\n \t%extra\n );\n"},{"id":"297587","messageId":"760708.55141.qm@web31801.mail.mud.yahoo.com","threadId":"43740","inReplyTo":"7vvekmgljm.fsf@assigned-by-dhcp.cox.net","subject":"Re: Problem compiling: that perl thing again","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-12-08T21:26:30Z","receivedAt":"2006-12-08T21:26:30Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano <junkio@cox.net> wrote:\n> Luben Tuikov <ltuikov@yahoo.com> writes:\n> \n> > Over the last 2 months each time I pull, check out next and compile,\n> > I'm seeing _some_ kind of problem with compiling the perl section\n> > of git.  Sometimes git-reset --hard, or a fresh checkout, or git-clean\n> > resolve the situation.  But not this time.\n> > ...\n> > So, where is \"perl.mak\"?\n> \n> This particular breakage cannot be \"last two months\", but there\n> was a recent breakage by commit f848718a last week on the 'master'\n> branch.\n\nNot this particular one, but others in that area (perl make).\n\n> Now, I am CLUELESS about what MakeMaker does, but would this\n> help?\n> \n> --- \n> diff --git a/perl/Makefile b/perl/Makefile\n> index bd483b0..099beda 100644\n> --- a/perl/Makefile\n> +++ b/perl/Makefile\n> @@ -29,7 +29,7 @@ $(makfile): ../GIT-CFLAGS Makefile\n>  \techo '\techo $(instdir_SQ)' >> $@\n>  else\n>  $(makfile): Makefile.PL ../GIT-CFLAGS\n> -\t'$(PERL_PATH_SQ)' $< FIRST_MAKEFILE='$@' PREFIX='$(prefix_SQ)'\n> +\t'$(PERL_PATH_SQ)' $< PREFIX='$(prefix_SQ)'\n>  endif\n>  \n>  # this is just added comfort for calling make directly in perl dir\n> diff --git a/perl/Makefile.PL b/perl/Makefile.PL\n> index de73235..4168775 100644\n> --- a/perl/Makefile.PL\n> +++ b/perl/Makefile.PL\n> @@ -24,5 +24,6 @@ WriteMakefile(\n>  \tNAME            => 'Git',\n>  \tVERSION_FROM    => 'Git.pm',\n>  \tPM\t\t=> \\%pm,\n> +\tMAKEFILE\t=> 'perl.mak',\n>  \t%extra\n>  );\n\nYes, this helps.  Please commit.\n\nThanks,\n    Luben\n"}]}