{"thread":{"id":"43708","subject":"[PATCH] gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url","startedAt":"2006-12-04T13:09:43Z","lastAt":"2006-12-04T13:09:43Z","messageCount":1,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"297065","messageId":"200612041409.43543.jnareb@gmail.com","threadId":"43708","inReplyTo":null,"subject":"[PATCH] gitweb: Fix Atom feed <logo>: it is $logo, not $logo_url","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-12-04T13:09:43Z","receivedAt":"2006-12-04T13:09:43Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Fix contents of Atom feed <logo> element; it should be URL\nof $logo, not URL pointed by logo link.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nDo anyone use Atom feed logo? This error was from the beginning of Atom\nfeed generation in git.git version of gitweb, and nobody complained.\n\nI wonder why it is <logo>URL</logo>, and not <logo href=\"URL\" />...\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 093bd72..ffe8ce1 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4282,7 +4282,7 @@ XML\n \t\t}\n \t\tif (defined $logo_url) {\n \t\t\t# not twice as wide as tall: 72 x 27 pixels\n-\t\t\tprint \"<logo>\" . esc_url($logo_url) . \"</logo>\\n\";\n+\t\t\tprint \"<logo>\" . esc_url($logo) . \"</logo>\\n\";\n \t\t}\n \t\tif (! %latest_date) {\n \t\t\t# dummy date to keep the feed valid until commits trickle in:\n-- \n1.4.4.1\n"}]}