{"thread":{"id":"43706","subject":"[PATCH] gitweb: Slight visual improvements to commitdiff view","startedAt":"2006-10-26T16:13:11Z","lastAt":"2006-10-26T16:13:11Z","messageCount":1,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"297039","messageId":"200610261813.12567.jnareb@gmail.com","threadId":"43706","inReplyTo":null,"subject":"[PATCH] gitweb: Slight visual improvements to commitdiff view","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-26T16:13:11Z","receivedAt":"2006-10-26T16:13:11Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.css  |   14 +++++++++++++-\n gitweb/gitweb.perl |   15 +++++++++------\n 2 files changed, 22 insertions(+), 7 deletions(-)\n\ndiff --git a/gitweb/gitweb.css b/gitweb/gitweb.css\nindex 0eda982..cb2c627 100644\n--- a/gitweb/gitweb.css\n+++ b/gitweb/gitweb.css\n@@ -114,7 +114,7 @@ div.log_link {\n \twidth: 136px;\n }\n \n-div.list_head {\n+div.diff_tree_head {\n \tpadding: 6px 8px 4px;\n \tborder: solid #d9d8d1;\n \tborder-width: 1px 0px 0px;\n@@ -128,6 +128,18 @@ div.author_date {\n \tfont-style: italic;\n }\n \n+div.commitdiff_log {\n+\tpadding: 8px;\n+\tborder: solid #d9d8d1;\n+\tborder-width: 0px 0px 1px 0px;\n+}\n+\n+div.patchset {\n+\tpadding-top: 8px;\n+\tborder: solid #d9d8d1;\n+\tborder-width: 1px 0px 0px 0px;\n+}\n+\n a.list {\n \ttext-decoration: none;\n \tcolor: #000000;\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 0d2ea72..a33cae1 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1844,11 +1844,11 @@ sub git_print_tree_entry {\n sub git_difftree_body {\n \tmy ($difftree, $hash, $parent) = @_;\n \n-\tprint \"<div class=\\\"list_head\\\">\\n\";\n \tif ($#{$difftree} > 10) {\n+\t\tprint \"<div class=\\\"list_head\\\">\\n\";\n \t\tprint(($#{$difftree} + 1) . \" files changed:\\n\");\n+\t\tprint \"</div>\\n\";\n \t}\n-\tprint \"</div>\\n\";\n \n \tprint \"<table class=\\\"diff_tree\\\">\\n\";\n \tmy $alternate = 1;\n@@ -2055,7 +2055,8 @@ sub git_patchset_body {\n \n \t\t\t# for now, no extended header, hence we skip empty patches\n \t\t\t# companion to\tnext LINE if $in_header;\n-\t\t\tif ($diffinfo->{'from_id'} eq $diffinfo->{'to_id'}) { # no change\n+\t\t\tif ($diffinfo->{'from_id'} eq $diffinfo->{'to_id'}) {\n+\t\t\t\t# no change, empty patch\n \t\t\t\t$in_header = 1;\n \t\t\t\tnext LINE;\n \t\t\t}\n@@ -3486,13 +3487,15 @@ sub git_commitdiff {\n \t\tgit_print_page_nav('commitdiff','', $hash,$co{'tree'},$hash, \n$formats_nav);\n \t\tgit_print_header_div('commit', esc_html($co{'title'}) . $ref, $hash);\n \t\tgit_print_authorship(\\%co);\n-\t\tprint \"<div class=\\\"page_body\\\">\\n\";\n+\n \t\tif (@{$co{'comment'}} > 1) {\n-\t\t\tprint \"<div class=\\\"log\\\">\\n\";\n+\t\t\tprint \"<div class=\\\"commitdiff_log\\\">\\n\";\n \t\t\tgit_print_log($co{'comment'}, -final_empty_line=> 1, -remove_title \n=> 1);\n-\t\t\tprint \"</div>\\n\"; # class=\"log\"\n+\t\t\tprint \"</div>\\n\"; # class=\"commitdiff_log\"\n \t\t}\n \n+\t\tprint \"<div class=\\\"page_body\\\">\\n\";\n+\n \t} elsif ($format eq 'plain') {\n \t\tmy $refs = git_get_references(\"tags\");\n \t\tmy $tagname = git_get_rev_name_tags($hash);\n-- \n1.4.3.3\n"}]}