{"thread":{"id":"43652","subject":"stgit: stg mail","startedAt":"2006-12-12T12:12:36Z","lastAt":"2006-12-12T12:32:15Z","messageCount":2,"participants":["Bahadir Balban","Catalin Marinas"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"296325","messageId":"7ac1e90c0612120412i1297ce05uecbeea1107b8c704@mail.gmail.com","threadId":"43652","inReplyTo":null,"subject":"stgit: stg mail","fromName":"Bahadir Balban","fromEmail":"bahadir.balban@gmail.com","sentAt":"2006-12-12T12:12:36Z","receivedAt":"2006-12-12T12:12:36Z","isPatch":false,"sender":{"key":"bahadir.balban@gmail.com","avatar":null},"body":"Hi,\n\nI couldn't succeed in getting stg mail produce an mbox file with a\nSigned-off-by line (using stgit 0.11).\n\nstg mail -m --to=user@mail.com patchname > patchname.diff\n\nworks OK. If I add the template with Signed-off-by I get:\n\nstg mail -m --to=user@mail.com -t ~/patch.tmpl patchname > patchname.diff\nstg mail: No \"From\" address\n\nAlso tried -c with same result.\n\nConfig file:\n[stgit]\n# Default author/committer details\nauthname: name surname\nauthemail: user@mail.com\ncommname:  user@mail.com\ncommemail: user@mail.com\n\nI guess it expects to find everything in the template? How do you\nnormally supply signoff field?\n\nThanks,\n"},{"id":"297149","messageId":"tnxejr5wb00.fsf@arm.com","threadId":"43652","inReplyTo":"7ac1e90c0612120412i1297ce05uecbeea1107b8c704@mail.gmail.com","subject":"Re: stgit: stg mail","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@arm.com","sentAt":"2006-12-12T12:32:15Z","receivedAt":"2006-12-12T12:32:15Z","isPatch":false,"sender":{"key":"catalin.marinas@arm.com","avatar":null},"body":"\"Bahadir Balban\" <bahadir.balban@gmail.com> wrote:\n> I couldn't succeed in getting stg mail produce an mbox file with a\n> Signed-off-by line (using stgit 0.11).\n>\n> stg mail -m --to=user@mail.com patchname > patchname.diff\n>\n> works OK. If I add the template with Signed-off-by I get:\n>\n> stg mail -m --to=user@mail.com -t ~/patch.tmpl patchname > patchname.diff\n> stg mail: No \"From\" address\n\nYour template is wrong since it doesn't have a \"From:\" line. You would\nhave to use the templates/patchmail.tmpl as a starting point.\n\nBTW, I prefer to add the \"signed-off-by\" line in the patch description\nrather than automatically (blindly) append it to every e-mailed patch.\n\n-- \n"}]}