{"thread":{"id":"43651","subject":"Re: [PATCH] Move Fink and Ports check to after config file","startedAt":"2006-12-12T17:01:47Z","lastAt":"2006-12-13T01:35:30Z","messageCount":3,"participants":["Brian Gernhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"297138","messageId":"AF891711-02C9-414F-98CC-BC53DD24EDB3@silverinsanity.com","threadId":"43651","inReplyTo":null,"subject":"[PATCH] Move Fink and Ports check to after config file","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2006-12-12T17:01:47Z","receivedAt":"2006-12-12T17:01:47Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"Putting NO_FINK or NO_DARWIN_PORTS in config.mak is ignored because the\nchecks are done before the config is included.\n\nSigned-off-by: Brian Gernhardt <benji@silverinsanity.com>\n---\n  Makefile |   27 +++++++++++++++------------\n  1 files changed, 15 insertions(+), 12 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex a1861de..c1f1135 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -326,18 +326,6 @@ ifeq ($(uname_S),Darwin)\n  \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n  \tNEEDS_LIBICONV = YesPlease\n  \tNO_STRLCPY = YesPlease\n-\tifndef NO_FINK\n-\t\tifeq ($(shell test -d /sw/lib && echo y),y)\n-\t\t\tBASIC_CFLAGS += -I/sw/include\n-\t\t\tBASIC_LDFLAGS += -L/sw/lib\n-\t\tendif\n-\tendif\n-\tifndef NO_DARWIN_PORTS\n-\t\tifeq ($(shell test -d /opt/local/lib && echo y),y)\n-\t\t\tBASIC_CFLAGS += -I/opt/local/include\n-\t\t\tBASIC_LDFLAGS += -L/opt/local/lib\n-\t\tendif\n-\tendif\n  endif\n  ifeq ($(uname_S),SunOS)\n  \tNEEDS_SOCKET = YesPlease\n@@ -415,6 +403,21 @@ endif\n  -include config.mak.autogen\n  -include config.mak\n\n+ifeq ($(uname_S),Darwin)\n+\tifndef NO_FINK\n+\t\tifeq ($(shell test -d /sw/lib && echo y),y)\n+\t\t\tALL_CFLAGS += -I/sw/include\n+\t\t\tALL_LDFLAGS += -L/sw/lib\n+\t\tendif\n+\tendif\n+\tifndef NO_DARWIN_PORTS\n+\t\tifeq ($(shell test -d /opt/local/lib && echo y),y)\n+\t\t\tALL_CFLAGS += -I/opt/local/include\n+\t\t\tALL_LDFLAGS += -L/opt/local/lib\n+\t\tendif\n+\tendif\n+endif\n+\n  ifndef NO_CURL\n  \tifdef CURLDIR\n  \t\t# This is still problematic -- gcc does not always want -R.\n--\n1.4.4.1.GIT\n\n"},{"id":"297752","messageId":"7vslfkpwcn.fsf@assigned-by-dhcp.cox.net","threadId":"43651","inReplyTo":"AF891711-02C9-414F-98CC-BC53DD24EDB3@silverinsanity.com","subject":"Re: [PATCH] Move Fink and Ports check to after config file","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-12-12T22:45:12Z","receivedAt":"2006-12-12T22:45:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Brian Gernhardt <benji@silverinsanity.com> writes:\n\n> Putting NO_FINK or NO_DARWIN_PORTS in config.mak is ignored because the\n> checks are done before the config is included.\n>\n> Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>\n\nFirst time I saw this today I said \"I'd swear I've seen this\".\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/26493/focus=26503\n\nI guess after I asked for a confirmation from you I simply\nforgot to apply it.  Thanks for a reminder.\n\n\n"},{"id":"296321","messageId":"7A2E97FA-B419-4F0B-8A21-F0B4FC091BDA@silverinsanity.com","threadId":"43651","inReplyTo":"7vslfkpwcn.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] Move Fink and Ports check to after config file","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2006-12-13T01:35:30Z","receivedAt":"2006-12-13T01:35:30Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"\nOn Dec 12, 2006, at 5:45 PM, Junio C Hamano wrote:\n\n> First time I saw this today I said \"I'd swear I've seen this\".\n>\n> I guess after I asked for a confirmation from you I simply\n> forgot to apply it.  Thanks for a reminder.\n\n'salright.  I got so used to \"git rebase origin/master\" that I forgot  \nthat I had brought it up.  Oh, well.  Discussing the perl/Makefile  \nissue reminded me that I had this sitting in my tree.\n\n"}]}