{"thread":{"id":"43630","subject":"[PATCH] Remove COLLISION_CHECK from Makefile since it's not used.","startedAt":"2006-12-20T03:25:13Z","lastAt":"2006-12-20T03:25:13Z","messageCount":1,"participants":["Brian Gernhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"296126","messageId":"20061220032513.GA12119@Hermes.local","threadId":"43630","inReplyTo":null,"subject":"[PATCH] Remove COLLISION_CHECK from Makefile since it's not used.","fromName":"Brian Gernhardt","fromEmail":"benji@silverinsanity.com","sentAt":"2006-12-20T03:25:13Z","receivedAt":"2006-12-20T03:25:13Z","isPatch":true,"sender":{"key":"benji@silverinsanity.com","avatar":"https://gravatar.com/avatar/e06c101dbc25c68114d859b4a9ec7cf8a2c52fd2b0270ef0eac0e2e63ff22311?d=mp&s=160"},"body":"It's rather misleading to have configuration options that don't do\nanything.  If someone adds collision checking they might also want to\nrestore this option.\n\nSigned-off-by: Brian Gernhardt <benji@silverinsanity.com>\n---\n\n Subject: Re: Change in git-svn dcommit semantics?\n\n On Dec 19, 2006, at 7:38 PM, Brian Gernhardt wrote:\n\n > On Dec 19, 2006, at 6:57 PM, Johannes Schindelin wrote:\n > \n >>> Mine also has a few variables like \"COLLISION_CHECK=paranoid\" and my own\n >>> prefix.\n >> \n >> Just to wake sleeping tigers: have you done a \"grep COLLISION_CHECK *\"\n >> recently (where recently means any date after May 3rd, 2005)?\n > \n > Oh, well, that's cute.  It's a configuration option that doesn't touch any\n > code at all...  \n\n Makefile     |    4 ----\n configure.ac |    4 ----\n 2 files changed, 0 insertions(+), 8 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 8919dab..7651104 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -82,10 +82,6 @@ all:\n # Define NO_ACCURATE_DIFF if your diff program at least sometimes misses\n # a missing newline at the end of the file.\n #\n-# Define COLLISION_CHECK below if you believe that SHA1's\n-# 1461501637330902918203684832716283019655932542976 hashes do not give you\n-# sufficient guarantee that no collisions between objects will ever happen.\n-#\n # Define USE_NSEC below if you want git to care about sub-second file mtimes\n # and ctimes. Note that you need recent glibc (at least 2.2.4) for this, and\n # it will BREAK YOUR LOCAL DIFFS! show-diff and anything using it will likely\ndiff --git a/configure.ac b/configure.ac\nindex 34e3478..e153d53 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -316,10 +316,6 @@ GIT_PARSE_WITH(iconv))\n \n ## --enable-FEATURE[=ARG] and --disable-FEATURE\n #\n-# Define COLLISION_CHECK below if you believe that SHA1's\n-# 1461501637330902918203684832716283019655932542976 hashes do not give you\n-# sufficient guarantee that no collisions between objects will ever happen.\n-#\n # Define USE_NSEC below if you want git to care about sub-second file mtimes\n # and ctimes. Note that you need recent glibc (at least 2.2.4) for this, and\n # it will BREAK YOUR LOCAL DIFFS! show-diff and anything using it will likely\n-- \n1.4.4.1.GIT\n"}]}