{"thread":{"id":"43604","subject":"Re: [PATCH 1/3] git-fetch: ignore dereferenced tags in expand_refs_wildcard","startedAt":"2006-12-04T19:34:34Z","lastAt":"2006-12-05T01:08:28Z","messageCount":2,"participants":["Junio C Hamano","Michael Loeffler"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"298021","messageId":"1165260874.20055.4.camel@ibook.zvpunry.de","threadId":"43604","inReplyTo":null,"subject":"[PATCH 1/3] git-fetch: ignore dereferenced tags in expand_refs_wildcard","fromName":"Michael Loeffler","fromEmail":"zvpunry@zvpunry.de","sentAt":"2006-12-04T19:34:34Z","receivedAt":"2006-12-04T19:34:34Z","isPatch":true,"sender":{"key":"zvpunry@zvpunry.de","avatar":null},"body":"There was a little bug in the brace expansion which should remove\nthe ^{} from the tagname. It used ${name#'^{}'} instead of $(name%'^{}'},\nthe difference is that '#' will remove the given pattern only from the\nbeginning of a string and '%' only from the end of a string.\n\nSigned-off-by: Michael Loeffler <zvpunry@zvpunry.de>\n---\n git-parse-remote.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-parse-remote.sh b/git-parse-remote.sh\nindex 19bc385..da064a5 100755\n--- a/git-parse-remote.sh\n+++ b/git-parse-remote.sh\n@@ -116,7 +116,7 @@ expand_refs_wildcard () {\n \t\t\twhile read sha1 name\n \t\t\tdo\n \t\t\t\tmapped=${name#\"$from\"}\n-\t\t\t\tif test \"z$name\" != \"z${name#'^{}'}\" ||\n+\t\t\t\tif test \"z$name\" != \"z${name%'^{}'}\" ||\n \t\t\t\t\ttest \"z$name\" = \"z$mapped\"\n \t\t\t\tthen\n \t\t\t\t\tcontinue\n-- \n1.4.4\n\n\n"},{"id":"295849","messageId":"7vwt57kv3n.fsf@assigned-by-dhcp.cox.net","threadId":"43604","inReplyTo":"1165260874.20055.4.camel@ibook.zvpunry.de","subject":"Re: [PATCH 1/3] git-fetch: ignore dereferenced tags in expand_refs_wildcard","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-12-05T01:08:28Z","receivedAt":"2006-12-05T01:08:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael Loeffler <zvpunry@zvpunry.de> writes:\n\n> There was a little bug in the brace expansion which should remove\n> the ^{} from the tagname. It used ${name#'^{}'} instead of $(name%'^{}'},\n> the difference is that '#' will remove the given pattern only from the\n> beginning of a string and '%' only from the end of a string.\n\nThanks.  Shows that I do not use post 80's shell features ;-).\n"}]}