{"thread":{"id":"4358","subject":"t9001 fails because Net::SMTP is missing","startedAt":"2006-05-30T19:26:55Z","lastAt":"2006-05-31T08:32:45Z","messageCount":6,"participants":["Johannes Schindelin","Junio C Hamano","Morten Welinder","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"20984","messageId":"Pine.LNX.4.63.0605302125310.11586@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4358","inReplyTo":null,"subject":"t9001 fails because Net::SMTP is missing","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-05-30T19:26:55Z","receivedAt":"2006-05-30T19:26:55Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nis it unexpected that there are setups which come without Net::SMTP?\n\n-- snip --\n* expecting success: git format-patch -n HEAD^1\n     git send-email -from=\"Example <nobody@example.com>\" \n--to=nobody@example.com --smtp-server=\"$(pwd)/fake.sendmail\" ./0001*txt\n0001-Second.txt\nCan't locate Net/SMTP.pm in @INC (@INC contains: \n/System/Library/Perl/darwin /System/Library/Perl /Library/Perl/darwin \n/Library/Perl /Library/Perl /Network/Library/Perl/darwin \n/Network/Library/Perl /Network/Library/Perl .) at \n/Users/gene099/my/git-current/t/../git-send-email line 24.\nBEGIN failed--compilation aborted at \n/Users/gene099/my/git-current/t/../git-send-email line 24.\n* FAIL 3: Extract patches and send\n-- snap --\n\nCiao,\nDscho\n"},{"id":"20991","messageId":"7v8xojyqu3.fsf@assigned-by-dhcp.cox.net","threadId":"4358","inReplyTo":"Pine.LNX.4.63.0605302125310.11586@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: t9001 fails because Net::SMTP is missing","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-31T00:34:44Z","receivedAt":"2006-05-31T00:34:44Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> is it unexpected that there are setups which come without Net::SMTP?\n>\n> -- snip --\n> * expecting success: git format-patch -n HEAD^1\n>      git send-email -from=\"Example <nobody@example.com>\" \n> --to=nobody@example.com --smtp-server=\"$(pwd)/fake.sendmail\" ./0001*txt\n> 0001-Second.txt\n> Can't locate Net/SMTP.pm in @INC (@INC contains: \n\nHmm.  Something like this?\n\n-- >8 --\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 0e368ff..f7af8eb 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -21,7 +21,6 @@ use warnings;\n use Term::ReadLine;\n use Getopt::Long;\n use Data::Dumper;\n-use Net::SMTP;\n \n # most mail servers generate the Date: header, but not all...\n $ENV{LC_ALL} = 'C';\n@@ -394,6 +393,7 @@ X-Mailer: git-send-email $gitversion\n \t\tprint $sm \"$header\\n$message\";\n \t\tclose $sm or die $?;\n \t} else {\n+\t\tuse Net::SMTP;\n \t\t$smtp ||= Net::SMTP->new( $smtp_server );\n \t\t$smtp->mail( $from ) or die $smtp->message;\n \t\t$smtp->to( @recipients ) or die $smtp->message;\n"},{"id":"20992","messageId":"7v4pz7yqpd.fsf@assigned-by-dhcp.cox.net","threadId":"4358","inReplyTo":"7v8xojyqu3.fsf@assigned-by-dhcp.cox.net","subject":"Re: t9001 fails because Net::SMTP is missing","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-31T00:37:34Z","receivedAt":"2006-05-31T00:37:34Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <junkio@cox.net> writes:\n\n> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n>\n>> is it unexpected that there are setups which come without Net::SMTP?\n>>\n>> -- snip --\n>> * expecting success: git format-patch -n HEAD^1\n>>      git send-email -from=\"Example <nobody@example.com>\" \n>> --to=nobody@example.com --smtp-server=\"$(pwd)/fake.sendmail\" ./0001*txt\n>> 0001-Second.txt\n>> Can't locate Net/SMTP.pm in @INC (@INC contains: \n>\n> Hmm.  Something like this?\n\nNah, nevermind.  I forgot my Perl that use has the magic BEGIN{}\nblock around it X-<.\n"},{"id":"20994","messageId":"118833cc0605301907i152fc0b0s6788a11ad05e7f10@mail.gmail.com","threadId":"4358","inReplyTo":"7v4pz7yqpd.fsf@assigned-by-dhcp.cox.net","subject":"Re: t9001 fails because Net::SMTP is missing","fromName":"Morten Welinder","fromEmail":"mwelinder@gmail.com","sentAt":"2006-05-31T02:07:29Z","receivedAt":"2006-05-31T02:07:29Z","isPatch":false,"sender":{"key":"mwelinder@gmail.com","avatar":null},"body":"You just need more perl magic...  Try this.\n\n#!/usr/local/perl -w\n\neval 'use strict';\nprint \"Hmm [$@]\\n\";\n\neval 'use Oink';\nprint \"Hmm [$@]\\n\";\n"},{"id":"20999","messageId":"20060531060530.GA9333@hand.yhbt.net","threadId":"4358","inReplyTo":"7v4pz7yqpd.fsf@assigned-by-dhcp.cox.net","subject":"Re: t9001 fails because Net::SMTP is missing","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-05-31T06:05:30Z","receivedAt":"2006-05-31T06:05:30Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano <junkio@cox.net> wrote:\n> Junio C Hamano <junkio@cox.net> writes:\n> \n> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n> >\n> >> is it unexpected that there are setups which come without Net::SMTP?\n> >>\n> >> -- snip --\n> >> * expecting success: git format-patch -n HEAD^1\n> >>      git send-email -from=\"Example <nobody@example.com>\" \n> >> --to=nobody@example.com --smtp-server=\"$(pwd)/fake.sendmail\" ./0001*txt\n> >> 0001-Second.txt\n> >> Can't locate Net/SMTP.pm in @INC (@INC contains: \n> >\n> > Hmm.  Something like this?\n> \n> Nah, nevermind.  I forgot my Perl that use has the magic BEGIN{}\n> block around it X-<.\n\ns/use/require/ and you should be fine.  We don't need any thing imported\nfrom Net::SMTP, either.\n\nOdd that Net::SMTP isn't installed on Johannes' machine, though, as it's\npart of the standard Perl 5.8 (maybe even before) installation.\n\n-- \nEric Wong\n"},{"id":"21001","messageId":"Pine.LNX.4.63.0605311031090.14859@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"4358","inReplyTo":"20060531060530.GA9333@hand.yhbt.net","subject":"Re: t9001 fails because Net::SMTP is missing","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-05-31T08:32:45Z","receivedAt":"2006-05-31T08:32:45Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 30 May 2006, Eric Wong wrote:\n\n> Odd that Net::SMTP isn't installed on Johannes' machine, though, as it's\n> part of the standard Perl 5.8 (maybe even before) installation.\n\nIn terms of corporate setups, 5.8 really is pretty new, you know?\n\nAs for \"s/use/require/\", I can not access on that machine today, but I \nwill test it.\n\nCiao,\nDscho\n"}]}