{"thread":{"id":"4350","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","startedAt":"2006-05-30T05:57:44Z","lastAt":"2006-05-30T17:32:31Z","messageCount":10,"participants":["Junio C Hamano","Ryan Anderson","Alex Riesen","Christopher Faylor"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"20957","messageId":"7v8xok3vhj.fsf@assigned-by-dhcp.cox.net","threadId":"4350","inReplyTo":"11489310153617-git-send-email-1","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-30T05:57:44Z","receivedAt":"2006-05-30T05:57:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ryan Anderson <rda@google.com> writes:\n\n> Signed-off-by: Ryan Anderson <rda@google.com>\n>\n> ---\n>\n> 64ea8c0210c2e9d1711a870460eca326778a4ffc\n>  t/t9001-send-email.sh |   34 ++++++++++++++++++++++++++++++++++\n>  1 files changed, 34 insertions(+), 0 deletions(-)\n>  create mode 100755 t/t9001-send-email.sh\n\nAdds test, alright, but I do not see the fix.  Is this a thinko?\n"},{"id":"20960","messageId":"7v1wuc3t9y.fsf@assigned-by-dhcp.cox.net","threadId":"4350","inReplyTo":"7v8xok3vhj.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-30T06:45:29Z","receivedAt":"2006-05-30T06:45:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <junkio@cox.net> writes:\n\n>> 64ea8c0210c2e9d1711a870460eca326778a4ffc\n>>  t/t9001-send-email.sh |   34 ++++++++++++++++++++++++++++++++++\n>>  1 files changed, 34 insertions(+), 0 deletions(-)\n>>  create mode 100755 t/t9001-send-email.sh\n>\n> Adds test, alright, but I do not see the fix.  Is this a thinko?\n\nOn top of yours, I think this covers the CC: trouble your test\ntriggers.\n\n-- >8 -\nsend-email: fix cc address fed to underlying sendmail\n\n---\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex d418d6c..d61ef8e 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -448,9 +448,11 @@ foreach my $t (@files) {\n \t\t\t\t\telse {\n \t\t\t\t\t\t$author_not_sender = $2;\n \t\t\t\t\t}\n-\t\t\t\t\tprintf(\"(mbox) Adding cc: %s from line '%s'\\n\",\n-\t\t\t\t\t\t$2, $_) unless $quiet;\n-\t\t\t\t\tpush @cc, $2;\n+\t\t\t\t\tmy $cc = extract_valid_address($2);\n+\t\t\t\t\tprintf(\"(mbox) Adding cc: %s from \".\n+\t\t\t\t\t       \"line '%s'\\n\",\n+\t\t\t\t\t\t$cc, $_) unless $quiet;\n+\t\t\t\t\tpush @cc, $cc;\n \t\t\t\t}\n \n \t\t\t} else {\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 276cbac..a61da1e 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -13,10 +13,14 @@ test_expect_success \\\n \n test_expect_success \\\n     'Setup helper tool' \\\n-    'echo \"#!/bin/sh\" > fake.sendmail\n-     echo \"shift\" >> fake.sendmail\n-     echo \"echo \\\"\\$*\\\" > commandline\" >> fake.sendmail\n-     echo \"cat > msgtxt\" >> fake.sendmail\n+    '(echo \"#!/bin/sh\"\n+      echo shift\n+      echo for a\n+      echo do\n+      echo \"  echo \\\"!\\$a!\\\"\"\n+      echo \"done >commandline\"\n+      echo \"cat > msgtxt\"\n+      ) >fake.sendmail\n      chmod +x ./fake.sendmail\n      git add fake.sendmail\n      GIT_AUTHOR_NAME=\"A\" git commit -a -m \"Second.\"'\n@@ -26,9 +30,12 @@ test_expect_success \\\n     'git format-patch -n HEAD^1\n      git send-email -from=\"Example <nobody@example.com>\" --to=nobody@example.com --smtp-server=\"$(pwd)/fake.sendmail\" ./0001*txt'\n \n+cat >expected <<\\EOF\n+!nobody@example.com!\n+!author@example.com!\n+EOF\n test_expect_success \\\n     'Verify commandline' \\\n-    'cline=$(cat commandline)\n-     [ \"$cline\" == \"nobody@example.com author@example.com\" ]'\n+    'diff commandline expected'\n \n test_done\n"},{"id":"20961","messageId":"7vu0782e33.fsf@assigned-by-dhcp.cox.net","threadId":"4350","inReplyTo":"7v1wuc3t9y.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-30T06:58:56Z","receivedAt":"2006-05-30T06:58:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <junkio@cox.net> writes:\n\n> On top of yours, I think this covers the CC: trouble your test\n> triggers.\n\nSorry, I did not look closely enough.  You are trying to keep\nthe address human friendly as long as possible so that you can\nplace them on the headers, so the previous one was bogus.\n\n*BLUSH*\n\nI think this is lower impact.  On the other hand, it appears\nthat at least whatever pretends to be /usr/lib/sendmail on my\nbox seems to grok 'A <author@example.com>' just fine, so maybe\nthe test was bogus (in which case you should just change the\nexpected command line parameters to include the human name).\n\nI dunno.\n\n-- >8 --\nFrom c95682409346f7acc220ac64f453933d5a59ec3f Mon Sep 17 00:00:00 2001\nFrom: Junio C Hamano <junkio@cox.net>\nDate: Mon, 29 May 2006 23:53:13 -0700\nSubject: [PATCH] send-email: do not pass bogus address to local sendmail binary\n\nThis makes t9001 test happy.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n git-send-email.perl   |    4 +++-\n t/t9001-send-email.sh |   19 +++++++++++++------\n 2 files changed, 16 insertions(+), 7 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex d418d6c..ac84553 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -387,7 +387,9 @@ X-Mailer: git-send-email $gitversion\n \t\tmy $pid = open my $sm, '|-';\n \t\tdefined $pid or die $!;\n \t\tif (!$pid) {\n-\t\t\texec($smtp_server,'-i',@recipients) or die $!;\n+\t\t\texec($smtp_server,'-i',\n+\t\t\t     map { extract_valid_address($_) }\n+\t\t\t     @recipients) or die $!;\n \t\t}\n \t\tprint $sm \"$header\\n$message\";\n \t\tclose $sm or die $?;\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 276cbac..a61da1e 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -13,10 +13,14 @@ test_expect_success \\\n \n test_expect_success \\\n     'Setup helper tool' \\\n-    'echo \"#!/bin/sh\" > fake.sendmail\n-     echo \"shift\" >> fake.sendmail\n-     echo \"echo \\\"\\$*\\\" > commandline\" >> fake.sendmail\n-     echo \"cat > msgtxt\" >> fake.sendmail\n+    '(echo \"#!/bin/sh\"\n+      echo shift\n+      echo for a\n+      echo do\n+      echo \"  echo \\\"!\\$a!\\\"\"\n+      echo \"done >commandline\"\n+      echo \"cat > msgtxt\"\n+      ) >fake.sendmail\n      chmod +x ./fake.sendmail\n      git add fake.sendmail\n      GIT_AUTHOR_NAME=\"A\" git commit -a -m \"Second.\"'\n@@ -26,9 +30,12 @@ test_expect_success \\\n     'git format-patch -n HEAD^1\n      git send-email -from=\"Example <nobody@example.com>\" --to=nobody@example.com --smtp-server=\"$(pwd)/fake.sendmail\" ./0001*txt'\n \n+cat >expected <<\\EOF\n+!nobody@example.com!\n+!author@example.com!\n+EOF\n test_expect_success \\\n     'Verify commandline' \\\n-    'cline=$(cat commandline)\n-     [ \"$cline\" == \"nobody@example.com author@example.com\" ]'\n+    'diff commandline expected'\n \n test_done\n-- \n1.3.3.g5029f\n"},{"id":"20965","messageId":"20060530085125.GB32457@h4x0r5.com","threadId":"4350","inReplyTo":"7v8xok3vhj.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2006-05-30T08:51:26Z","receivedAt":"2006-05-30T08:51:26Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"On Mon, May 29, 2006 at 10:57:44PM -0700, Junio C Hamano wrote:\n> Ryan Anderson <rda@google.com> writes:\n> \n> > Signed-off-by: Ryan Anderson <rda@google.com>\n> >\n> > ---\n> >\n> > 64ea8c0210c2e9d1711a870460eca326778a4ffc\n> >  t/t9001-send-email.sh |   34 ++++++++++++++++++++++++++++++++++\n> >  1 files changed, 34 insertions(+), 0 deletions(-)\n> >  create mode 100755 t/t9001-send-email.sh\n> \n> Adds test, alright, but I do not see the fix.  Is this a thinko?\n\nI apparently screwed this patch up (and I think I lost it, in the\nprocess.)\n\nLet me reconstruct, I fixed the problems in a different way (I reworked\nunique_email_address(@) into  unique_email_address($@), to pass a flag\nstating whether to returned the cleaned email address or not, that\nshould come in a few minutes.)\n"},{"id":"20972","messageId":"81b0412b0605300623h4f915829yb388c8fdc062c009@mail.gmail.com","threadId":"4350","inReplyTo":"7vu0782e33.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-05-30T13:23:30Z","receivedAt":"2006-05-30T13:23:30Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -387,7 +387,9 @@ X-Mailer: git-send-email $gitversion\n>                 my $pid = open my $sm, '|-';\n>                 defined $pid or die $!;\n>                 if (!$pid) {\n> -                       exec($smtp_server,'-i',@recipients) or die $!;\n\nThis construction (perl pipe+fork) will not work on ActiveState Perl\n(it does not even parse the construct).\nLast time the problem arised it was suggested to replace readers\nwith \"qx{command}\". Regretfully there were no writer case back\nthen. I'd suggest using IPC::Open2 for portability. Like this:\n\n  use IPC::Open2;\n  my $fw;\n  my $pid = open2(\">&1\", $fw, \"perl\", \"-w\");\n  print $fw \"exit 0\\n\";\n  close($fw);'\n\nBut I wont. It was never portable in windows, no matter how hard\nI tried. The best result was getting output from \"cat -v\", but \"cat\"\nfroze afterwards anyway, as \"wc\" or \"perl\" did. Besides, it the\ncommand often freezes that poor imitation of xterm windows has.\n\nThere is also 2-argument \"open\" with damn careful quoting,\nif anyone cares (dont think anyone does, for windows).\nHow about disabling the test on cygwin? (patch attached).\n\n\n---\n t/t9001-send-email.sh |    7 +++++++\n 1 files changed, 7 insertions(+), 0 deletions(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex a61da1e..c3a3737 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -25,6 +25,11 @@ test_expect_success \\\n      git add fake.sendmail\n      GIT_AUTHOR_NAME=\"A\" git commit -a -m \"Second.\"'\n \n+if test \"$(uname -o)\" = Cygwin; then\n+    say \"git-send-mail tests disabled on Windows\"\n+    # because of windows being such a crap\n+else\n+\n test_expect_success \\\n     'Extract patches and send' \\\n     'git format-patch -n HEAD^1\n@@ -38,4 +43,6 @@ test_expect_success \\\n     'Verify commandline' \\\n     'diff commandline expected'\n \n+fi\n+\n test_done\n-- \n1.3.3.g7994\n\n"},{"id":"20974","messageId":"20060530152103.GB8931@trixie.casa.cgf.cx","threadId":"4350","inReplyTo":"81b0412b0605300623h4f915829yb388c8fdc062c009@mail.gmail.com","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Christopher Faylor","fromEmail":"me@cgf.cx","sentAt":"2006-05-30T15:21:03Z","receivedAt":"2006-05-30T15:21:03Z","isPatch":true,"sender":{"key":"me@cgf.cx","avatar":null},"body":"On Tue, May 30, 2006 at 03:23:30PM +0200, Alex Riesen wrote:\n>>--- a/git-send-email.perl\n>>+++ b/git-send-email.perl\n>>@@ -387,7 +387,9 @@ X-Mailer: git-send-email $gitversion\n>>                my $pid = open my $sm, '|-';\n>>                defined $pid or die $!;\n>>                if (!$pid) {\n>>-                       exec($smtp_server,'-i',@recipients) or die $!;\n>\n>This construction (perl pipe+fork) will not work on ActiveState Perl\n>(it does not even parse the construct).\n>Last time the problem arised it was suggested to replace readers\n>with \"qx{command}\". Regretfully there were no writer case back\n>then. I'd suggest using IPC::Open2 for portability. Like this:\n>\n> use IPC::Open2;\n> my $fw;\n> my $pid = open2(\">&1\", $fw, \"perl\", \"-w\");\n> print $fw \"exit 0\\n\";\n> close($fw);'\n>\n>But I wont. It was never portable in windows, no matter how hard\n>I tried. The best result was getting output from \"cat -v\", but \"cat\"\n>froze afterwards anyway, as \"wc\" or \"perl\" did. Besides, it the\n>command often freezes that poor imitation of xterm windows has.\n\nI assume that \"the poor imitation of xterm\" is referring to cygwin's\nxterm here.  It's really too bad that you can't get into the mindset of\nreporting problems to the cygwin mailing list when you notice them.\n\nI can't comment on the proposed patch since, AFAIK, using cat, wc, and\n(cygwin's) perl should all work just fine but I don't think it is ever\ncorrect to complain about a platform in released software.\n\ncgf\n\n>---\n> t/t9001-send-email.sh |    7 +++++++\n> 1 files changed, 7 insertions(+), 0 deletions(-)\n>\n>diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\n>index a61da1e..c3a3737 100755\n>--- a/t/t9001-send-email.sh\n>+++ b/t/t9001-send-email.sh\n>@@ -25,6 +25,11 @@ test_expect_success \\\n>      git add fake.sendmail\n>      GIT_AUTHOR_NAME=\"A\" git commit -a -m \"Second.\"'\n> \n>+if test \"$(uname -o)\" = Cygwin; then\n>+    say \"git-send-mail tests disabled on Windows\"\n>+    # because of windows being such a crap\n>+else\n>+\n"},{"id":"20976","messageId":"81b0412b0605300900l7530792dqcea6d812602b9176@mail.gmail.com","threadId":"4350","inReplyTo":"20060530152103.GB8931@trixie.casa.cgf.cx","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-05-30T16:00:20Z","receivedAt":"2006-05-30T16:00:20Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 5/30/06, Christopher Faylor <me@cgf.cx> wrote:\n> >froze afterwards anyway, as \"wc\" or \"perl\" did. Besides, it the\n> >command often freezes that poor imitation of xterm windows has.\n>\n> I assume that \"the poor imitation of xterm\" is referring to cygwin's\n> xterm here.  It's really too bad that you can't get into the mindset of\n> reporting problems to the cygwin mailing list when you notice them.\n\nActually, I was referring to windows console. And no, I don't think you\ncould do something about it.\n\nBut honestly, I don't think it's worth supporting windows in general\nand cygwin in particular. And before anyone (again) asks why am\n_I_ doing it: I'd have to do my job with Perforce otherwise (as if\nwindows wasn't bad enough...)\n\n> I can't comment on the proposed patch since, AFAIK, using cat, wc, and\n> (cygwin's) perl should all work just fine but I don't think it is ever\n> correct to complain about a platform in released software.\n\nIf you actually read the message, you'd probably notice ActiveState Perl.\n\nI have no idea why have you taken my post as an attempt to insult cygwin;\nIF I had that in mind I'd dedicate a whole long post just to that.\n"},{"id":"20978","messageId":"20060530170306.GA10895@trixie.casa.cgf.cx","threadId":"4350","inReplyTo":"81b0412b0605300900l7530792dqcea6d812602b9176@mail.gmail.com","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Christopher Faylor","fromEmail":"me@cgf.cx","sentAt":"2006-05-30T17:03:06Z","receivedAt":"2006-05-30T17:03:06Z","isPatch":true,"sender":{"key":"me@cgf.cx","avatar":null},"body":"On Tue, May 30, 2006 at 06:00:20PM +0200, Alex Riesen wrote:\n>On 5/30/06, Christopher Faylor <me@cgf.cx> wrote:\n>>>froze afterwards anyway, as \"wc\" or \"perl\" did. Besides, it the\n>>>command often freezes that poor imitation of xterm windows has.\n>>\n>>I assume that \"the poor imitation of xterm\" is referring to cygwin's\n>>xterm here.  It's really too bad that you can't get into the mindset of\n>>reporting problems to the cygwin mailing list when you notice them.\n>\n>Actually, I was referring to windows console. And no, I don't think you\n>could do something about it.\n>\n>But honestly, I don't think it's worth supporting windows in general\n>and cygwin in particular. And before anyone (again) asks why am\n>_I_ doing it: I'd have to do my job with Perforce otherwise (as if\n>windows wasn't bad enough...)\n\nI think you've made your opinion on this issue pretty clear.\n\n>>I can't comment on the proposed patch since, AFAIK, using cat, wc, and\n>>(cygwin's) perl should all work just fine but I don't think it is ever\n>>correct to complain about a platform in released software.\n>\n>If you actually read the message, you'd probably notice ActiveState Perl.\n\nI actually did read the message.  Do you really want to employ this type\nof hackneyed usenet technique here?\n\nReferring to the Windows console as \"xterm\" (if that is what you were\nactually doing) means that your bug report and patch were unclear.\n\nYou were also talking about \"cat\" and \"wc\" hanging.  Neither is a\nWindows command.  Since you've previously complained that you had\nto use Cygwin, I think it is safe to assume that you were talking\nabout Cygwin commands.\n\n>I have no idea why have you taken my post as an attempt to insult cygwin;\n\nThere you go.  Kick it up a notch.  I asked you (and have been asking\nyou) to report problems with Cygwin in the Cygwin forums.  I don't think\nthat someone mentioning that software has bugs is an \"insult\".  You\nobviously aren't insulting git by fixing bugs that you find.\n\n>IF I had that in mind I'd dedicate a whole long post just to that.\n\nI could write a really long essay about inappropriate mailing list\nhostility, too.  Neither would be on-topic here, of course.\n\nAnyway, I think that comments should be factual and not contain negative\nopinions about Windows, Solaris, or whatever.\n\ncgf\n"},{"id":"20979","messageId":"20060530170805.GC32457@h4x0r5.com","threadId":"4350","inReplyTo":"81b0412b0605300900l7530792dqcea6d812602b9176@mail.gmail.com","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2006-05-30T17:08:06Z","receivedAt":"2006-05-30T17:08:06Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"On Tue, May 30, 2006 at 06:00:20PM +0200, Alex Riesen wrote:\n> If you actually read the message, you'd probably notice ActiveState Perl.\n> \n> I have no idea why have you taken my post as an attempt to insult cygwin;\n> IF I had that in mind I'd dedicate a whole long post just to that.\n\nFWIW, it was probably this:\n\tif test \"$(uname -o)\"= Cygwin; then\n\n(I only mention becuase I was about to apply this, then I saw that line,\nand now I'm confused, is this a fix for ActiveState, or Cygwin?)\n"},{"id":"20980","messageId":"81b0412b0605301032k1eb7ef4ageafaeb5b7f18e5ba@mail.gmail.com","threadId":"4350","inReplyTo":"20060530170805.GC32457@h4x0r5.com","subject":"Re: [PATCH 4/4] Add a basic test case for git send-email, and fix some real bugs discovered.","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-05-30T17:32:31Z","receivedAt":"2006-05-30T17:32:31Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 5/30/06, Ryan Anderson <ryan@michonline.com> wrote:\n> On Tue, May 30, 2006 at 06:00:20PM +0200, Alex Riesen wrote:\n> > If you actually read the message, you'd probably notice ActiveState Perl.\n> >\n> > I have no idea why have you taken my post as an attempt to insult cygwin;\n> > IF I had that in mind I'd dedicate a whole long post just to that.\n>\n> FWIW, it was probably this:\n>         if test \"$(uname -o)\"= Cygwin; then\n>\n> (I only mention becuase I was about to apply this, then I saw that line,\n> and now I'm confused, is this a fix for ActiveState, or Cygwin?)\n>\n\nRight. My bad. Should be \"$(perl -e 'print $^O')\" = MSWin32. That ($^O)\nis actually how it is checked in git-annotate.perl (open_pipe).\n\nChristopher, my apologies if that was that. I actually am hostile to\nWindows and everything around it, and have my reasons for this.\nStill, it does not justify the way how I did that patch.\n\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex a61da1e..7afc358 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -25,6 +25,11 @@ test_expect_success \\\n      git add fake.sendmail\n      GIT_AUTHOR_NAME=\"A\" git commit -a -m \"Second.\"'\n \n+if test \"$(perl -e 'print $^O')\" = MSWin32; then\n+    say \"git-send-mail tests disabled on ActiveState Perl + Windows\"\n+    # because of windows being such a crap\n+else\n+\n test_expect_success \\\n     'Extract patches and send' \\\n     'git format-patch -n HEAD^1\n@@ -38,4 +43,6 @@ test_expect_success \\\n     'Verify commandline' \\\n     'diff commandline expected'\n \n+fi\n+\n test_done\n\n\n"}]}