{"thread":{"id":"43499","subject":"Re: git-format-patch little gripe","startedAt":"2006-11-03T09:07:20Z","lastAt":"2006-11-25T15:42:54Z","messageCount":6,"participants":["Jeff King","Luben Tuikov","Sean"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"297687","messageId":"376237.14965.qm@web31805.mail.mud.yahoo.com","threadId":"43499","inReplyTo":null,"subject":"git-format-patch little gripe","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-11-03T09:07:20Z","receivedAt":"2006-11-03T09:07:20Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Yep, after more than a year, I simply cannot get used to it...\nhttp://marc.theaimsgroup.com/?l=git&m=113259043217761&w=2\nAnd as I've seen, other people brought that up too.\n\nMy brain simply says:\n`` \"git-format-patch\" is singular and so the SHA-1 specified\n on the command line should generate a _single_ patch.''\n\nYeah, but no.\n\nSo I still make the mistake of:\n# git-rev-list --no-merges --pretty=one-line HEAD -- \n I select a commit\n# git-format-patch -o /tmp/ \n...\n Oh, f@#$! \n# git-format-patch -o /tmp/ ^..\n\nIs there a chance to make \"git-format-patch\" output a single\npatch? of that commit only?\n\n Luben\nP.S. And let \"git-format-patches\" go wild with the ideologies...\nSorry, needed to vent as I made this mistake twice already\ntoday...\n\n\n\n\n\n"},{"id":"295142","messageId":"20061103185026.GA28566@coredump.intra.peff.net","threadId":"43499","inReplyTo":"376237.14965.qm@web31805.mail.mud.yahoo.com","subject":"Re: git-format-patch little gripe","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2006-11-03T18:50:26Z","receivedAt":"2006-11-03T18:50:26Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Nov 03, 2006 at 01:07:20AM -0800, Luben Tuikov wrote:\n\n> So I still make the mistake of:\n> # git-rev-list --no-merges --pretty=one-line HEAD -- \n> I select a commit\n> # git-format-patch -o /tmp/ \n> ...\n> Oh, f@#$! \n> # git-format-patch -o /tmp/ ^..\n\nFor my own workflow, I don't want to have to pick the commit out of\nrev-list (or log) output. I want to find it and hit a button to say \"OK,\nnow mail this patch.\" So I put _all_ of my patches into an mbox, and\nthen browse them with mutt. Sort of a poor man's patch browser, but then\nI'm ready to jump into mailing them immediately.\n\nI use the following script:\n\n#!/bin/sh\nroot=${1:-origin}\ngit-format-patch -s --stdout $root >.mbox\nmutt -f .mbox\nrm -f .mbox\n\nAnd then in mutt, I use this macro to bind 'b' to editing the full\nmessage w/ headers:\n\nmacro index b \":set edit_headers=yes:set edit_headers=no\"\n\nI know that may be useless if you're not using mutt, but I just wanted\nto stimulate some discussion among patch submitters about how they\nactually do it. I'm not sure how configurable tig is, but it shouldn't\nbe too hard to add something like this to it.\n\n"},{"id":"296231","messageId":"20061103203752.26472.qmail@web31810.mail.mud.yahoo.com","threadId":"43499","inReplyTo":"20061103185026.GA28566@coredump.intra.peff.net","subject":"Re: git-format-patch little gripe","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-11-03T20:37:52Z","receivedAt":"2006-11-03T20:37:52Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Jeff King wrote:\n> For my own workflow, I don't want to have to pick the commit out of\n> rev-list (or log) output. I want to find it and hit a button to say \"OK,\n> now mail this patch.\" So I put _all_ of my patches into an mbox, and\n> then browse them with mutt. Sort of a poor man's patch browser, but then\n> I'm ready to jump into mailing them immediately.\n> \n> I use the following script:\n> \n> #!/bin/sh\n> root=${1:-origin}\n> git-format-patch -s --stdout $root >.mbox\n> mutt -f .mbox\n> rm -f .mbox\n> \n> And then in mutt, I use this macro to bind 'b' to editing the full\n> message w/ headers:\n> \n> macro index b \":set edit_headers=yes:set edit_headers=no\"\n> \n> I know that may be useless if you're not using mutt, but I just wanted\n> to stimulate some discussion among patch submitters about how they\n> actually do it. I'm not sure how configurable tig is, but it shouldn't\n> be too hard to add something like this to it.\n\nThat's very cool!\n\n Luben\n"},{"id":"296598","messageId":"BAYC1-PASMTP115161C7958A05B82E52A9AEE00@CEZ.ICE","threadId":"43499","inReplyTo":"20061103185026.GA28566@coredump.intra.peff.net","subject":"Re: git-format-patch little gripe","fromName":"Sean","fromEmail":"seanlkml@sympatico.ca","sentAt":"2006-11-25T15:30:33Z","receivedAt":"2006-11-25T15:30:33Z","isPatch":false,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"On Fri, 3 Nov 2006 13:50:26 -0500\nJeff King wrote:\n\n> For my own workflow, I don't want to have to pick the commit out of\n> rev-list (or log) output. I want to find it and hit a button to say \"OK,\n> now mail this patch.\" So I put _all_ of my patches into an mbox, and\n> then browse them with mutt. Sort of a poor man's patch browser, but then\n> I'm ready to jump into mailing them immediately.\n> \n> I use the following script:\n> \n> #!/bin/sh\n> root=${1:-origin}\n> git-format-patch -s --stdout $root >.mbox\n> mutt -f .mbox\n> rm -f .mbox\n\nIf your mail setup support imap, the patches can be dumped directly into\nit rather than having to go through an mbox. For instance you can have\nsomething like this in your ~/.gitconfig:\n\n[imap]\n Host = imap.server.com\n Folder = \"Drafts\"\n User = uname\n Pass = password\n\nAnd then the above command line becomes:\n\ngit-format-patch -s --stdout $root | git-imap-send\n\nTo move all the patches into your imap drafts folder to be accessed\nby whatever email client you use.\n\nSean\n"},{"id":"295184","messageId":"20061125153949.GA11136@coredump.intra.peff.net","threadId":"43499","inReplyTo":"20061125103033.2ea742d3.seanlkml@sympatico.ca","subject":"Re: git-format-patch little gripe","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2006-11-25T15:39:49Z","receivedAt":"2006-11-25T15:39:49Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Nov 25, 2006 at 10:30:33AM -0500, Sean wrote:\n\n> If your mail setup support imap, the patches can be dumped directly into\n> it rather than having to go through an mbox. For instance you can have\n> something like this in your ~/.gitconfig:\n\nSure, I could. But if you have a client which supports mboxes, it's\nprobably better to use the mbox. With your solution, I send the patch to\nthe imap server, then fire up the mail client and re-download the\npatch, possibly mark it up, and then send it out by smtp. The latency\nincrease can be noticeable, especially for big patches and slow imap\nservers.\n\n> To move all the patches into your imap drafts folder to be accessed\n> by whatever email client you use.\n\nOh come on, Real Men just edit the mbox in vi. :)\n\n"},{"id":"296888","messageId":"BAYC1-PASMTP11C557DF59DF29690CDB77AEE00@CEZ.ICE","threadId":"43499","inReplyTo":"20061125153949.GA11136@coredump.intra.peff.net","subject":"Re: git-format-patch little gripe","fromName":"Sean","fromEmail":"seanlkml@sympatico.ca","sentAt":"2006-11-25T15:42:54Z","receivedAt":"2006-11-25T15:42:54Z","isPatch":false,"sender":{"key":"seanlkml@sympatico.ca","avatar":"https://gravatar.com/avatar/f92923f54fc08c401fc59b71829d4b89e9b8087fbba45ff87c82e6a83aee02ae?d=mp&s=160"},"body":"On Sat, 25 Nov 2006 10:39:49 -0500\nJeff King wrote:\n\n> On Sat, Nov 25, 2006 at 10:30:33AM -0500, Sean wrote:\n> \n> > If your mail setup support imap, the patches can be dumped directly into\n> > it rather than having to go through an mbox. For instance you can have\n> > something like this in your ~/.gitconfig:\n> \n> Sure, I could. But if you have a client which supports mboxes, it's\n> probably better to use the mbox. With your solution, I send the patch to\n> the imap server, then fire up the mail client and re-download the\n> patch, possibly mark it up, and then send it out by smtp. The latency\n> increase can be noticeable, especially for big patches and slow imap\n> servers.\n\nYeah, I didn't mean it as a better replacement for your use, just as\nan option that might suit some people better. It works out well here.\n\n> > To move all the patches into your imap drafts folder to be accessed\n> > by whatever email client you use.\n> \n> Oh come on, Real Men just edit the mbox in vi. :)\n\nDamn.. caught in my skirt again.. ;o)\n\n"}]}