{"thread":{"id":"43390","subject":"[BUG] git shortlog: need a range!","startedAt":"2006-11-28T20:20:02Z","lastAt":"2006-11-29T09:38:31Z","messageCount":3,"participants":["Junio C Hamano","René Scharfe","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"294594","messageId":"7v8xhv2uj1.fsf@assigned-by-dhcp.cox.net","threadId":"43390","inReplyTo":null,"subject":"[BUG] git shortlog: need a range!","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-11-28T20:20:02Z","receivedAt":"2006-11-28T20:20:02Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I just got this:\n\n        $ git shortlog --since=Oct.20 --until=Nov.20 master\n        fatal: Need a range!\n\nWhy isn't this a range?\n"},{"id":"295517","messageId":"456CAEDD.7030203@lsrfire.ath.cx","threadId":"43390","inReplyTo":"7v8xhv2uj1.fsf@assigned-by-dhcp.cox.net","subject":"[PATCH] shortlog: remove range check","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2006-11-28T21:49:17Z","receivedAt":"2006-11-28T21:49:17Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Don't force the user to specify more than one revision parameter,\nthus making git-shortlog behave more like git-log.\n'git-shortlog master' will now produce the expected results; the\nother end of the range simply is the (oldest) root commit.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n\ndiff --git a/builtin-shortlog.c b/builtin-shortlog.c\nindex b5b13de..f1124e2 100644\n--- a/builtin-shortlog.c\n+++ b/builtin-shortlog.c\n@@ -298,9 +298,7 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix)\n \tif (!access(\".mailmap\", R_OK))\n \t\tread_mailmap(\".mailmap\");\n \n-\tif (rev.pending.nr == 1)\n-\t\tdie (\"Need a range!\");\n-\telse if (rev.pending.nr == 0)\n+\tif (rev.pending.nr == 0)\n \t\tread_from_stdin(&list);\n \telse\n"},{"id":"296078","messageId":"Pine.LNX.4.63.0611291034340.30004@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"43390","inReplyTo":"7v8xhv2uj1.fsf@assigned-by-dhcp.cox.net","subject":"Re: [BUG] git shortlog: need a range!","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-11-29T09:38:31Z","receivedAt":"2006-11-29T09:38:31Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 28 Nov 2006, Junio C Hamano wrote:\n\n> I just got this:\n> \n>         $ git shortlog --since=Oct.20 --until=Nov.20 master\n>         fatal: Need a range!\n> \n> Why isn't this a range?\n\nIt really is not. Think about this scenario:\n\nA - B - C\n  \\   /\n    D\n\nwhere both B and D were done after Oct.20, but not A. Then you do not have \na range, i.e. you cannot represent the same in the form X..Y.\n\nHowever, this only shows that my reasoning in shortlog was wrong. It was \nmeant to prevent accidentally traversing the _whole_ history (which does \ntake some time), but maybe even this is something people want to do?\n\nTherefore: Ack on René's patch.\n\nCiao,\nDscho\n"}]}