{"thread":{"id":"43372","subject":"Re: [PATCH] Uninstall rule for top level Makefile","startedAt":"2006-12-11T22:14:09Z","lastAt":"2006-12-12T15:42:08Z","messageCount":5,"participants":["Johannes Schindelin","Andy Parkins"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"296430","messageId":"200612112214.09735.andyparkins@gmail.com","threadId":"43372","inReplyTo":null,"subject":"[PATCH] Uninstall rule for top level Makefile","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2006-12-11T22:14:09Z","receivedAt":"2006-12-11T22:14:09Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"Signed-off-by: Andy Parkins <andyparkins@gmail.com>\n---\n Makefile |   14 ++++++++++++++\n 1 files changed, 14 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex a1861de..51c1747 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -821,6 +821,20 @@ install-doc:\n \t$(MAKE) -C Documentation install\n \n \n+### Uninstallation rules\n+\n+uninstall:\n+\trm -f $(subst %,$(DESTDIR_SQ)$(gitexecdir_SQ)/%,$(ALL_PROGRAMS))\n+\trm -f '$(DESTDIR_SQ)$(bindir_SQ)/git$X'\n+\trm -f '$(DESTDIR_SQ)$(bindir_SQ)/gitk'\n+\t$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' uninstall\n+\t$(MAKE) -C perl uninstall\n+\tif test 'z$(bindir_SQ)' != 'z$(gitexecdir_SQ)'; \\\n+\tthen \\\n+\t\trm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$X'\n+\t\trm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$X'; \\\n+\tfi\n+\t$(foreach p,$(BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p';)\n \n \n ### Maintainer's dist rules\n-- \n1.4.4.1.geeee8\n"},{"id":"296358","messageId":"Pine.LNX.4.63.0612121325000.2807@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"43372","inReplyTo":"200612112214.09735.andyparkins@gmail.com","subject":"Re: [PATCH] Uninstall rule for top level Makefile","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-12-12T12:25:21Z","receivedAt":"2006-12-12T12:25:21Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nsee http://article.gmane.org/gmane.comp.version-control.git/8682 for a \ndiscussion about an uninstall target.\n\nCiao,\nDscho\n\n"},{"id":"296582","messageId":"200612121251.33051.andyparkins@gmail.com","threadId":"43372","inReplyTo":"Pine.LNX.4.63.0612121325000.2807@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Uninstall rule for top level Makefile","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2006-12-12T12:51:31Z","receivedAt":"2006-12-12T12:51:31Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Tuesday 2006 December 12 12:25, Johannes Schindelin wrote:\n\n> see http://article.gmane.org/gmane.comp.version-control.git/8682 for a\n> discussion about an uninstall target.\n\nI read that thread, but don't see its relevance.  Have I missed something?\n\nIn summary:\n\n\"uninstall\" is not useful in lieu of a package manager, but for developer \ntypes (like those on this mailing list) it is useful when you install in the \nwrong place (as I did just before I felt the need for an uninstall recipe).\n\nThe thread you linked to seemed to want the uninstall to not have hard-coded \nfilenames.  That's what I did.\n\nI assume I've missed something in the linked thread - what was it you wanted \nme to pick up from it?\n\n\nAndy\n\n-- \nDr Andy Parkins, M Eng (hons), MIEE\n"},{"id":"294529","messageId":"Pine.LNX.4.63.0612121512060.2807@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"43372","inReplyTo":"200612121251.33051.andyparkins@gmail.com","subject":"Re: [PATCH] Uninstall rule for top level Makefile","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-12-12T14:15:29Z","receivedAt":"2006-12-12T14:15:29Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 12 Dec 2006, Andy Parkins wrote:\n\n> I assume I've missed something in the linked thread - what was it you \n> wanted me to pick up from it?\n\nThe uninstall target _only_ solves the case you mentioned: when you \ninstalled Git in the wrong place. But then it is fragile: if you put the \nnew path into config.mak, or you provided the PREFIX on the command line, \nand possibly do not remember what it was, the uninstall goes wrong.\n\nBut then, I do not care at all about that target being in the Makefile or \nnot. I'll just ignore it, just as almost everybody else.\n\nCiao,\nDscho\n"},{"id":"294875","messageId":"200612121542.09259.andyparkins@gmail.com","threadId":"43372","inReplyTo":"Pine.LNX.4.63.0612121512060.2807@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Uninstall rule for top level Makefile","fromName":"Andy Parkins","fromEmail":"andyparkins@gmail.com","sentAt":"2006-12-12T15:42:08Z","receivedAt":"2006-12-12T15:42:08Z","isPatch":true,"sender":{"key":"andyparkins@gmail.com","avatar":null},"body":"On Tuesday 2006 December 12 14:15, Johannes Schindelin wrote:\n\n> The uninstall target _only_ solves the case you mentioned: when you\n> installed Git in the wrong place. But then it is fragile: if you put the\n> new path into config.mak, or you provided the PREFIX on the command line,\n> and possibly do not remember what it was, the uninstall goes wrong.\n\nAbsolutely.  I agree entirely.  The only reason I raised it was because I had \ncause to need it.  The quickest way I found was just to write the missing \nrecipe.  As I'd written it, I thought I'd share.  As you say, it has no other \nuse than unpicking a stupid \"install\", done by a butterbrain like myself :-)\n\n> But then, I do not care at all about that target being in the Makefile or\n> not. I'll just ignore it, just as almost everybody else.\n\nUntil I needed it; I didn't care that it wasn't there.  Even then \"need\" is \nperhaps too strong a word.  It was handy.  That's it.  If there are strong \nmoral objections to it; it doesn't bother me.\n\n\n\nAndy\n-- \nDr Andy Parkins, M Eng (hons), MIEE\n"}]}