{"thread":{"id":"4329","subject":"[PATCH] git-send-email.perl extract_valid_address issue","startedAt":"2006-05-29T04:00:44Z","lastAt":"2006-05-29T20:00:27Z","messageCount":2,"participants":["Nicolas Troncoso Carrere","Ryan Anderson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"20857","messageId":"200605290000.44463.ntroncos@alumnos.inf.utfsm.cl","threadId":"4329","inReplyTo":null,"subject":"[PATCH] git-send-email.perl extract_valid_address issue","fromName":"Nicolas Troncoso Carrere","fromEmail":"ntroncos@alumnos.inf.utfsm.cl","sentAt":"2006-05-29T04:00:44Z","receivedAt":"2006-05-29T04:00:44Z","isPatch":true,"sender":{"key":"ntroncos@alumnos.inf.utfsm.cl","avatar":null},"body":"\nThe third fallback was returning if the match was done or not instead of\nreturning the actual email address that was matched. This prevented sending\nthe mail to the people included in the CC. This bug only affect those that\ndont have Email::Valid.\n\nI initialized $valid_email as undef so it would mimic the behavior of \nEmail::Verify->address(), which returns undef if no valid address was found.\n\nSigned-off-by: Nicolas <ntroncos@inf.utfsm.cl>\n\n\n---\n\n git-send-email.perl |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\n84853ca89c15de7a24e9eb9fd422654b86c63be9\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 312a4ea..dfff3e6 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -316,7 +316,9 @@ sub extract_valid_address {\n \t} else {\n \t\t# less robust/correct than the monster regexp in Email::Valid,\n \t\t# but still does a 99% job, and one less dependency\n-\t\treturn ($address =~ /([^\\\"<>\\s]+@[^<>\\s]+)/);\n+                my $valid_email=undef;\n+                ($valid_email ) = ($address =~ /([^\\\"<>\\s]+@[^<>\\s]+)/);\n+                return ($valid_email);\n \t}\n }\n-- \nNicolás Troncoso Carrère                        User #272312 counter.li.org\nEstudiante Magíster en Ciencias de la Informática\nUniversidad Técnica Federico Santa María\nhttp://www.alumnos.inf.utfsm.cl/~ntroncos\n"},{"id":"20909","messageId":"20060529200026.GA32457@h4x0r5.com","threadId":"4329","inReplyTo":"200605290000.44463.ntroncos@alumnos.inf.utfsm.cl","subject":"Re: [PATCH] git-send-email.perl extract_valid_address issue","fromName":"Ryan Anderson","fromEmail":"ryan@michonline.com","sentAt":"2006-05-29T20:00:27Z","receivedAt":"2006-05-29T20:00:27Z","isPatch":true,"sender":{"key":"ryan@michonline.com","avatar":null},"body":"On Mon, May 29, 2006 at 12:00:44AM -0400, Nicolas Troncoso Carrere wrote:\n> \n> The third fallback was returning if the match was done or not instead of\n> returning the actual email address that was matched. This prevented sending\n> the mail to the people included in the CC. This bug only affect those that\n> dont have Email::Valid.\n> \n> I initialized $valid_email as undef so it would mimic the behavior of \n> Email::Verify->address(), which returns undef if no valid address was found.\n\nOdd, I noticed the same thing this weekend.\n\n> Signed-off-by: Nicolas <ntroncos@inf.utfsm.cl>\nAcked-by: Ryan Anderson <ryan@michonline.com>\n\n(Or pick up my patch that fixes this in a slightly different way)\n\n> \n> \n> ---\n> \n>  git-send-email.perl |    4 +++-\n>  1 files changed, 3 insertions(+), 1 deletions(-)\n> \n> 84853ca89c15de7a24e9eb9fd422654b86c63be9\n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index 312a4ea..dfff3e6 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -316,7 +316,9 @@ sub extract_valid_address {\n>  \t} else {\n>  \t\t# less robust/correct than the monster regexp in Email::Valid,\n>  \t\t# but still does a 99% job, and one less dependency\n> -\t\treturn ($address =~ /([^\\\"<>\\s]+@[^<>\\s]+)/);\n> +                my $valid_email=undef;\n> +                ($valid_email ) = ($address =~ /([^\\\"<>\\s]+@[^<>\\s]+)/);\n> +                return ($valid_email);\n>  \t}\n>  }\n> -- \n> Nicol?s Troncoso Carr?re                        User #272312 counter.li.org\n> Estudiante Mag?ster en Ciencias de la Inform?tica\n> Universidad T?cnica Federico Santa Mar?a\n> http://www.alumnos.inf.utfsm.cl/~ntroncos\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n> \n"}]}