{"thread":{"id":"43257","subject":"Re: Bug: git-svn fails on Mediawiki SVN repo r2992","startedAt":"2006-12-19T23:53:13Z","lastAt":"2006-12-20T09:37:37Z","messageCount":3,"participants":["Thomas Bleher","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"295192","messageId":"20061219235312.GB12756@thorium2.jmh.mhn.de","threadId":"43257","inReplyTo":null,"subject":"Bug: git-svn fails on Mediawiki SVN repo r2992","fromName":"Thomas Bleher","fromEmail":"bleher@informatik.uni-muenchen.de","sentAt":"2006-12-19T23:53:13Z","receivedAt":"2006-12-19T23:53:13Z","isPatch":false,"sender":{"key":"bleher@informatik.uni-muenchen.de","avatar":null},"body":"There is some problem between git-svn (v1.4.4.1.gad0c3) and MediaWiki\nSVN when cloning their repo.\n\nI just did\n$ git-svn init http://svn.wikimedia.org/svnroot/mediawiki/trunk/phase3\n$ git-svn fetch -r 2991:3122\nand git-svn went into an endless loop, repeatedly downloading and adding\nthe same files from r2992 over and over again.\n\nThe bad revision can be viewed here:\nhttp://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=2992\nIt adds ~1000 files (mostly small images).\nI can check out this revision just fine using the svn command line\nclient.\n\nI found this problem while cloning this repo a while ago, using a\nslightly older version of git (probably 1.4.3, don't remember exactly).\nIn this repo, some directories appeared in the latest revisions which\nwere deleted a long time ago.\n\nYou can temporarily browse this repo here:\nhttp://misc.j-crew.de/cgi-bin/gitweb.cgi?p=mediawiki.git\nHEAD contains the dir Smarty-2.6.2, which was removed in SVN r3122.\nStrangely, my repo misses all commits between r2991 and r3822.\nYou can see the gap at\nhttp://misc.j-crew.de/cgi-bin/gitweb.cgi?p=mediawiki.git;a=shortlog;h=49e761ba51ee0d0a698999451134acbf2e078c03\n\nI didn't notice any strange errors while cloning, but I had to abort and\nrestart git-svn a few times, so maybe there was some error there?\n\nAnyway, I figured I didn't need the _whole_ history, so this is nothing\nurgent, but I thought I should report it.\n\n"},{"id":"296734","messageId":"20061220013634.GA3901@localdomain","threadId":"43257","inReplyTo":"20061219235312.GB12756@thorium2.jmh.mhn.de","subject":"Re: Bug: git-svn fails on Mediawiki SVN repo r2992","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-12-20T01:36:34Z","receivedAt":"2006-12-20T01:36:34Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Thomas Bleher wrote:\n> There is some problem between git-svn (v1.4.4.1.gad0c3) and MediaWiki\n> SVN when cloning their repo.\n> \n> I just did\n> $ git-svn init http://svn.wikimedia.org/svnroot/mediawiki/trunk/phase3\n> $ git-svn fetch -r 2991:3122\n> and git-svn went into an endless loop, repeatedly downloading and adding\n> the same files from r2992 over and over again.\n\nI'm not sure that it was 'endless', just unnecesarily repeating itself.\ncommit 6173c197c9a23fa8594f18fd2c856407d4af31c1 (included in 1.4.4.2)\nshould have fixed your problem...\n\n> The bad revision can be viewed here:\n> http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=2992\n> It adds ~1000 files (mostly small images).\n> I can check out this revision just fine using the svn command line\n> client.\n\nThe latest git-svn in git.git now bundles all the changed files into a\ndelta on the server side; and is significantly faster over most network\nconnections as a result.\n\n> I found this problem while cloning this repo a while ago, using a\n> slightly older version of git (probably 1.4.3, don't remember exactly).\n> In this repo, some directories appeared in the latest revisions which\n> were deleted a long time ago.\n> \n> You can temporarily browse this repo here:\n> http://misc.j-crew.de/cgi-bin/gitweb.cgi?p=mediawiki.git\n> HEAD contains the dir Smarty-2.6.2, which was removed in SVN r3122.\n> Strangely, my repo misses all commits between r2991 and r3822.\n> You can see the gap at\n> http://misc.j-crew.de/cgi-bin/gitweb.cgi?p=mediawiki.git;a=shortlog;h=49e761ba51ee0d0a698999451134acbf2e078c03\n> \n> I didn't notice any strange errors while cloning, but I had to abort and\n> restart git-svn a few times, so maybe there was some error there?\n\nHmm, it looks like you ran something like:\n\n\tgit-svn fetch -r0:2991\n\nand then something along the lines of:\n\n\tgit-svn fetch -r3822:HEAD\n\nIs that what happened?\n\nLooking at the pre-delta git-svn code, it seems that using -r with fetch\nat any time other than the initial fetch will result in botched\nhistory...\n\n-- \n"},{"id":"294153","messageId":"20061220093736.GA5402@thorium2.jmh.mhn.de","threadId":"43257","inReplyTo":"20061220013634.GA3901@localdomain","subject":"Re: Bug: git-svn fails on Mediawiki SVN repo r2992","fromName":"Thomas Bleher","fromEmail":"bleher@informatik.uni-muenchen.de","sentAt":"2006-12-20T09:37:37Z","receivedAt":"2006-12-20T09:37:37Z","isPatch":false,"sender":{"key":"bleher@informatik.uni-muenchen.de","avatar":null},"body":"* Eric Wong [2006-12-20 02:36]:\n> Thomas Bleher wrote:\n> > There is some problem between git-svn (v1.4.4.1.gad0c3) and MediaWiki\n> > SVN when cloning their repo.\n> > \n> > I just did\n> > $ git-svn init http://svn.wikimedia.org/svnroot/mediawiki/trunk/phase3\n> > $ git-svn fetch -r 2991:3122\n> > and git-svn went into an endless loop, repeatedly downloading and adding\n> > the same files from r2992 over and over again.\n> \n> I'm not sure that it was 'endless', just unnecesarily repeating itself.\n> commit 6173c197c9a23fa8594f18fd2c856407d4af31c1 (included in 1.4.4.2)\n> should have fixed your problem...\n\nIt fetched every file at least three times, and I had to kill it after\nthat, it had been running for over an hour already.\nI just retried with current next, and it's _much_ faster, under one\nminute now for this particular revision.\n\nSo consider this problem solved, and thanks a lot!\n\n> > The bad revision can be viewed here:\n> > http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=2992\n> > It adds ~1000 files (mostly small images).\n> > I can check out this revision just fine using the svn command line\n> > client.\n> \n> The latest git-svn in git.git now bundles all the changed files into a\n> delta on the server side; and is significantly faster over most network\n> connections as a result.\n\nYeah, this is a huge gain.\n\n> > I found this problem while cloning this repo a while ago, using a\n> > slightly older version of git (probably 1.4.3, don't remember exactly).\n> > In this repo, some directories appeared in the latest revisions which\n> > were deleted a long time ago.\n> > \n> > You can temporarily browse this repo here:\n> > http://misc.j-crew.de/cgi-bin/gitweb.cgi?p=mediawiki.git\n> > HEAD contains the dir Smarty-2.6.2, which was removed in SVN r3122.\n> > Strangely, my repo misses all commits between r2991 and r3822.\n> > You can see the gap at\n> > http://misc.j-crew.de/cgi-bin/gitweb.cgi?p=mediawiki.git;a=shortlog;h=49e761ba51ee0d0a698999451134acbf2e078c03\n> > \n> > I didn't notice any strange errors while cloning, but I had to abort and\n> > restart git-svn a few times, so maybe there was some error there?\n> \n> Hmm, it looks like you ran something like:\n> \n> \tgit-svn fetch -r0:2991\n> \n> and then something along the lines of:\n> \n> \tgit-svn fetch -r3822:HEAD\n> \n> Is that what happened?\n\nNope. I just ran \"git-svn fetch\" repeatedly, and stopped it a few times\nwith ^C (the import was running for several days, and I had to turn off\nthe computer inbetween). Maybe something broke there?\nAnyway, it's working now, so I think we can consider this problem\nsolved.\n\nThanks,\nThomas\n"}]}