{"thread":{"id":"43193","subject":"[PATCH] make git-push a bit more verbose","startedAt":"2006-10-31T21:58:32Z","lastAt":"2006-11-01T00:08:40Z","messageCount":4,"participants":["Nicolas Pitre","Petr Baudis","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"294011","messageId":"Pine.LNX.4.64.0610311648220.11384@xanadu.home","threadId":"43193","inReplyTo":null,"subject":"[PATCH] make git-push a bit more verbose","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2006-10-31T21:58:32Z","receivedAt":"2006-10-31T21:58:32Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"Currently git-push displays progress status for the local packing of \nobjects to send, but nothing once it starts to push it over the \nconnection.  Having progress status in that later case is especially \nnice when pushing lots of objects over a slow network link.\n\nSigned-off-by: Nicolas Pitre <nico@cam.org>\n\n---\n\ndiff --git a/builtin-pack-objects.c b/builtin-pack-objects.c\nindex 41e1e74..5f56a95 100644\n--- a/builtin-pack-objects.c\n+++ b/builtin-pack-objects.c\n@@ -475,11 +475,12 @@ static void write_pack_file(void)\n \tunsigned long offset;\n \tstruct pack_header hdr;\n \tunsigned last_percent = 999;\n-\tint do_progress = 0;\n+\tint do_progress;\n \n-\tif (!base_name)\n+\tif (!base_name) {\n \t\tf = sha1fd(1, \"<stdout>\");\n-\telse {\n+\t\tdo_progress = progress >> 1;\n+\t} else {\n \t\tf = sha1create(\"%s-%s.%s\", base_name,\n \t\t\t       sha1_to_hex(object_list_sha1), \"pack\");\n \t\tdo_progress = progress;\n@@ -1524,6 +1525,10 @@ int cmd_pack_objects(int argc, const cha\n \t\t\tprogress = 1;\n \t\t\tcontinue;\n \t\t}\n+\t\tif (!strcmp(\"--all-progress\", arg)) {\n+\t\t\tprogress = 2;\n+\t\t\tcontinue;\n+\t\t}\n \t\tif (!strcmp(\"--incremental\", arg)) {\n \t\t\tincremental = 1;\n \t\t\tcontinue;\n@@ -1641,7 +1646,7 @@ int cmd_pack_objects(int argc, const cha\n \telse {\n \t\tif (nr_result)\n \t\t\tprepare_pack(window, depth);\n-\t\tif (progress && pack_to_stdout) {\n+\t\tif (progress == 1 && pack_to_stdout) {\n \t\t\t/* the other end usually displays progress itself */\n \t\t\tstruct itimerval v = {{0,},};\n \t\t\tsetitimer(ITIMER_REAL, &v, NULL);\ndiff --git a/send-pack.c b/send-pack.c\nindex fbd792c..4476666 100644\n--- a/send-pack.c\n+++ b/send-pack.c\n@@ -29,6 +29,7 @@ static void exec_pack_objects(void)\n {\n \tstatic const char *args[] = {\n \t\t\"pack-objects\",\n+\t\t\"--all-progress\",\n \t\t\"--stdout\",\n \t\tNULL\n"},{"id":"298350","messageId":"ei8hpd$inu$1@sea.gmane.org","threadId":"43193","inReplyTo":"Pine.LNX.4.64.0610311648220.11384@xanadu.home","subject":"Re: [PATCH] make git-push a bit more verbose","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-31T22:13:15Z","receivedAt":"2006-10-31T22:13:15Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Nicolas Pitre wrote:\n\n> Currently git-push displays progress status for the local packing of \n> objects to send, but nothing once it starts to push it over the \n> connection.  Having progress status in that later case is especially \n> nice when pushing lots of objects over a slow network link.\n\nThanks a lot!\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n\n"},{"id":"298643","messageId":"7vslh4oxfx.fsf@assigned-by-dhcp.cox.net","threadId":"43193","inReplyTo":"Pine.LNX.4.64.0610311648220.11384@xanadu.home","subject":"Re: [PATCH] make git-push a bit more verbose","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-31T23:52:18Z","receivedAt":"2006-10-31T23:52:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.  Will apply.\n"},{"id":"294567","messageId":"20061101000840.GE20017@pasky.or.cz","threadId":"43193","inReplyTo":"Pine.LNX.4.64.0610311648220.11384@xanadu.home","subject":"Re: [PATCH] make git-push a bit more verbose","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-11-01T00:08:40Z","receivedAt":"2006-11-01T00:08:40Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Tue, Oct 31, 2006 at 10:58:32PM CET, I got a letter\nwhere Nicolas Pitre <nico@cam.org> said that...\n> Currently git-push displays progress status for the local packing of \n> objects to send, but nothing once it starts to push it over the \n> connection.  Having progress status in that later case is especially \n> nice when pushing lots of objects over a slow network link.\n> \n> Signed-off-by: Nicolas Pitre <nico@cam.org>\n\nYet Another Undocumented Feature? :-(\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj\n$/=unpack('H*',$_);$_=`echo 16dio\\U$k\"SK$/SM$n\\EsN0p[lN*1\n"}]}