{"thread":{"id":"43148","subject":"Re: gitk with arguments fails on OSX","startedAt":"2006-11-29T15:04:29Z","lastAt":"2006-11-29T21:16:18Z","messageCount":5,"participants":["Junio C Hamano","Johannes Schindelin","Paul Mackerras","Randal L. Schwartz"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"297334","messageId":"864psixpj6.fsf@blue.stonehenge.com","threadId":"43148","inReplyTo":null,"subject":"gitk with arguments fails on OSX","fromName":"Randal L. Schwartz","fromEmail":"merlyn@stonehenge.com","sentAt":"2006-11-29T15:04:29Z","receivedAt":"2006-11-29T15:04:29Z","isPatch":false,"sender":{"key":"merlyn@stonehenge.com","avatar":"https://gravatar.com/avatar/dc528d210743ff0333e6213f9ee7b33b23f1b7bc1f3c5a8c2d819074ecd7ab19?d=mp&s=160"},"body":"\nUsing the native \"wish\", gitk fails on OSX 10.4 if given any arguments.\nFor example, the failure for \"gitk --all\" is:\n\n    localhost.local:~/MIRROR/git-GIT % gitk --all\n    Error in startup script: unknown option \"-state\"\n        while executing\n    \".bar.view entryconf 3 -state normal\"\n        invoked from within\n    \"if {$cmdline_files ne {} || $revtreeargs ne {}} {\n        # create a view for the files/dirs specified on the command line\n        set curview 1\n        set selec...\"\n        (file \"/opt/git/bin/gitk\" line 6298)\n\nWhat is -state ?  What version of tk does it require?\n\n-- \nRandal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095\n<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>\nPerl/Unix/security consulting, Technical writing, Comedy, etc. etc.\n"},{"id":"293940","messageId":"Pine.LNX.4.63.0611291609370.30004@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"43148","inReplyTo":"864psixpj6.fsf@blue.stonehenge.com","subject":"Re: gitk with arguments fails on OSX","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-11-29T15:10:00Z","receivedAt":"2006-11-29T15:10:00Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Wed, 29 Nov 2006, Randal L. Schwartz wrote:\n\n> \n> Using the native \"wish\", gitk fails on OSX 10.4 if given any arguments.\n> For example, the failure for \"gitk --all\" is:\n> \n>     localhost.local:~/MIRROR/git-GIT % gitk --all\n>     Error in startup script: unknown option \"-state\"\n>         while executing\n\nKnown problem:\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/31266/focus=31266\n\nHth,\nDscho\n"},{"id":"298768","messageId":"86vekyw9ue.fsf@blue.stonehenge.com","threadId":"43148","inReplyTo":"Pine.LNX.4.63.0611291609370.30004@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: gitk with arguments fails on OSX","fromName":"Randal L. Schwartz","fromEmail":"merlyn@stonehenge.com","sentAt":"2006-11-29T15:28:41Z","receivedAt":"2006-11-29T15:28:41Z","isPatch":false,"sender":{"key":"merlyn@stonehenge.com","avatar":"https://gravatar.com/avatar/dc528d210743ff0333e6213f9ee7b33b23f1b7bc1f3c5a8c2d819074ecd7ab19?d=mp&s=160"},"body":">>>>> \"Johannes\" == Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\nJohannes> Hi,\nJohannes> On Wed, 29 Nov 2006, Randal L. Schwartz wrote:\n\n>> \n>> Using the native \"wish\", gitk fails on OSX 10.4 if given any arguments.\n>> For example, the failure for \"gitk --all\" is:\n>> \n>> localhost.local:~/MIRROR/git-GIT % gitk --all\n>> Error in startup script: unknown option \"-state\"\n>> while executing\n\nJohannes> Known problem:\n\nJohannes> http://thread.gmane.org/gmane.comp.version-control.git/31266/focus=31266\n\nThe fix works for me.  How about mainlining it?\n\nFrom: Randal L. Schwartz <merlyn@localhost.local>\nDate: Wed, 29 Nov 2006 07:20:04 -0800\nSubject: [PATCH] patch from mailing list\n\n---\n gitk |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex ab383b3..d9df0a3 100755\n--- a/gitk\n+++ b/gitk\n@@ -1632,8 +1632,8 @@ proc showview {n} {\n \n     set curview $n\n     set selectedview $n\n-    .bar.view entryconf 2 -state [expr {$n == 0? \"disabled\": \"normal\"}]\n-    .bar.view entryconf 3 -state [expr {$n == 0? \"disabled\": \"normal\"}]\n+    .bar.view entryconf \"Edit*\" -state [expr {$n == 0? \"disabled\": \"normal\"}]\n+    .bar.view entryconf \"Delete*\" -state [expr {$n == 0? \"disabled\": \"normal\"}]\n \n     if {![info exists viewdata($n)]} {\n        set pending_select $selid\n@@ -6305,8 +6305,8 @@ if {$cmdline_files ne {} || $revtreeargs ne {}} {\n     set viewargs(1) $revtreeargs\n     set viewperm(1) 0\n     addviewmenu 1\n-    .bar.view entryconf 2 -state normal\n-    .bar.view entryconf 3 -state normal\n+    .bar.view entryconf \"Edit*\" -state normal\n+    .bar.view entryconf \"Delete*\" -state normal\n }\n \n if {[info exists permviews]} {\n-- \n1.4.4.1.gf927\n\n\n\n-- \nRandal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095\n<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>\nPerl/Unix/security consulting, Technical writing, Comedy, etc. etc.\n"},{"id":"293921","messageId":"7vejrmou75.fsf@assigned-by-dhcp.cox.net","threadId":"43148","inReplyTo":"86vekyw9ue.fsf@blue.stonehenge.com","subject":"Re: gitk with arguments fails on OSX","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-11-29T20:48:30Z","receivedAt":"2006-11-29T20:48:30Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"merlyn@stonehenge.com (Randal L. Schwartz) writes:\n\n>>>>>> \"Johannes\" == Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n>\n> Johannes> Hi,\n> Johannes> On Wed, 29 Nov 2006, Randal L. Schwartz wrote:\n>\n>>> \n>>> Using the native \"wish\", gitk fails on OSX 10.4 if given any arguments.\n>>> For example, the failure for \"gitk --all\" is:\n>>> \n>>> localhost.local:~/MIRROR/git-GIT % gitk --all\n>>> Error in startup script: unknown option \"-state\"\n>>> while executing\n>\n> Johannes> Known problem:\n>\n> Johannes> http://thread.gmane.org/gmane.comp.version-control.git/31266/focus=31266\n>\n> The fix works for me.  How about mainlining it?\n\nThe changes look sane to me.\n\nPaul?  I prefer to be fed gitk changes through you, if you don't\nmind.\n\n> From: Randal L. Schwartz <merlyn@localhost.local>\n> Date: Wed, 29 Nov 2006 07:20:04 -0800\n> Subject: [PATCH] patch from mailing list\n>\n> ---\n>  gitk |    8 ++++----\n>  1 files changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/gitk b/gitk\n> index ab383b3..d9df0a3 100755\n> --- a/gitk\n> +++ b/gitk\n> @@ -1632,8 +1632,8 @@ proc showview {n} {\n>  \n>      set curview $n\n>      set selectedview $n\n> -    .bar.view entryconf 2 -state [expr {$n == 0? \"disabled\": \"normal\"}]\n> -    .bar.view entryconf 3 -state [expr {$n == 0? \"disabled\": \"normal\"}]\n> +    .bar.view entryconf \"Edit*\" -state [expr {$n == 0? \"disabled\": \"normal\"}]\n> +    .bar.view entryconf \"Delete*\" -state [expr {$n == 0? \"disabled\": \"normal\"}]\n>  \n>      if {![info exists viewdata($n)]} {\n>         set pending_select $selid\n> @@ -6305,8 +6305,8 @@ if {$cmdline_files ne {} || $revtreeargs ne {}} {\n>      set viewargs(1) $revtreeargs\n>      set viewperm(1) 0\n>      addviewmenu 1\n> -    .bar.view entryconf 2 -state normal\n> -    .bar.view entryconf 3 -state normal\n> +    .bar.view entryconf \"Edit*\" -state normal\n> +    .bar.view entryconf \"Delete*\" -state normal\n>  }\n>  \n>  if {[info exists permviews]} {\n> -- \n> 1.4.4.1.gf927\n>\n>\n>\n> -- \n> Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095\n> <merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>\n> Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.\n> See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!\n"},{"id":"295545","messageId":"17773.63650.734073.958790@cargo.ozlabs.ibm.com","threadId":"43148","inReplyTo":"7vejrmou75.fsf@assigned-by-dhcp.cox.net","subject":"Re: gitk with arguments fails on OSX","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2006-11-29T21:16:18Z","receivedAt":"2006-11-29T21:16:18Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Junio C Hamano writes:\n\n> The changes look sane to me.\n> \n> Paul?  I prefer to be fed gitk changes through you, if you don't\n> mind.\n\nI just pushed a somewhat more comprehensive fix to my gitk.git repo on\nmaster.kernel.org.  (Actually I had checked it in some time ago\nlocally but forgot to do the push, sorry.)\n\nRegards,\n"}]}