{"thread":{"id":"43036","subject":"[PATCH] document git-repack interaction of pack.threads and pack.windowMemory","startedAt":"2016-08-09T11:53:30Z","lastAt":"2016-08-10T18:58:28Z","messageCount":3,"participants":["Michael Stahl","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"293482","messageId":"db25fccf-ed85-3974-143d-2c50b3037642@redhat.com","threadId":"43036","inReplyTo":null,"subject":"[PATCH] document git-repack interaction of pack.threads and pack.windowMemory","fromName":"Michael Stahl","fromEmail":"mstahl@redhat.com","sentAt":"2016-08-09T11:53:21Z","receivedAt":"2016-08-09T11:53:30Z","isPatch":true,"sender":{"key":"mstahl@redhat.com","avatar":null},"body":"Signed-off-by: Michael Stahl <mstahl@redhat.com>\n---\n Documentation/git-pack-objects.txt | 2 +-\n Documentation/git-repack.txt       | 6 +++++-\n 2 files changed, 6 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\nindex 19cdcd0..0b655a5 100644\n--- a/Documentation/git-pack-objects.txt\n+++ b/Documentation/git-pack-objects.txt\n@@ -105,7 +105,7 @@ base-name::\n \tadvantage of the large window for the smaller objects.  The\n \tsize can be suffixed with \"k\", \"m\", or \"g\".\n \t`--window-memory=0` makes memory usage unlimited, which is the\n-\tdefault.\n+\tdefault, unless the config variable `pack.windowMemory` is set.\n \n --max-pack-size=<n>::\n \tMaximum size of each output pack file. The size can be suffixed with\ndiff --git a/Documentation/git-repack.txt b/Documentation/git-repack.txt\nindex c597523..300455b 100644\n--- a/Documentation/git-repack.txt\n+++ b/Documentation/git-repack.txt\n@@ -101,7 +101,11 @@ other objects in that pack they already have locally.\n \tadvantage of the large window for the smaller objects.  The\n \tsize can be suffixed with \"k\", \"m\", or \"g\".\n \t`--window-memory=0` makes memory usage unlimited, which is the\n-\tdefault.\n+\tdefault, unless the config variable `pack.windowMemory` is set.\n+\tNote that the actual memory usage will be multiplied\n+\tby the number of threads used by linkgit:git-pack-objects[1],\n+\twhich is lacking a corresponding git-repack flag but can be\n+\tset via the config variable `pack.threads`.\n \n --max-pack-size=<n>::\n \tMaximum size of each output pack file. The size can be suffixed with\n-- \n2.7.4\n\n"},{"id":"293518","messageId":"xmqqlh05ajbm.fsf@gitster.mtv.corp.google.com","threadId":"43036","inReplyTo":"db25fccf-ed85-3974-143d-2c50b3037642@redhat.com","subject":"Re: [PATCH] document git-repack interaction of pack.threads and pack.windowMemory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-08-09T18:27:57Z","receivedAt":"2016-08-09T18:28:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael Stahl <mstahl@redhat.com> writes:\n\n> Signed-off-by: Michael Stahl <mstahl@redhat.com>\n> ---\n>  Documentation/git-pack-objects.txt | 2 +-\n>  Documentation/git-repack.txt       | 6 +++++-\n>  2 files changed, 6 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\n> index 19cdcd0..0b655a5 100644\n> --- a/Documentation/git-pack-objects.txt\n> +++ b/Documentation/git-pack-objects.txt\n> @@ -105,7 +105,7 @@ base-name::\n>  \tadvantage of the large window for the smaller objects.  The\n>  \tsize can be suffixed with \"k\", \"m\", or \"g\".\n>  \t`--window-memory=0` makes memory usage unlimited, which is the\n> -\tdefault.\n> +\tdefault, unless the config variable `pack.windowMemory` is set.\n\nThat does not go far enough as it does not say what happens when the\nvariable is set (i.e. \"the variable serves as the default in that\ncase\").\n\nPerhaps \"...makes memory usage unlimited.  The default is taken from\nthe `pack.windowMemory` configuration variable.\" would make it better,\nas it is described that its default is \"unlimited\".\n\n> diff --git a/Documentation/git-repack.txt b/Documentation/git-repack.txt\n> index c597523..300455b 100644\n> --- a/Documentation/git-repack.txt\n> +++ b/Documentation/git-repack.txt\n> @@ -101,7 +101,11 @@ other objects in that pack they already have locally.\n>  \tadvantage of the large window for the smaller objects.  The\n>  \tsize can be suffixed with \"k\", \"m\", or \"g\".\n>  \t`--window-memory=0` makes memory usage unlimited, which is the\n> -\tdefault.\n> +\tdefault, unless the config variable `pack.windowMemory` is set.\n> +\tNote that the actual memory usage will be multiplied\n> +\tby the number of threads used by linkgit:git-pack-objects[1],\n> +\twhich is lacking a corresponding git-repack flag but can be\n> +\tset via the config variable `pack.threads`.\n\nI think the same comment applies to the first line.  The next two\nlines are definite improvement, but I do not think the last two\nlines are necessary.\n"},{"id":"293588","messageId":"cbee7385-5f66-0386-8566-ebf15ca9efeb@redhat.com","threadId":"43036","inReplyTo":"xmqqlh05ajbm.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] document git-repack interaction of pack.threads and pack.windowMemory","fromName":"Michael Stahl","fromEmail":"mstahl@redhat.com","sentAt":"2016-08-10T10:39:35Z","receivedAt":"2016-08-10T18:58:28Z","isPatch":true,"sender":{"key":"mstahl@redhat.com","avatar":null},"body":"Signed-off-by: Michael Stahl <mstahl@redhat.com>\n---\n Documentation/git-pack-objects.txt | 4 ++--\n Documentation/git-repack.txt       | 6 ++++--\n 2 files changed, 6 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt\nindex 19cdcd0..8973510 100644\n--- a/Documentation/git-pack-objects.txt\n+++ b/Documentation/git-pack-objects.txt\n@@ -104,8 +104,8 @@ base-name::\n \tout of memory with a large window, but still be able to take\n \tadvantage of the large window for the smaller objects.  The\n \tsize can be suffixed with \"k\", \"m\", or \"g\".\n-\t`--window-memory=0` makes memory usage unlimited, which is the\n-\tdefault.\n+\t`--window-memory=0` makes memory usage unlimited.  The default\n+\tis taken from the `pack.windowMemory` configuration variable.\n \n --max-pack-size=<n>::\n \tMaximum size of each output pack file. The size can be suffixed with\ndiff --git a/Documentation/git-repack.txt b/Documentation/git-repack.txt\nindex c597523..26afe6e 100644\n--- a/Documentation/git-repack.txt\n+++ b/Documentation/git-repack.txt\n@@ -100,8 +100,10 @@ other objects in that pack they already have locally.\n \tout of memory with a large window, but still be able to take\n \tadvantage of the large window for the smaller objects.  The\n \tsize can be suffixed with \"k\", \"m\", or \"g\".\n-\t`--window-memory=0` makes memory usage unlimited, which is the\n-\tdefault.\n+\t`--window-memory=0` makes memory usage unlimited.  The default\n+\tis taken from the `pack.windowMemory` configuration variable.\n+\tNote that the actual memory usage will be the limit multiplied\n+\tby the number of threads used by linkgit:git-pack-objects[1].\n \n --max-pack-size=<n>::\n \tMaximum size of each output pack file. The size can be suffixed with\n-- \n2.7.4\n\n\n"}]}