{"thread":{"id":"42993","subject":"2.9.2 test failures on macOS","startedAt":"2016-08-03T09:23:56Z","lastAt":"2016-08-03T17:05:31Z","messageCount":5,"participants":["Jeremy Huddleston Sequoia","Lars Schneider","Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"292888","messageId":"C4207508-629B-41DF-8E89-CDD1989BCF2E@macports.org","threadId":"42993","inReplyTo":null,"subject":"2.9.2 test failures on macOS","fromName":"Jeremy Huddleston Sequoia","fromEmail":"jeremyhu@macports.org","sentAt":"2016-08-03T07:35:55Z","receivedAt":"2016-08-03T09:23:56Z","isPatch":false,"sender":{"key":"jeremyhu@macports.org","avatar":null},"body":"I have two test failures to report in git 2.9.2 on macOS:\n\n\nt3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:\n\nnot ok 26 - retry acquiring packed-refs.lock\n#\t\n#\t\tLOCK=.git/packed-refs.lock &&\n#\t\t>\"$LOCK\" &&\n#\t\ttest_when_finished \"wait; rm -f $LOCK\" &&\n#\t\t{\n#\t\t\t( sleep 1 ; rm -f $LOCK ) &\n#\t\t} &&\n#\t\tgit -c core.packedrefstimeout=3000 pack-refs --all --prune\n#\t\n\n===\n\nt3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:\n\n$ ./t3700-add.sh\n...\n# passed all 40 test(s)\n1..40\n\n$ sudo ./t3700-add.sh\n...\nnot ok 39 - git add --chmod=-x stages an executable file with -x\n#\t\n#\t\techo foo >xfoo1 &&\n#\t\tchmod 755 xfoo1 &&\n#\t\tgit add --chmod=-x xfoo1 &&\n#\t\tcase \"$(git ls-files --stage xfoo1)\" in\n#\t\t100644\" \"*xfoo1) echo pass;;\n#\t\t*) echo fail; git ls-files --stage xfoo1; (exit 1);;\n#\t\tesac\n#\t\n# failed 1 among 40 test(s)\n1..40\n\n"},{"id":"292890","messageId":"88BA92D6-305F-4B23-ABD2-55A6145F22D9@gmail.com","threadId":"42993","inReplyTo":"C4207508-629B-41DF-8E89-CDD1989BCF2E@macports.org","subject":"Re: 2.9.2 test failures on macOS","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-08-03T10:18:37Z","receivedAt":"2016-08-03T10:26:47Z","isPatch":false,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\n> On 03 Aug 2016, at 09:35, Jeremy Huddleston Sequoia <jeremyhu@macports.org> wrote:\n> \n> I have two test failures to report in git 2.9.2 on macOS:\n> \n> \n> t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:\n> \n> not ok 26 - retry acquiring packed-refs.lock\n> #\t\n> #\t\tLOCK=.git/packed-refs.lock &&\n> #\t\t>\"$LOCK\" &&\n> #\t\ttest_when_finished \"wait; rm -f $LOCK\" &&\n> #\t\t{\n> #\t\t\t( sleep 1 ; rm -f $LOCK ) &\n> #\t\t} &&\n> #\t\tgit -c core.packedrefstimeout=3000 pack-refs --all --prune\n> #\t\n> \n> ===\n> \n> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:\n> \n> $ ./t3700-add.sh\n> ...\n> # passed all 40 test(s)\n> 1..40\n> \n> $ sudo ./t3700-add.sh\n> ...\n> not ok 39 - git add --chmod=-x stages an executable file with -x\n> #\t\n> #\t\techo foo >xfoo1 &&\n> #\t\tchmod 755 xfoo1 &&\n> #\t\tgit add --chmod=-x xfoo1 &&\n> #\t\tcase \"$(git ls-files --stage xfoo1)\" in\n> #\t\t100644\" \"*xfoo1) echo pass;;\n> #\t\t*) echo fail; git ls-files --stage xfoo1; (exit 1);;\n> #\t\tesac\n> #\t\n> # failed 1 among 40 test(s)\n> 1..40\n> \n\nWhat OS version do you use? Can you run `sw_vers` in your terminal and share the result?\n\nThanks,\nLars\n\n"},{"id":"292906","messageId":"944D9B54-6DB8-42E7-890D-38CB5D6DFFEF@macports.org","threadId":"42993","inReplyTo":"alpine.DEB.2.20.1608031632110.107993@virtualbox","subject":"Re: 2.9.2 test failures on macOS","fromName":"Jeremy Huddleston Sequoia","fromEmail":"jeremyhu@macports.org","sentAt":"2016-08-03T16:08:49Z","receivedAt":"2016-08-03T17:04:51Z","isPatch":false,"sender":{"key":"jeremyhu@macports.org","avatar":null},"body":"\n> On Aug 3, 2016, at 07:35, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:\n> \n> Hi Jeremy,\n> \n> On Wed, 3 Aug 2016, Jeremy Huddleston Sequoia wrote:\n> \n>> I have two test failures to report in git 2.9.2 on macOS:\n>> \n>> \n>> t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:\n>> \n>> not ok 26 - retry acquiring packed-refs.lock\n>> #\t\n>> #\t\tLOCK=.git/packed-refs.lock &&\n>> #\t\t>\"$LOCK\" &&\n>> #\t\ttest_when_finished \"wait; rm -f $LOCK\" &&\n>> #\t\t{\n>> #\t\t\t( sleep 1 ; rm -f $LOCK ) &\n>> #\t\t} &&\n>> #\t\tgit -c core.packedrefstimeout=3000 pack-refs --all --prune\n>> #\n>> \n>> ===\n>> \n>> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:\n>> \n>> $ ./t3700-add.sh\n>> ...\n>> # passed all 40 test(s)\n>> 1..40\n>> \n>> $ sudo ./t3700-add.sh\n>> ...\n>> not ok 39 - git add --chmod=-x stages an executable file with -x\n>> #\t\n>> #\t\techo foo >xfoo1 &&\n>> #\t\tchmod 755 xfoo1 &&\n>> #\t\tgit add --chmod=-x xfoo1 &&\n>> #\t\tcase \"$(git ls-files --stage xfoo1)\" in\n>> #\t\t100644\" \"*xfoo1) echo pass;;\n>> #\t\t*) echo fail; git ls-files --stage xfoo1; (exit 1);;\n>> #\t\tesac\n>> #\t\n>> # failed 1 among 40 test(s)\n>> 1..40\n> \n> I tried to write up all I know about debugging test failures here:\n> \n> https://github.com/git-for-windows/git/wiki/Running-Git's-regression-tests#running-individual-tests\n> \n> Could you give it a try and diagnose the breakage further? (The output you\n> provided is unfortunately not enough to determine what went wrong.)\n\nAnother report indicates that the second was a known failure already.  As for the first one:\n\n~/tmp/test $ git init\nInitialized empty Git repository in /Users/jeremy/tmp/test/.git/\n\n~/tmp/test (master) $ touch .git/packed-refs.lock \n\n~/tmp/test (master) $ git -c core.packedrefstimeout=3000 pack-refs --all --prune\nfatal: Unable to create '/Users/jeremy/tmp/test/.git/packed-refs.lock': File exists.\n\nAnother git process seems to be running in this repository, e.g.\nan editor opened by 'git commit'. Please make sure all processes\nare terminated then try again. If it still fails, a git process\nmay have crashed in this repository earlier:\nremove the file manually to continue.\n\n--\n\nI just tried this again with 2.8.4, and I see the same failure.  I could've sworn that 2.8.4 passed all tests when I tested it back in June."},{"id":"292929","messageId":"alpine.DEB.2.20.1608031632110.107993@virtualbox","threadId":"42993","inReplyTo":"C4207508-629B-41DF-8E89-CDD1989BCF2E@macports.org","subject":"Re: 2.9.2 test failures on macOS","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-08-03T14:35:10Z","receivedAt":"2016-08-03T17:05:19Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Jeremy,\n\nOn Wed, 3 Aug 2016, Jeremy Huddleston Sequoia wrote:\n\n> I have two test failures to report in git 2.9.2 on macOS:\n> \n> \n> t3210-pack-refs.sh has not changed between 2.8.4 and 2.9.2.  This test passed fine with 2.8.4, but it now fails with 2.9.2 at:\n> \n> not ok 26 - retry acquiring packed-refs.lock\n> #\t\n> #\t\tLOCK=.git/packed-refs.lock &&\n> #\t\t>\"$LOCK\" &&\n> #\t\ttest_when_finished \"wait; rm -f $LOCK\" &&\n> #\t\t{\n> #\t\t\t( sleep 1 ; rm -f $LOCK ) &\n> #\t\t} &&\n> #\t\tgit -c core.packedrefstimeout=3000 pack-refs --all --prune\n> #\t\n> \n> ===\n> \n> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:\n> \n> $ ./t3700-add.sh\n> ...\n> # passed all 40 test(s)\n> 1..40\n> \n> $ sudo ./t3700-add.sh\n> ...\n> not ok 39 - git add --chmod=-x stages an executable file with -x\n> #\t\n> #\t\techo foo >xfoo1 &&\n> #\t\tchmod 755 xfoo1 &&\n> #\t\tgit add --chmod=-x xfoo1 &&\n> #\t\tcase \"$(git ls-files --stage xfoo1)\" in\n> #\t\t100644\" \"*xfoo1) echo pass;;\n> #\t\t*) echo fail; git ls-files --stage xfoo1; (exit 1);;\n> #\t\tesac\n> #\t\n> # failed 1 among 40 test(s)\n> 1..40\n\nI tried to write up all I know about debugging test failures here:\n\nhttps://github.com/git-for-windows/git/wiki/Running-Git's-regression-tests#running-individual-tests\n\nCould you give it a try and diagnose the breakage further? (The output you\nprovided is unfortunately not enough to determine what went wrong.)\n\nCiao,\nJohannes\n"},{"id":"292938","messageId":"xmqqziotalpj.fsf@gitster.mtv.corp.google.com","threadId":"42993","inReplyTo":"C4207508-629B-41DF-8E89-CDD1989BCF2E@macports.org","subject":"Re: 2.9.2 test failures on macOS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-08-03T15:58:16Z","receivedAt":"2016-08-03T17:05:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeremy Huddleston Sequoia <jeremyhu@macports.org> writes:\n\n> t3700-add.sh recently added the 'git add --chmod=-x stages an executable file with -x' test.  This test passes when run as a normal user but fails when run as root:\n>\n> $ ./t3700-add.sh\n\nThis has been spotted and corrected on the development track\nalready, I think.  It will hopefully be in a future maintenance\nrelease.\n\nIf you have a chance, perhaps you can fetch from my tree at\ngit.kernel.org:/pub/scm/git/git.git and merge 766cdc41 (t3700: add a\ntest_mode_in_index helper function, 2016-07-30) to confirm the fix?\n\nThanks.\n"}]}