{"thread":{"id":"42930","subject":"[PATCH v2] commit: Fix description of no-verify","startedAt":"2016-07-26T14:00:36Z","lastAt":"2016-07-26T20:44:11Z","messageCount":2,"participants":["orgads@gmail.com","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"292208","messageId":"1469541615-21726-1-git-send-email-orgads@gmail.com","threadId":"42930","inReplyTo":"alpine.DEB.2.20.1607261541170.14111","subject":"[PATCH v2] commit: Fix description of no-verify","fromName":"","fromEmail":"orgads@gmail.com","sentAt":"2016-07-26T14:00:15Z","receivedAt":"2016-07-26T14:00:36Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"From: Orgad Shaneh <orgads@gmail.com>\n\ninclude also commit-msg hook.\n\nThis brings the short help in line with the documentation.\n\nSigned-off-by: Orgad Shaneh <orgads@gmail.com>\n---\n builtin/commit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex 163dbca..2725712 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -1616,7 +1616,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)\n \t\tOPT_BOOL(0, \"interactive\", &interactive, N_(\"interactively add files\")),\n \t\tOPT_BOOL('p', \"patch\", &patch_interactive, N_(\"interactively add changes\")),\n \t\tOPT_BOOL('o', \"only\", &only, N_(\"commit only specified files\")),\n-\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit hook\")),\n+\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit and commit-msg hooks\")),\n \t\tOPT_BOOL(0, \"dry-run\", &dry_run, N_(\"show what would be committed\")),\n \t\tOPT_SET_INT(0, \"short\", &status_format, N_(\"show status concisely\"),\n \t\t\t    STATUS_FORMAT_SHORT),\n-- \n2.8.1\n\n"},{"id":"292262","messageId":"xmqqoa5kyvse.fsf@gitster.mtv.corp.google.com","threadId":"42930","inReplyTo":"1469541615-21726-1-git-send-email-orgads@gmail.com","subject":"Re: [PATCH v2] commit: Fix description of no-verify","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-26T20:44:01Z","receivedAt":"2016-07-26T20:44:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"orgads@gmail.com writes:\n\n> Subject: Re: [PATCH v2] commit: Fix description of no-verify\n\nFollowing the prevailing style from \"git shortlog --no-merges -100\"\nwould make it \"commit: fix description of no-verify\", but \"fix\" is\ntoo generic a word and does not convey as much information as it\nwastes bits ;-)\n\n    Subject: commit: --no-verify option skips commit-msg hook, too\n\nperhaps?\n\n> From: Orgad Shaneh <orgads@gmail.com>\n>\n> include also commit-msg hook.\n\nThen this half-sentence can go completely.\n\nThanks; I'll do the above myself while queuing, so there is no need\nto resend.\n\n> diff --git a/builtin/commit.c b/builtin/commit.c\n> index 163dbca..2725712 100644\n> --- a/builtin/commit.c\n> +++ b/builtin/commit.c\n> @@ -1616,7 +1616,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)\n>  \t\tOPT_BOOL(0, \"interactive\", &interactive, N_(\"interactively add files\")),\n>  \t\tOPT_BOOL('p', \"patch\", &patch_interactive, N_(\"interactively add changes\")),\n>  \t\tOPT_BOOL('o', \"only\", &only, N_(\"commit only specified files\")),\n> -\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit hook\")),\n> +\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit and commit-msg hooks\")),\n>  \t\tOPT_BOOL(0, \"dry-run\", &dry_run, N_(\"show what would be committed\")),\n>  \t\tOPT_SET_INT(0, \"short\", &status_format, N_(\"show status concisely\"),\n>  \t\t\t    STATUS_FORMAT_SHORT),\n"}]}