{"thread":{"id":"42927","subject":"[PATCH] commit: Fix description of no-verify","startedAt":"2016-07-26T07:48:41Z","lastAt":"2016-07-26T13:44:00Z","messageCount":4,"participants":["Orgad Shaneh","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"292182","messageId":"1469519305-11361-1-git-send-email-orgad.shaneh@audiocodes.com","threadId":"42927","inReplyTo":null,"subject":"[PATCH] commit: Fix description of no-verify","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-07-26T07:48:25Z","receivedAt":"2016-07-26T07:48:41Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"From: Orgad Shaneh \n\ninclude also commit-msg hook.\n\nSigned-off-by: Orgad Shaneh \n---\n builtin/commit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex 163dbca..2725712 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -1616,7 +1616,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)\n \t\tOPT_BOOL(0, \"interactive\", &interactive, N_(\"interactively add files\")),\n \t\tOPT_BOOL('p', \"patch\", &patch_interactive, N_(\"interactively add changes\")),\n \t\tOPT_BOOL('o', \"only\", &only, N_(\"commit only specified files\")),\n-\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit hook\")),\n+\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit and commit-msg hooks\")),\n \t\tOPT_BOOL(0, \"dry-run\", &dry_run, N_(\"show what would be committed\")),\n \t\tOPT_SET_INT(0, \"short\", &status_format, N_(\"show status concisely\"),\n \t\t\t STATUS_FORMAT_SHORT),\n-- \n2.8.2\n\n"},{"id":"292199","messageId":"alpine.DEB.2.20.1607261452281.14111@virtualbox","threadId":"42927","inReplyTo":"1469519305-11361-1-git-send-email-orgad.shaneh@audiocodes.com","subject":"Re: [PATCH] commit: Fix description of no-verify","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-07-26T12:55:08Z","receivedAt":"2016-07-26T12:55:24Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Orgad\n\nOn Tue, 26 Jul 2016, Orgad Shaneh wrote:\n\n> From: Orgad Shaneh \n\nThis is unnecessary, as it matches your email address.\n\n> include also commit-msg hook.\n\nThis comment was a bit cryptic, until I read the patch. Now I find that\ncomment redundant with the patch.\n\nHowever, I think that...\n\n> -\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit hook\")),\n> +\t\tOPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit and commit-msg hooks\")),\n\n\n... it may be more desirable to future-proof this simply by saying \"bypass\nhooks\".\n\nIn the alternative, it would be good if the commit message could\nconvincingly make the case that there are no other hooks that will be\nskipped with -n.\n\nOf course, I could go and look at the source code to convince myself. But\nit is really the duty of the commit message to be already convincing\nenough.\n\nCiao,\nDscho\n"},{"id":"292202","messageId":"CAGHpTB+5ePbGyBMjozmwC=0ksqQShUt8Pa=QzPg4R0tf5467Xw@mail.gmail.com","threadId":"42927","inReplyTo":"alpine.DEB.2.20.1607261452281.14111@virtualbox","subject":"Re: [PATCH] commit: Fix description of no-verify","fromName":"Orgad Shaneh","fromEmail":"orgads@gmail.com","sentAt":"2016-07-26T13:09:55Z","receivedAt":"2016-07-26T13:10:05Z","isPatch":true,"sender":{"key":"orgads@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1246544?v=4"},"body":"Hi and thanks for your reply.\n\nOn Tue, Jul 26, 2016 at 3:55 PM, Johannes Schindelin\n wrote:\n> Hi Orgad\n>\n> On Tue, 26 Jul 2016, Orgad Shaneh wrote:\n>\n>> From: Orgad Shaneh \n>\n> This is unnecessary, as it matches your email address.\n>\n>> include also commit-msg hook.\n>\n> This comment was a bit cryptic, until I read the patch. Now I find that\n> comment redundant with the patch.\n\nThis brings the short help in line with the documentation. I should\nhave stated that in the commit message.\n\n>\n> However, I think that...\n>\n>> - OPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit hook\")),\n>> + OPT_BOOL('n', \"no-verify\", &no_verify, N_(\"bypass pre-commit and commit-msg hooks\")),\n>\n>\n> ... it may be more desirable to future-proof this simply by saying \"bypass\n> hooks\".\n\nThat wouldn't be correct. prepare-commit-msg is not suppressed by this flag.\n\n> In the alternative, it would be good if the commit message could\n> convincingly make the case that there are no other hooks that will be\n> skipped with -n.\n>\n> Of course, I could go and look at the source code to convince myself. But\n> it is really the duty of the commit message to be already convincing\n> enough.\n>\n> Ciao,\n> Dscho\n\nI don't have much experience with submitting patches to Git. How do I\nedit the commit message? Submit it as a new patch?\n\n- Orgad\n"},{"id":"292205","messageId":"alpine.DEB.2.20.1607261541170.14111@virtualbox","threadId":"42927","inReplyTo":"CAGHpTB+5ePbGyBMjozmwC=0ksqQShUt8Pa=QzPg4R0tf5467Xw@mail.gmail.com","subject":"Re: [PATCH] commit: Fix description of no-verify","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-07-26T13:43:43Z","receivedAt":"2016-07-26T13:44:00Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Orgad,\n\nOn Tue, 26 Jul 2016, Orgad Shaneh wrote:\n\n> On Tue, Jul 26, 2016 at 3:55 PM, Johannes Schindelin\n> wrote:\n> >\n> > On Tue, 26 Jul 2016, Orgad Shaneh wrote:\n> >\n> >> include also commit-msg hook.\n> >\n> > This comment was a bit cryptic, until I read the patch. Now I find that\n> > comment redundant with the patch.\n> \n> This brings the short help in line with the documentation. I should\n> have stated that in the commit message.\n\nThat would be good.\n\n> I don't have much experience with submitting patches to Git. How do I\n> edit the commit message? Submit it as a new patch?\n\nYou edit it locally via `git commit --amend` (or using rebase -i's\n`reword` if you need to adjust a commit message in the middle of a patch\nseries, not at the end).\n\nThen you send it as a reply to the first submission (--in-reply-to, if you\nuse format-patch), with the `[PATCH v2]` prefix (--subject-prefix='[PATCH\nv2]' if you use format-patch).\n\nCiao,\nDscho\n"}]}