{"thread":{"id":"42920","subject":"[PATCH] config.mak.uname: correct perl path on FreeBSD","startedAt":"2016-07-25T16:22:21Z","lastAt":"2016-07-26T06:47:10Z","messageCount":8,"participants":["Nguyễn Thái Ngọc Duy","Junio C Hamano","Duy Nguyen","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"292101","messageId":"20160725162125.15734-1-pclouds@gmail.com","threadId":"42920","inReplyTo":null,"subject":"[PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Nguyễn Thái Ngọc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2016-07-25T16:21:25Z","receivedAt":"2016-07-25T16:22:21Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has\nbeen removed at least on FreeBSD 10.3. See [1] for more information.\n\n[1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c\n\nSigned-off-by: Nguyễn Thái Ngọc Duy \n---\n Tested with fbsd 10.3, kvm image. But I suppose it's the same as real\n fbsd.\n\n config.mak.uname | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex a88f139..4cd62bd 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -203,6 +203,7 @@ ifeq ($(uname_S),FreeBSD)\n \t\tNO_STRTOUMAX = YesPlease\n \tendif\n \tPYTHON_PATH = /usr/local/bin/python\n+\tPERL_PATH = /usr/local/bin/perl\n \tHAVE_PATHS_H = YesPlease\n \tGMTIME_UNRELIABLE_ERRORS = UnfortunatelyYes\n \tHAVE_BSD_SYSCTL = YesPlease\n-- \n2.9.1.566.gbd532d4\n\n"},{"id":"292104","messageId":"CAPc5daWNAWjtfR7CYN3RTeT7VyvgiNX5HED0=f3F=GT8h4yKPA@mail.gmail.com","threadId":"42920","inReplyTo":"20160725162125.15734-1-pclouds@gmail.com","subject":"Re: [PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-25T16:56:15Z","receivedAt":"2016-07-25T16:56:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote:\n> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has\n> been removed at least on FreeBSD 10.3. See [1] for more information.\n>\n> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c\n>\n> Signed-off-by: Nguyễn Thái Ngọc Duy \n> ---\n> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real\n> fbsd.\n\nThanks; and we know that older (but not too old that we no longer care about)\nFreeBSD all have /usr/local/bin/perl?\n"},{"id":"292108","messageId":"CACsJy8Df2cBAf0bWe1FLTb9cOqTX3vgNgC=ko82rG2in81R-FQ@mail.gmail.com","threadId":"42920","inReplyTo":"CAPc5daWNAWjtfR7CYN3RTeT7VyvgiNX5HED0=f3F=GT8h4yKPA@mail.gmail.com","subject":"Re: [PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2016-07-25T17:27:41Z","receivedAt":"2016-07-25T17:28:25Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote:\n> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote:\n>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has\n>> been removed at least on FreeBSD 10.3. See [1] for more information.\n>>\n>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c\n>>\n>> Signed-off-by: Nguyễn Thái Ngọc Duy \n>> ---\n>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real\n>> fbsd.\n>\n> Thanks; and we know that older (but not too old that we no longer care about)\n> FreeBSD all have /usr/local/bin/perl?\n\nI'm no fbsd expert but from the first sentence in [1] \"Perl has been\nremoved from base more than ten years ago...\" I would assume it meant\n\"... removed from base, _to_ ports system\" which means /usr/local for\nall package installation (for ten years for perl). So I think we are\ngood.\n-- \nDuy\n"},{"id":"292115","messageId":"xmqqinvt610x.fsf@gitster.mtv.corp.google.com","threadId":"42920","inReplyTo":"CACsJy8Df2cBAf0bWe1FLTb9cOqTX3vgNgC=ko82rG2in81R-FQ@mail.gmail.com","subject":"Re: [PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-25T18:11:26Z","receivedAt":"2016-07-25T18:11:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Duy Nguyen writes:\n\n> On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote:\n>> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote:\n>>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has\n>>> been removed at least on FreeBSD 10.3. See [1] for more information.\n>>>\n>>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c\n>>>\n>>> Signed-off-by: Nguyễn Thái Ngọc Duy \n>>> ---\n>>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real\n>>> fbsd.\n>>\n>> Thanks; and we know that older (but not too old that we no longer care about)\n>> FreeBSD all have /usr/local/bin/perl?\n>\n> I'm no fbsd expert but from the first sentence in [1] \"Perl has been\n> removed from base more than ten years ago...\" I would assume it meant\n> \"... removed from base, _to_ ports system\" which means /usr/local for\n> all package installation (for ten years for perl). So I think we are\n> good.\n\nI guess we didn't follow through\n\n http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/\n\nand allowed the thread to drift into a tangent?\n\n\n"},{"id":"292140","messageId":"20160725203316.GA32053@starla","threadId":"42920","inReplyTo":"xmqqinvt610x.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-07-25T20:33:16Z","receivedAt":"2016-07-25T20:33:21Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Duy Nguyen writes:\n> \n> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote:\n> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote:\n> >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has\n> >>> been removed at least on FreeBSD 10.3. See [1] for more information.\n> >>>\n> >>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c\n\nAh, I missed that. I guess that explains why nobody complained\nabout the problem sooner.\n\n> >>> Signed-off-by: Nguyễn Thái Ngọc Duy \n> >>> ---\n> >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real\n> >>> fbsd.\n> >>\n> >> Thanks; and we know that older (but not too old that we no longer care about)\n> >> FreeBSD all have /usr/local/bin/perl?\n> >\n> > I'm no fbsd expert but from the first sentence in [1] \"Perl has been\n> > removed from base more than ten years ago...\" I would assume it meant\n> > \"... removed from base, _to_ ports system\" which means /usr/local for\n> > all package installation (for ten years for perl). So I think we are\n> > good.\n> \n> I guess we didn't follow through\n> \n> http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/\n> \n> and allowed the thread to drift into a tangent?\n\n+Cc Dscho\n\nI've been meaning to followup on that, but had connectivity\nproblems to my VM last week. I still prefer we use numeric\ncomparisons for version numbers since numbers are... numeric.\nIOW, I prefer we go with my original patch.\n"},{"id":"292141","messageId":"xmqqoa5l4fh0.fsf@gitster.mtv.corp.google.com","threadId":"42920","inReplyTo":"20160725203316.GA32053@starla","subject":"Re: [PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-25T20:42:19Z","receivedAt":"2016-07-25T20:42:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Junio C Hamano wrote:\n>> Duy Nguyen writes:\n>> \n>> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote:\n>> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote:\n>> >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has\n>> >>> been removed at least on FreeBSD 10.3. See [1] for more information.\n>> >>>\n>> >>> [1] https://svnweb.freebsd.org/ports/head/UPDATING?r1=386270&r2=386269&pathrev=386270&diff_format=c\n>\n> Ah, I missed that. I guess that explains why nobody complained\n> about the problem sooner.\n>\n>> >>> Signed-off-by: Nguyễn Thái Ngọc Duy \n>> >>> ---\n>> >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real\n>> >>> fbsd.\n>> >>\n>> >> Thanks; and we know that older (but not too old that we no longer care about)\n>> >> FreeBSD all have /usr/local/bin/perl?\n>> >\n>> > I'm no fbsd expert but from the first sentence in [1] \"Perl has been\n>> > removed from base more than ten years ago...\" I would assume it meant\n>> > \"... removed from base, _to_ ports system\" which means /usr/local for\n>> > all package installation (for ten years for perl). So I think we are\n>> > good.\n>> \n>> I guess we didn't follow through\n>> \n>> http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/\n>> \n>> and allowed the thread to drift into a tangent?\n>\n> +Cc Dscho\n>\n> I've been meaning to followup on that, but had connectivity\n> problems to my VM last week. I still prefer we use numeric\n> comparisons for version numbers since numbers are... numeric.\n> IOW, I prefer we go with my original patch.\n\nI tend to agree with you if we have to do \"systems older than this\nshould use /usr/bin, others should use /usr/local/bin\", but this\ndifferent incarnation of the same topic seems to claim that older\nones had /usr/local/bin forever anyway, and that was what made the\npatch interesting.\n\n"},{"id":"292177","messageId":"20160726061854.GA13334@starla","threadId":"42920","inReplyTo":"xmqqoa5l4fh0.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-07-26T06:18:54Z","receivedAt":"2016-07-26T06:19:00Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Eric Wong writes:\n> > Junio C Hamano wrote:\n> >> Duy Nguyen writes:\n> >> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote:\n> >> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy wrote:\n> > about the problem sooner.\n> >\n> >> >>> Signed-off-by: Nguyễn Thái Ngọc Duy \n> >> >>> ---\n> >> >>> Tested with fbsd 10.3, kvm image. But I suppose it's the same as real\n> >> >>> fbsd.\n> >> >>\n> >> >> Thanks; and we know that older (but not too old that we no longer care about)\n> >> >> FreeBSD all have /usr/local/bin/perl?\n> >> >\n> >> > I'm no fbsd expert but from the first sentence in [1] \"Perl has been\n> >> > removed from base more than ten years ago...\" I would assume it meant\n> >> > \"... removed from base, _to_ ports system\" which means /usr/local for\n> >> > all package installation (for ten years for perl). So I think we are\n> >> > good.\n> >> \n> >> I guess we didn't follow through\n> >> \n> >> http://public-inbox.org/git/%3C20160720025630.GA71874%40plume%3E/\n> >> \n> >> and allowed the thread to drift into a tangent?\n> >\n> > +Cc Dscho\n> >\n> > I've been meaning to followup on that, but had connectivity\n> > problems to my VM last week. I still prefer we use numeric\n> > comparisons for version numbers since numbers are... numeric.\n> > IOW, I prefer we go with my original patch.\n> \n> I tend to agree with you if we have to do \"systems older than this\n> should use /usr/bin, others should use /usr/local/bin\", but this\n> different incarnation of the same topic seems to claim that older\n> ones had /usr/local/bin forever anyway, and that was what made the\n> patch interesting.\n\nI dug around the freebsd history (git://github.com/freebsd/freebsd.git)\n(~1.5G) and the 3.x and 4.x releases with perl in base still contained\nmany references to /usr/local/bin/perl\n\nIt also seems FreeBSD 2.x releases were also perl-less in base;\nso yes, I'm alright with Duy's patch :)\n"},{"id":"292179","messageId":"xmqq8two3nh7.fsf@gitster.mtv.corp.google.com","threadId":"42920","inReplyTo":"20160726061854.GA13334@starla","subject":"Re: [PATCH] config.mak.uname: correct perl path on FreeBSD","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-26T06:47:00Z","receivedAt":"2016-07-26T06:47:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> I dug around the freebsd history (git://github.com/freebsd/freebsd.git)\n> (~1.5G) and the 3.x and 4.x releases with perl in base still contained\n> many references to /usr/local/bin/perl\n>\n> It also seems FreeBSD 2.x releases were also perl-less in base;\n> so yes, I'm alright with Duy's patch :)\n\nThanks for a quick digging to converge to the simplest solution.\n\nWill replace and merge to 'next' soonish.\n\n"}]}