{"thread":{"id":"42902","subject":"[PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK","startedAt":"2016-07-21T20:59:15Z","lastAt":"2016-07-23T08:39:54Z","messageCount":6,"participants":["Johannes Sixt","Johannes Schindelin","Junio C Hamano","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"291934","messageId":"28dbe3b0-7a16-1b87-3d59-b8c981fead7c@kdbg.org","threadId":"42902","inReplyTo":null,"subject":"[PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2016-07-21T20:59:06Z","receivedAt":"2016-07-21T20:59:15Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The previous commit introduced the first use of ENOTSOCK. This macro is\nnot available on Windows. Define it as WSAENOTSOCK because that is the\ncorresponding error value reported by the Windows versions of socket\nfunctions.\n\nSigned-off-by: Johannes Sixt \n---\n compat/mingw.h | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/compat/mingw.h b/compat/mingw.h\nindex 233933e..95e128f 100644\n--- a/compat/mingw.h\n+++ b/compat/mingw.h\n@@ -73,6 +73,9 @@ typedef int pid_t;\n #ifndef ECONNABORTED\n #define ECONNABORTED WSAECONNABORTED\n #endif\n+#ifndef ENOTSOCK\n+#define ENOTSOCK WSAENOTSOCK\n+#endif\n\n struct passwd {\n \tchar *pw_name;\n-- \n2.9.0.443.ga8520ad\n\n"},{"id":"291943","messageId":"alpine.DEB.2.20.1607221020520.14111@virtualbox","threadId":"42902","inReplyTo":"28dbe3b0-7a16-1b87-3d59-b8c981fead7c@kdbg.org","subject":"Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-07-22T08:21:19Z","receivedAt":"2016-07-22T08:22:00Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Hannes,\n\nOn Thu, 21 Jul 2016, Johannes Sixt wrote:\n\n> The previous commit introduced the first use of ENOTSOCK. This macro is\n> not available on Windows. Define it as WSAENOTSOCK because that is the\n> corresponding error value reported by the Windows versions of socket\n> functions.\n\nThanks for catching this early.\n\nCiao,\nDscho\n"},{"id":"291995","messageId":"xmqqmvl9a2wc.fsf@gitster.mtv.corp.google.com","threadId":"42902","inReplyTo":"alpine.DEB.2.20.1607221020520.14111@virtualbox","subject":"Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-22T19:28:19Z","receivedAt":"2016-07-22T19:28:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi Hannes,\n>\n> On Thu, 21 Jul 2016, Johannes Sixt wrote:\n>\n>> The previous commit introduced the first use of ENOTSOCK. This macro is\n>> not available on Windows. Define it as WSAENOTSOCK because that is the\n>> corresponding error value reported by the Windows versions of socket\n>> functions.\n>\n> Thanks for catching this early.\n\n(is that an acked/reviewed-by? it is OK if it is not).\n\nYeah, thanks, both.\n"},{"id":"291998","messageId":"20160722193156.GA30158@dcvr","threadId":"42902","inReplyTo":"28dbe3b0-7a16-1b87-3d59-b8c981fead7c@kdbg.org","subject":"Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-07-22T19:31:56Z","receivedAt":"2016-07-22T19:32:01Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Johannes Sixt wrote:\n> The previous commit introduced the first use of ENOTSOCK. This macro is\n> not available on Windows. Define it as WSAENOTSOCK because that is the\n> corresponding error value reported by the Windows versions of socket\n> functions.\n\nThanks. I thought compat/poll/poll.c already used ENOTSOCK\nbut I was mislead by the #ifdefs :x\n"},{"id":"292031","messageId":"alpine.DEB.2.20.1607230957320.14111@virtualbox","threadId":"42902","inReplyTo":"xmqqmvl9a2wc.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-07-23T08:02:22Z","receivedAt":"2016-07-23T08:03:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Fri, 22 Jul 2016, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > On Thu, 21 Jul 2016, Johannes Sixt wrote:\n> >\n> >> The previous commit introduced the first use of ENOTSOCK. This macro is\n> >> not available on Windows. Define it as WSAENOTSOCK because that is the\n> >> corresponding error value reported by the Windows versions of socket\n> >> functions.\n> >\n> > Thanks for catching this early.\n> \n> (is that an acked/reviewed-by? it is OK if it is not).\n\nIt had been neither, as I had only looked at the patch briefly (which I\ndeem not enough to account for a review).\n\nHowever, I now reviewed it properly and offer my Acked-by:.\n\nIf it is not too much to ask, I would love to have the following added to\nthe commit message:\n\n\tFor details, see\n\thttps://msdn.microsoft.com/en-us/library/windows/desktop/ms740476.aspx\n\nThanks,\nDscho\n"},{"id":"292033","messageId":"4ca7ee51-351b-d222-d05a-63c5bdc5c383@kdbg.org","threadId":"42902","inReplyTo":"alpine.DEB.2.20.1607230957320.14111@virtualbox","subject":"[PATCH v2 ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2016-07-23T08:39:43Z","receivedAt":"2016-07-23T08:39:54Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"The previous commit introduced the first use of ENOTSOCK. This macro is\nnot available on Windows. Define it as WSAENOTSOCK because that is the\ncorresponding error value reported by the Windows versions of socket\nfunctions.\n\nFor details, see\nhttps://msdn.microsoft.com/en-us/library/windows/desktop/ms740476.aspx\n\nSigned-off-by: Johannes Sixt \nAcked-by: Johannes Schindelin \n---\n Same patch text, but the commit message is amended, just in case it's\n easier for you to apply a new patch than to amend a queued one.\n\n Thanks everybody.\n\n compat/mingw.h | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/compat/mingw.h b/compat/mingw.h\nindex 233933e..95e128f 100644\n--- a/compat/mingw.h\n+++ b/compat/mingw.h\n@@ -73,6 +73,9 @@ typedef int pid_t;\n #ifndef ECONNABORTED\n #define ECONNABORTED WSAECONNABORTED\n #endif\n+#ifndef ENOTSOCK\n+#define ENOTSOCK WSAENOTSOCK\n+#endif\n\n struct passwd {\n char *pw_name;\n-- \n2.9.0.443.ga8520ad\n\n"}]}