{"thread":{"id":"42901","subject":"[PATCH] test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/","startedAt":"2016-07-21T16:03:48Z","lastAt":"2017-01-27T20:49:35Z","messageCount":5,"participants":["Johannes Schindelin","Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"291925","messageId":"31dce0b28ae094c976890c1604c4ebbcaef0e7ef.1469116960.git.johannes.schindelin@gmx.de","threadId":"42901","inReplyTo":null,"subject":"[PATCH] test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-07-21T16:02:54Z","receivedAt":"2016-07-21T16:03:48Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nEric Wong reported that while FreeBSD has a /usr/bin/unzip, it uses\ndifferent semantics from those that are needed by Git's tests: When\npassing the -a option to Info-Zip, it heeds the text attribute of the\n.zip file's central directory, while FreeBSD's unzip ignores that\nattribute.\n\nThe common work-around is to install Info-Zip on FreeBSD, into\n/usr/local/bin/.\n\nSigned-off-by: Johannes Schindelin \n---\nPublished-As: https://github.com/dscho/git/releases/tag/freebsd-unzip-v1\n t/test-lib.sh | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 11201e9..dd2f70c 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -929,7 +929,8 @@ yes () {\n }\n \n # Fix some commands on Windows\n-case $(uname -s) in\n+uname_s=$(uname -s)\n+case $uname_s in\n *MINGW*)\n \t# Windows has its own (incompatible) sort and find\n \tsort () {\n@@ -1100,6 +1101,7 @@ test_lazy_prereq SANITY '\n \treturn $status\n '\n \n+test FreeBSD != $uname_s || GIT_UNZIP=${GIT_UNZIP:-/usr/local/bin/unzip}\n GIT_UNZIP=${GIT_UNZIP:-unzip}\n test_lazy_prereq UNZIP '\n \t\"$GIT_UNZIP\" -v\n-- \n2.9.0.281.g286a8d9\n\nbase-commit: 29493589e97a2de0c4c1c314f61ccafaee3b5caf\n"},{"id":"291928","messageId":"20160721171025.GA30979@plume","threadId":"42901","inReplyTo":"31dce0b28ae094c976890c1604c4ebbcaef0e7ef.1469116960.git.johannes.schindelin@gmx.de","subject":"Re: [PATCH] test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-07-21T17:10:25Z","receivedAt":"2016-07-21T17:10:33Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Johannes Schindelin wrote:\n> The common work-around is to install Info-Zip on FreeBSD, into\n> /usr/local/bin/.\n> \n> Signed-off-by: Johannes Schindelin \n\nThanks, t5003 now works out-of-the-box.\nTested with Info-ZIP unzip installed and uninstalled.\n\nTested-by: Eric Wong \n"},{"id":"310407","messageId":"alpine.DEB.2.20.1701271502420.3469@virtualbox","threadId":"42901","inReplyTo":"20160721171025.GA30979@plume","subject":"Re: [PATCH] test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2017-01-27T14:03:18Z","receivedAt":"2017-01-27T14:14:33Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Thu, 21 Jul 2016, Eric Wong wrote:\n\n> Johannes Schindelin wrote:\n> > The common work-around is to install Info-Zip on FreeBSD, into\n> > /usr/local/bin/.\n> > \n> > Signed-off-by: Johannes Schindelin \n> \n> Thanks, t5003 now works out-of-the-box.\n> Tested with Info-ZIP unzip installed and uninstalled.\n> \n> Tested-by: Eric Wong \n\nDid you forget about this?\n\nCiao,\nJohannes\n"},{"id":"310431","messageId":"xmqq8tpwz6jp.fsf@gitster.mtv.corp.google.com","threadId":"42901","inReplyTo":"alpine.DEB.2.20.1701271502420.3469@virtualbox","subject":"Re: [PATCH] test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-27T18:44:42Z","receivedAt":"2017-01-27T18:47:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi Junio,\n>\n> On Thu, 21 Jul 2016, Eric Wong wrote:\n>\n>> Johannes Schindelin wrote:\n>> > The common work-around is to install Info-Zip on FreeBSD, into\n>> > /usr/local/bin/.\n>> > \n>> > Signed-off-by: Johannes Schindelin \n>> \n>> Thanks, t5003 now works out-of-the-box.\n>> Tested with Info-ZIP unzip installed and uninstalled.\n>> \n>> Tested-by: Eric Wong \n>\n> Did you forget about this?\n\nThis fell off the radar. \n\nYou could have resent with Eric's Tested-by: added, to make it\neasier to apply. I'll see if I can find the original but it won't\nhappen until later this afternoon.\n"},{"id":"310438","messageId":"xmqqvat0xmae.fsf@gitster.mtv.corp.google.com","threadId":"42901","inReplyTo":"xmqq8tpwz6jp.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-01-27T20:47:37Z","receivedAt":"2017-01-27T20:49:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Johannes Schindelin writes:\n>> On Thu, 21 Jul 2016, Eric Wong wrote:\n>>\n>>> Thanks, t5003 now works out-of-the-box.\n>>> Tested with Info-ZIP unzip installed and uninstalled.\n>>> \n>>> Tested-by: Eric Wong \n>>\n>> Did you forget about this?\n>\n> This fell off the radar. \n>\n> You could have resent with Eric's Tested-by: added, to make it\n> easier to apply. I'll see if I can find the original but it won't\n> happen until later this afternoon.\n\nThe errand I needed to run earlier in the day turned out to be not\nso time consuming---I found the exchange and the patch is now\nqueued, and will be part of today's pushout.\n\nThanks, both.\n"}]}