{"thread":{"id":"4289","subject":"[PATCH] Documentation/Makefile: remove extra /","startedAt":"2006-05-25T12:37:46Z","lastAt":"2006-05-25T20:45:55Z","messageCount":2,"participants":["Martin Waitz","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"20679","messageId":"20060525123746.GA14325@admingilde.org","threadId":"4289","inReplyTo":null,"subject":"[PATCH] Documentation/Makefile: remove extra /","fromName":"Martin Waitz","fromEmail":"tali@admingilde.org","sentAt":"2006-05-25T12:37:46Z","receivedAt":"2006-05-25T12:37:46Z","isPatch":true,"sender":{"key":"tali@admingilde.org","avatar":"https://gravatar.com/avatar/3f89b03eee362187effabe257898735b475673a12265c398ea9161259ae91553?d=mp&s=160"},"body":"As both DESTDIR and the prefix are supposed to be absolute pathnames\nthey can simply be concatenated without an extra / (like in the main Makefile).\nThe extra slash may even break installation on Windows.\n\nSigned-off-by: Martin Waitz <tali@admingilde.org>\n---\n Documentation/Makefile |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 2a08f59..2b0efe7 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -52,9 +52,9 @@ man1: $(DOC_MAN1)\n man7: $(DOC_MAN7)\n \n install: man\n-\t$(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7)\n-\t$(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1)\n-\t$(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7)\n+\t$(INSTALL) -d -m755 $(DESTDIR)$(man1) $(DESTDIR)$(man7)\n+\t$(INSTALL) $(DOC_MAN1) $(DESTDIR)$(man1)\n+\t$(INSTALL) $(DOC_MAN7) $(DESTDIR)$(man7)\n \n \n #\n-- \n1.3.3.g29c7\n\n-- \nMartin Waitz\n"},{"id":"20705","messageId":"7v3bexu930.fsf@assigned-by-dhcp.cox.net","threadId":"4289","inReplyTo":"20060525123746.GA14325@admingilde.org","subject":"Re: [PATCH] Documentation/Makefile: remove extra /","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-25T20:45:55Z","receivedAt":"2006-05-25T20:45:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Waitz <tali@admingilde.org> writes:\n\n> As both DESTDIR and the prefix are supposed to be absolute pathnames\n> they can simply be concatenated without an extra / (like in the main Makefile).\n> The extra slash may even break installation on Windows.\n>\n> Signed-off-by: Martin Waitz <tali@admingilde.org>\n> ---\n>  Documentation/Makefile |    6 +++---\n>  1 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index 2a08f59..2b0efe7 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -52,9 +52,9 @@ man1: $(DOC_MAN1)\n>  man7: $(DOC_MAN7)\n>  \n>  install: man\n> -\t$(INSTALL) -d -m755 $(DESTDIR)/$(man1) $(DESTDIR)/$(man7)\n> -\t$(INSTALL) $(DOC_MAN1) $(DESTDIR)/$(man1)\n> -\t$(INSTALL) $(DOC_MAN7) $(DESTDIR)/$(man7)\n> +\t$(INSTALL) -d -m755 $(DESTDIR)$(man1) $(DESTDIR)$(man7)\n> +\t$(INSTALL) $(DOC_MAN1) $(DESTDIR)$(man1)\n> +\t$(INSTALL) $(DOC_MAN7) $(DESTDIR)$(man7)\n\nThis unfortunately breaks a workaround I did in the main\nMakefile for dist-doc target, but I agree it is a good change.\n"}]}