{"thread":{"id":"42885","subject":"[PATCH] Documentation, git submodule: Note about --reference","startedAt":"2016-07-19T23:45:35Z","lastAt":"2016-07-26T00:46:09Z","messageCount":4,"participants":["Stefan Beller","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"291781","messageId":"20160719234508.7717-1-sbeller@google.com","threadId":"42885","inReplyTo":null,"subject":"[PATCH] Documentation, git submodule: Note about --reference","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-07-19T23:45:08Z","receivedAt":"2016-07-19T23:45:35Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Signed-off-by: Stefan Beller <sbeller@google.com>\n---\n\n Is it too obvious?\n I was approached off list and this was only obvious after some discussion,\n so I think it is a valid warning.\n \n On the other hand this might show that we want to get worktree working with\n submodules.\n\n Documentation/git-submodule.txt | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\nindex bf3bb37..dcbd460 100644\n--- a/Documentation/git-submodule.txt\n+++ b/Documentation/git-submodule.txt\n@@ -373,6 +373,10 @@ the submodule itself.\n +\n *NOTE*: Do *not* use this option unless you have read the note\n for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully.\n++\n+*NOTE*: This gives the same reference to all submodules, so it is only useful\n+if you are tracking different versions of a project in submodules instead\n+of different projects.\n \n --recursive::\n \tThis option is only valid for foreach, update, status and sync commands.\n-- \n2.9.2.800.g213104a\n\n"},{"id":"292166","messageId":"CAGZ79kaJf9jU-fnicnB+jDTOvqOPTJWBy+9oo=fGm82Z8+eQgg@mail.gmail.com","threadId":"42885","inReplyTo":"20160719234508.7717-1-sbeller@google.com","subject":"Re: [PATCH] Documentation, git submodule: Note about --reference","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-07-26T00:38:44Z","receivedAt":"2016-07-26T00:43:14Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Jul 19, 2016 at 4:45 PM, Stefan Beller <sbeller@google.com> wrote:\n> Signed-off-by: Stefan Beller <sbeller@google.com>\n> ---\n\nAny comment here?\n\n>\n>  Is it too obvious?\n>  I was approached off list and this was only obvious after some discussion,\n>  so I think it is a valid warning.\n>\n>  On the other hand this might show that we want to get worktree working with\n>  submodules.\n>\n>  Documentation/git-submodule.txt | 4 ++++\n>  1 file changed, 4 insertions(+)\n>\n> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt\n> index bf3bb37..dcbd460 100644\n> --- a/Documentation/git-submodule.txt\n> +++ b/Documentation/git-submodule.txt\n> @@ -373,6 +373,10 @@ the submodule itself.\n>  +\n>  *NOTE*: Do *not* use this option unless you have read the note\n>  for linkgit:git-clone[1]'s `--reference` and `--shared` options carefully.\n> ++\n> +*NOTE*: This gives the same reference to all submodules, so it is only useful\n> +if you are tracking different versions of a project in submodules instead\n> +of different projects.\n>\n>  --recursive::\n>         This option is only valid for foreach, update, status and sync commands.\n> --\n> 2.9.2.800.g213104a\n>\n"},{"id":"292167","messageId":"CAPc5daXP0E13zuQkBsxgwfVhLnJjG6U9zocpAHn0wUSfo6KN8Q@mail.gmail.com","threadId":"42885","inReplyTo":"CAGZ79kaJf9jU-fnicnB+jDTOvqOPTJWBy+9oo=fGm82Z8+eQgg@mail.gmail.com","subject":"Re: [PATCH] Documentation, git submodule: Note about --reference","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-26T00:43:18Z","receivedAt":"2016-07-26T00:46:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"On Mon, Jul 25, 2016 at 5:38 PM, Stefan Beller <sbeller@google.com> wrote:\n> On Tue, Jul 19, 2016 at 4:45 PM, Stefan Beller <sbeller@google.com> wrote:\n>> Signed-off-by: Stefan Beller <sbeller@google.com>\n>> ---\n>\n> Any comment here?\n\nI personally found it Meh in the sense that those who read\nand followed the previous note would find it adding no new\ninformation, and to those who don't bother the additional\nnote would not help very much because they would not\nunderstand (and more importantly, would not care) where\nthat \"this affects ALL submodules\" comes from, or why\nthat leads to \"so it is only useful...\".\n\nBut it may be just me.\n"},{"id":"292168","messageId":"CAGZ79kaKZmSDjxHYu4Eb7U2rS9_rZFv4eqDc3Y0v6N4NURQ4=A@mail.gmail.com","threadId":"42885","inReplyTo":"CAPc5daXP0E13zuQkBsxgwfVhLnJjG6U9zocpAHn0wUSfo6KN8Q@mail.gmail.com","subject":"Re: [PATCH] Documentation, git submodule: Note about --reference","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-07-26T00:45:55Z","receivedAt":"2016-07-26T00:46:09Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Mon, Jul 25, 2016 at 5:43 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> On Mon, Jul 25, 2016 at 5:38 PM, Stefan Beller <sbeller@google.com> wrote:\n>> On Tue, Jul 19, 2016 at 4:45 PM, Stefan Beller <sbeller@google.com> wrote:\n>>> Signed-off-by: Stefan Beller <sbeller@google.com>\n>>> ---\n>>\n>> Any comment here?\n>\n> I personally found it Meh in the sense that those who read\n> and followed the previous note would find it adding no new\n> information, and to those who don't bother the additional\n> note would not help very much because they would not\n> understand (and more importantly, would not care) where\n> that \"this affects ALL submodules\" comes from, or why\n> that leads to \"so it is only useful...\".\n>\n> But it may be just me.\n\nOk, I guess we can just drop it then.\n\nThanks,\nStefan\n"}]}