{"thread":{"id":"42817","subject":"[PATCH] Fix running tests with --valgrind","startedAt":"2016-07-11T11:45:22Z","lastAt":"2016-07-11T15:30:36Z","messageCount":2,"participants":["Johannes Schindelin","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"291164","messageId":"80e5a1b53844d82c48eb16c88a962d9d693e0491.1468237495.git.johannes.schindelin@gmx.de","threadId":"42817","inReplyTo":null,"subject":"[PATCH] Fix running tests with --valgrind","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-07-11T11:45:08Z","receivedAt":"2016-07-11T11:45:22Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"We forgot to adjust this code path after moving the test helpers to\nt/helper/.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\nPublished-As: https://github.com/dscho/git/releases/tag/valgrind-and-test-helpers-v1\n t/test-lib.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 0055ebb..493a92b 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -798,7 +798,7 @@ then\n \t# override all git executables in TEST_DIRECTORY/..\n \tGIT_VALGRIND=$TEST_DIRECTORY/valgrind\n \tmkdir -p \"$GIT_VALGRIND\"/bin\n-\tfor file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/test-*\n+\tfor file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/t/helper/test-*\n \tdo\n \t\tmake_valgrind_symlink $file\n \tdone\n-- \n2.9.0.278.g1caae67\n\nbase-commit: 5c589a73de4394ad125a4effac227b3aec856fa1\n"},{"id":"291169","messageId":"CACsJy8D5K5rbpXXrf-JXVrJCBXXgf78+_QeYUhOcAZW1hM=6CA@mail.gmail.com","threadId":"42817","inReplyTo":"80e5a1b53844d82c48eb16c88a962d9d693e0491.1468237495.git.johannes.schindelin@gmx.de","subject":"Re: [PATCH] Fix running tests with --valgrind","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2016-07-11T15:29:58Z","receivedAt":"2016-07-11T15:30:36Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Mon, Jul 11, 2016 at 1:45 PM, Johannes Schindelin\n<johannes.schindelin@gmx.de> wrote:\n> We forgot to adjust this code path after moving the test helpers to\n> t/helper/.\n\nOops. Yet it looks like the right thing to do.\n\n>\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n> Published-As: https://github.com/dscho/git/releases/tag/valgrind-and-test-helpers-v1\n>  t/test-lib.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/test-lib.sh b/t/test-lib.sh\n> index 0055ebb..493a92b 100644\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -798,7 +798,7 @@ then\n>         # override all git executables in TEST_DIRECTORY/..\n>         GIT_VALGRIND=$TEST_DIRECTORY/valgrind\n>         mkdir -p \"$GIT_VALGRIND\"/bin\n> -       for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/test-*\n> +       for file in $GIT_BUILD_DIR/git* $GIT_BUILD_DIR/t/helper/test-*\n>         do\n>                 make_valgrind_symlink $file\n>         done\n> --\n> 2.9.0.278.g1caae67\n>\n> base-commit: 5c589a73de4394ad125a4effac227b3aec856fa1\n\n\n\n-- \nDuy\n"}]}