{"thread":{"id":"42761","subject":"[PATCH] Makefile: drop extra dependencies for test helpers","startedAt":"2016-07-01T08:05:13Z","lastAt":"2016-07-01T08:06:37Z","messageCount":2,"participants":["Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"290642","messageId":"20160701075651.GA20653@sigill.intra.peff.net","threadId":"42761","inReplyTo":null,"subject":"[PATCH] Makefile: drop extra dependencies for test helpers","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-07-01T07:56:52Z","receivedAt":"2016-07-01T08:05:13Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"A few test-helpers have Makefile dependencies on specific\nobject files. But since these files are part of libgit.a\n(which all of the helpers link against), the inclusion is\nsimply redundant.\n\nThese were once necessary, but became redundant due to\n5c5ba73 (Makefile: Use generic rule to build test programs,\n2007-05-31), which added the $(GITLIBS) dependency (but\ndidn't prune the extra dependency lines). Later commits then\ncargo-culted the practice (e.g., b4285c7).\n\nNote that we _do_ need to leave the dependencies on the svn\nlibrary, as that is not part of the usual link command.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nJust a cleanup I noticed while working on the common-main series.\n\n Makefile | 8 --------\n 1 file changed, 8 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex de5a030..22815a2 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2225,16 +2225,8 @@ perf: all\n \n .PHONY: test perf\n \n-t/helper/test-ctype$X: ctype.o\n-\n-t/helper/test-date$X: date.o ctype.o\n-\n-t/helper/test-delta$X: diff-delta.o patch-delta.o\n-\n t/helper/test-line-buffer$X: vcs-svn/lib.a\n \n-t/helper/test-parse-options$X: parse-options.o parse-options-cb.o\n-\n t/helper/test-svn-fe$X: vcs-svn/lib.a\n \n .PRECIOUS: $(TEST_OBJS)\n-- \n2.9.0.317.g65b4e7c\n"},{"id":"290644","messageId":"20160701075944.GA20736@sigill.intra.peff.net","threadId":"42761","inReplyTo":"20160701075651.GA20653@sigill.intra.peff.net","subject":"[PATCH] Makefile: use VCSSVN_LIB to refer to svn library","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-07-01T07:59:44Z","receivedAt":"2016-07-01T08:06:37Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"We have an abstracted variable; let's use it consistently.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nOn top of the cleanup earlier in the thread.\n\nI actually wonder if we should drop the vcs-svn code entirely. The last\nupdate that wasn't just part of a \"I'm grepping the whole code base to\nchange this interface\" patch was almost 4 years ago, and AFAICT it never\nreached a shippable point (we _do_ actually install git-remote-testsvn,\nbut given the name, I sort of assume nobody is using it).\n\nBut I don't want to step on the toes of anybody who actually is using\nit, or is planning to work on it more.\n\n Makefile | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 22815a2..4579eab 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2225,9 +2225,9 @@ perf: all\n \n .PHONY: test perf\n \n-t/helper/test-line-buffer$X: vcs-svn/lib.a\n+t/helper/test-line-buffer$X: $(VCSSVN_LIB)\n \n-t/helper/test-svn-fe$X: vcs-svn/lib.a\n+t/helper/test-svn-fe$X: $(VCSSVN_LIB)\n \n .PRECIOUS: $(TEST_OBJS)\n \n-- \n2.9.0.317.g65b4e7c\n"}]}