{"thread":{"id":"42757","subject":"[PATCH] t5541: become resilient to GETTEXT_POISON","startedAt":"2016-06-30T16:35:23Z","lastAt":"2016-07-01T23:48:02Z","messageCount":3,"participants":["Vasco Almeida","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"290601","messageId":"1467304470-27781-1-git-send-email-vascomalmeida@sapo.pt","threadId":"42757","inReplyTo":null,"subject":"[PATCH] t5541: become resilient to GETTEXT_POISON","fromName":"Vasco Almeida","fromEmail":"vascomalmeida@sapo.pt","sentAt":"2016-06-30T16:34:30Z","receivedAt":"2016-06-30T16:35:23Z","isPatch":true,"sender":{"key":"vascomalmeida@sapo.pt","avatar":"https://avatars.githubusercontent.com/u/9001556?v=4"},"body":"Use test_i18n* functions for testing text already marked for\ntranslation.\n\nSigned-off-by: Vasco Almeida <vascomalmeida@sapo.pt>\n---\nIncremental update for va/i18n-even-more (merged to 'next' on 2016-06-28 at\n5919dfa).\n\nI don't know how I didn't catch this one.\n\n t/t5541-http-push-smart.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh\nindex fd7d06b..97748af 100755\n--- a/t/t5541-http-push-smart.sh\n+++ b/t/t5541-http-push-smart.sh\n@@ -119,7 +119,7 @@ test_expect_success 'rejected update prints status' '\n \tgit commit -m dev2 &&\n \ttest_must_fail git push origin dev2 2>act &&\n \tsed -e \"/^remote: /s/ *$//\" <act >cmp &&\n-\ttest_cmp exp cmp\n+\ttest_i18ncmp exp cmp\n '\n rm -f \"$HTTPD_DOCUMENT_ROOT_PATH/test_repo.git/hooks/update\"\n \n@@ -219,7 +219,7 @@ test_expect_success TTY 'push shows progress when stderr is a tty' '\n \tcd \"$ROOT_PATH\"/test_repo_clone &&\n \ttest_commit noisy &&\n \ttest_terminal git push >output 2>&1 &&\n-\tgrep \"^Writing objects\" output\n+\ttest_i18ngrep \"^Writing objects\" output\n '\n \n test_expect_success TTY 'push --quiet silences status and progress' '\n@@ -233,16 +233,16 @@ test_expect_success TTY 'push --no-progress silences progress but not status' '\n \tcd \"$ROOT_PATH\"/test_repo_clone &&\n \ttest_commit no-progress &&\n \ttest_terminal git push --no-progress >output 2>&1 &&\n-\tgrep \"^To http\" output &&\n-\t! grep \"^Writing objects\"\n+\ttest_i18ngrep ! \"^To http\" output &&\n+\ttest_i18ngrep ! \"^Writing objects\"\n '\n \n test_expect_success 'push --progress shows progress to non-tty' '\n \tcd \"$ROOT_PATH\"/test_repo_clone &&\n \ttest_commit progress &&\n \tgit push --progress >output 2>&1 &&\n-\tgrep \"^To http\" output &&\n-\tgrep \"^Writing objects\" output\n+\ttest_i18ngrep \"^To http\" output &&\n+\ttest_i18ngrep \"^Writing objects\" output\n '\n \n test_expect_success 'http push gives sane defaults to reflog' '\n-- \n2.7.4\n\n"},{"id":"290604","messageId":"1467305358-12440-1-git-send-email-vascomalmeida@sapo.pt","threadId":"42757","inReplyTo":"1467304470-27781-1-git-send-email-vascomalmeida@sapo.pt","subject":"[PATCH v2] t5541: become resilient to GETTEXT_POISON","fromName":"Vasco Almeida","fromEmail":"vascomalmeida@sapo.pt","sentAt":"2016-06-30T16:49:18Z","receivedAt":"2016-06-30T16:50:03Z","isPatch":true,"sender":{"key":"vascomalmeida@sapo.pt","avatar":"https://avatars.githubusercontent.com/u/9001556?v=4"},"body":"Use test_i18n* functions for testing text already marked for\ntranslation.\n\nSigned-off-by: Vasco Almeida <vascomalmeida@sapo.pt>\n---\nFix typo on v1.\nForgot to mention that tests with TTY prerequisite were skipped, I don't\nknow how to run them.\n\nNotes:\n    Incremental update for va/i18n-even-more (merged to 'next' on 2016-06-28 at\n    5919dfa).\n    \n    I don't know how I didn't catch this one.\n\n t/t5541-http-push-smart.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh\nindex fd7d06b..ca6becf 100755\n--- a/t/t5541-http-push-smart.sh\n+++ b/t/t5541-http-push-smart.sh\n@@ -119,7 +119,7 @@ test_expect_success 'rejected update prints status' '\n \tgit commit -m dev2 &&\n \ttest_must_fail git push origin dev2 2>act &&\n \tsed -e \"/^remote: /s/ *$//\" <act >cmp &&\n-\ttest_cmp exp cmp\n+\ttest_i18ncmp exp cmp\n '\n rm -f \"$HTTPD_DOCUMENT_ROOT_PATH/test_repo.git/hooks/update\"\n \n@@ -219,7 +219,7 @@ test_expect_success TTY 'push shows progress when stderr is a tty' '\n \tcd \"$ROOT_PATH\"/test_repo_clone &&\n \ttest_commit noisy &&\n \ttest_terminal git push >output 2>&1 &&\n-\tgrep \"^Writing objects\" output\n+\ttest_i18ngrep \"^Writing objects\" output\n '\n \n test_expect_success TTY 'push --quiet silences status and progress' '\n@@ -233,16 +233,16 @@ test_expect_success TTY 'push --no-progress silences progress but not status' '\n \tcd \"$ROOT_PATH\"/test_repo_clone &&\n \ttest_commit no-progress &&\n \ttest_terminal git push --no-progress >output 2>&1 &&\n-\tgrep \"^To http\" output &&\n-\t! grep \"^Writing objects\"\n+\ttest_i18ngrep \"^To http\" output &&\n+\ttest_i18ngrep ! \"^Writing objects\"\n '\n \n test_expect_success 'push --progress shows progress to non-tty' '\n \tcd \"$ROOT_PATH\"/test_repo_clone &&\n \ttest_commit progress &&\n \tgit push --progress >output 2>&1 &&\n-\tgrep \"^To http\" output &&\n-\tgrep \"^Writing objects\" output\n+\ttest_i18ngrep \"^To http\" output &&\n+\ttest_i18ngrep \"^Writing objects\" output\n '\n \n test_expect_success 'http push gives sane defaults to reflog' '\n-- \n2.7.4\n\n"},{"id":"290723","messageId":"xmqqr3bcvs3b.fsf@gitster.mtv.corp.google.com","threadId":"42757","inReplyTo":"1467305358-12440-1-git-send-email-vascomalmeida@sapo.pt","subject":"Re: [PATCH v2] t5541: become resilient to GETTEXT_POISON","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-07-01T23:47:20Z","receivedAt":"2016-07-01T23:48:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, will queue.\n"}]}