{"thread":{"id":"42705","subject":"[PATCH] refs/files-backend: mark a file-local symbol static","startedAt":"2016-06-24T20:31:14Z","lastAt":"2016-06-24T20:31:14Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"290061","messageId":"576D9885.2020901@ramsayjones.plus.com","threadId":"42705","inReplyTo":null,"subject":"[PATCH] refs/files-backend: mark a file-local symbol static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-06-24T20:31:01Z","receivedAt":"2016-06-24T20:31:14Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 6d41edc6 (\"refs: add methods for reflog\", 24-02-2016), moved the\nreflog handling into the ref-storage backend. In particular, the\nfiles_reflog_iterator_begin() API was removed from internal refs API\nheader, resulting in sparse warnings.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Michael,\n\nIf you need to re-roll your 'mh/ref-store' branch, could you please\nsquash this into the relevant patch. (or something like it - if you\nthink this function should be public, then re-introduce the declaration\nto the header).\n\nThanks!\n\nATB,\nRamsay Jones\n\n refs/files-backend.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/refs/files-backend.c b/refs/files-backend.c\nindex b6ce19f..426e439 100644\n--- a/refs/files-backend.c\n+++ b/refs/files-backend.c\n@@ -3331,7 +3331,7 @@ static struct ref_iterator_vtable files_reflog_iterator_vtable = {\n \tfiles_reflog_iterator_abort\n };\n \n-struct ref_iterator *files_reflog_iterator_begin(struct ref_store *ref_store)\n+static struct ref_iterator *files_reflog_iterator_begin(struct ref_store *ref_store)\n {\n \tstruct files_reflog_iterator *iter = xcalloc(1, sizeof(*iter));\n \tstruct ref_iterator *ref_iterator = &iter->base;\n-- \n2.9.0\n"}]}