{"thread":{"id":"42686","subject":"[PATCH] git-p4: Fix verbose printing","startedAt":"2016-06-22T05:36:07Z","lastAt":"2016-06-22T05:36:07Z","messageCount":1,"participants":["Ben Widawsky"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"289826","messageId":"20160622051015.28946-1-ben@bwidawsk.net","threadId":"42686","inReplyTo":null,"subject":"[PATCH] git-p4: Fix verbose printing","fromName":"Ben Widawsky","fromEmail":"ben@bwidawsk.net","sentAt":"2016-06-22T05:10:15Z","receivedAt":"2016-06-22T05:36:07Z","isPatch":true,"sender":{"key":"ben@bwidawsk.net","avatar":null},"body":"The current logic seems to invert the error message when using verbose messages.\nThe inversion seems to be indicated by the caller:\nif self.inClientSpec(f['path']) and self.hasBranchPrefix(f['path'])]\n\nThis behavior has existed since the original commit:\ncommit 4ae048e67e5f0d786b9febc438433d95f18e5937\nAuthor: Lars Schneider <larsxschneider@gmail.com>\nDate:   Tue Dec 8 10:36:22 2015 +0100\n\n    git-p4: add option to keep empty commits\n\nNote that there are no behavioral changes with this patch since the code did the\nright thing, just with the wrong messages.\n\nCc: Lars Schneider <larsxschneider@gmail.com>\nSigned-off-by: Ben Widawsky <ben@bwidawsk.net>\n---\n git-p4.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-p4.py b/git-p4.py\nindex b6593cf..b123aa2 100755\n--- a/git-p4.py\n+++ b/git-p4.py\n@@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):\n             return True\n         hasPrefix = [p for p in self.branchPrefixes\n                         if p4PathStartsWith(path, p)]\n-        if hasPrefix and self.verbose:\n+        if not hasPrefix and self.verbose:\n             print('Ignoring file outside of prefix: {0}'.format(path))\n         return hasPrefix\n \n-- \n2.9.0\n\n"}]}