{"thread":{"id":"42682","subject":"[PATCH 1/1] git-p4: correct hasBranchPrefix verbose output","startedAt":"2016-06-21T16:30:57Z","lastAt":"2016-06-22T18:38:27Z","messageCount":6,"participants":["Andrew Oakley","Lars Schneider","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"289779","messageId":"1466517222-12600-1-git-send-email-aoakley@roku.com","threadId":"42682","inReplyTo":null,"subject":"[PATCH 1/1] git-p4: correct hasBranchPrefix verbose output","fromName":"Andrew Oakley","fromEmail":"aoakley@roku.com","sentAt":"2016-06-21T13:53:42Z","receivedAt":"2016-06-21T16:30:57Z","isPatch":true,"sender":{"key":"aoakley@roku.com","avatar":"https://avatars.githubusercontent.com/u/20188136?v=4"},"body":"The logic here was inverted, you got a message saying the file is\nignored for each file that is not ignored.\n---\n git-p4.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-p4.py b/git-p4.py\nindex b6593cf..b123aa2 100755\n--- a/git-p4.py\n+++ b/git-p4.py\n@@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):\n             return True\n         hasPrefix = [p for p in self.branchPrefixes\n                         if p4PathStartsWith(path, p)]\n-        if hasPrefix and self.verbose:\n+        if not hasPrefix and self.verbose:\n             print('Ignoring file outside of prefix: {0}'.format(path))\n         return hasPrefix\n \n-- \n2.7.3\n\n"},{"id":"289789","messageId":"C471957C-3FEE-4CEB-8940-624F73784355@gmail.com","threadId":"42682","inReplyTo":"1466517222-12600-1-git-send-email-aoakley@roku.com","subject":"Re: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-06-21T18:05:39Z","receivedAt":"2016-06-21T18:05:46Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\n> On 21 Jun 2016, at 15:53, Andrew Oakley <aoakley@roku.com> wrote:\n> \n> The logic here was inverted, you got a message saying the file is\n> ignored for each file that is not ignored.\n> ---\n> git-p4.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/git-p4.py b/git-p4.py\n> index b6593cf..b123aa2 100755\n> --- a/git-p4.py\n> +++ b/git-p4.py\n> @@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):\n>             return True\n>         hasPrefix = [p for p in self.branchPrefixes\n>                         if p4PathStartsWith(path, p)]\n> -        if hasPrefix and self.verbose:\n> +        if not hasPrefix and self.verbose:\n\nThanks Andrew! Your fix is correct.\n\n- Lars\n\n>             print('Ignoring file outside of prefix: {0}'.format(path))\n>         return hasPrefix\n> \n> -- \n> 2.7.3\n> \n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n\n"},{"id":"289793","messageId":"xmqqbn2uqufj.fsf@gitster.mtv.corp.google.com","threadId":"42682","inReplyTo":"C471957C-3FEE-4CEB-8940-624F73784355@gmail.com","subject":"Re: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-06-21T18:16:16Z","receivedAt":"2016-06-21T18:40:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lars Schneider <larsxschneider@gmail.com> writes:\n\n>> On 21 Jun 2016, at 15:53, Andrew Oakley <aoakley@roku.com> wrote:\n>> \n>> The logic here was inverted, you got a message saying the file is\n>> ignored for each file that is not ignored.\n>> ---\n>> git-p4.py | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/git-p4.py b/git-p4.py\n>> index b6593cf..b123aa2 100755\n>> --- a/git-p4.py\n>> +++ b/git-p4.py\n>> @@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):\n>>             return True\n>>         hasPrefix = [p for p in self.branchPrefixes\n>>                         if p4PathStartsWith(path, p)]\n>> -        if hasPrefix and self.verbose:\n>> +        if not hasPrefix and self.verbose:\n>\n> Thanks Andrew! Your fix is correct.\n\nThanks.  This needs sign-off, though.\n\n>\n> - Lars\n>\n>>             print('Ignoring file outside of prefix: {0}'.format(path))\n>>         return hasPrefix\n>> \n>> -- \n>> 2.7.3\n>> \n>> --\n>> To unsubscribe from this list: send the line \"unsubscribe git\" in\n>> the body of a message to majordomo@vger.kernel.org\n>> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"},{"id":"289836","messageId":"576A595E.9040704@roku.com","threadId":"42682","inReplyTo":"xmqqbn2uqufj.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output","fromName":"Andrew Oakley","fromEmail":"aoakley@roku.com","sentAt":"2016-06-22T09:24:46Z","receivedAt":"2016-06-22T09:26:50Z","isPatch":true,"sender":{"key":"aoakley@roku.com","avatar":"https://avatars.githubusercontent.com/u/20188136?v=4"},"body":"On 21/06/16 19:16, Junio C Hamano wrote:\n> Thanks.  This needs sign-off, though.\n\nSorry, didn't realise I needed to do that!  Will resend with sign off.\n\nThanks\n"},{"id":"289840","messageId":"1466587571-18532-1-git-send-email-aoakley@roku.com","threadId":"42682","inReplyTo":"xmqqbn2uqufj.fsf@gitster.mtv.corp.google.com","subject":"[PATCH 1/1] git-p4: correct hasBranchPrefix verbose output","fromName":"Andrew Oakley","fromEmail":"aoakley@roku.com","sentAt":"2016-06-22T09:26:11Z","receivedAt":"2016-06-22T11:01:54Z","isPatch":true,"sender":{"key":"aoakley@roku.com","avatar":"https://avatars.githubusercontent.com/u/20188136?v=4"},"body":"The logic here was inverted, you got a message saying the file is\nignored for each file that is not ignored.\n\nSigned-off-by: Andrew Oakley <aoakley@roku.com>\n---\n git-p4.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-p4.py b/git-p4.py\nindex b6593cf..b123aa2 100755\n--- a/git-p4.py\n+++ b/git-p4.py\n@@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):\n             return True\n         hasPrefix = [p for p in self.branchPrefixes\n                         if p4PathStartsWith(path, p)]\n-        if hasPrefix and self.verbose:\n+        if not hasPrefix and self.verbose:\n             print('Ignoring file outside of prefix: {0}'.format(path))\n         return hasPrefix\n \n-- \n2.7.3\n\n"},{"id":"289882","messageId":"xmqqd1n9m5m0.fsf@gitster.mtv.corp.google.com","threadId":"42682","inReplyTo":"1466587571-18532-1-git-send-email-aoakley@roku.com","subject":"Re: [PATCH 1/1] git-p4: correct hasBranchPrefix verbose output","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-06-22T18:38:15Z","receivedAt":"2016-06-22T18:38:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andrew Oakley <aoakley@roku.com> writes:\n\n> The logic here was inverted, you got a message saying the file is\n> ignored for each file that is not ignored.\n>\n> Signed-off-by: Andrew Oakley <aoakley@roku.com>\n> ---\n\nThanks.\n\n>  git-p4.py | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/git-p4.py b/git-p4.py\n> index b6593cf..b123aa2 100755\n> --- a/git-p4.py\n> +++ b/git-p4.py\n> @@ -2674,7 +2674,7 @@ class P4Sync(Command, P4UserMap):\n>              return True\n>          hasPrefix = [p for p in self.branchPrefixes\n>                          if p4PathStartsWith(path, p)]\n> -        if hasPrefix and self.verbose:\n> +        if not hasPrefix and self.verbose:\n>              print('Ignoring file outside of prefix: {0}'.format(path))\n>          return hasPrefix\n"}]}