{"thread":{"id":"42651","subject":"[PATCH] mingw: let the build succeed with DEVELOPER=1","startedAt":"2016-06-18T12:38:53Z","lastAt":"2016-06-21T12:02:40Z","messageCount":3,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"289574","messageId":"200865f29df65ccc53ed76029c7f38578430e487.1466253284.git.johannes.schindelin@gmx.de","threadId":"42651","inReplyTo":null,"subject":"[PATCH] mingw: let the build succeed with DEVELOPER=1","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-06-18T12:38:36Z","receivedAt":"2016-06-18T12:38:53Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"The recently introduced developer flags identified a couple of\nold-style function declarations in the Windows-specific code where\nthe parameter list was left empty instead of specifying \"void\"\nexplicitly. Let's just fix them.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n\n\tThis came up when working on the rebase--helper changes.\n\nPublished-As: https://github.com/dscho/git/releases/tag/mingw-dev-flags-v1\n compat/mingw.c   | 6 +++---\n compat/mingw.h   | 4 ++--\n compat/winansi.c | 2 +-\n 3 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/compat/mingw.c b/compat/mingw.c\nindex a8218e6..2b5467d 100644\n--- a/compat/mingw.c\n+++ b/compat/mingw.c\n@@ -2162,7 +2162,7 @@ int xwcstoutf(char *utf, const wchar_t *wcs, size_t utflen)\n \treturn -1;\n }\n \n-static void setup_windows_environment()\n+static void setup_windows_environment(void)\n {\n \tchar *tmp = getenv(\"TMPDIR\");\n \n@@ -2204,7 +2204,7 @@ typedef struct {\n extern int __wgetmainargs(int *argc, wchar_t ***argv, wchar_t ***env, int glob,\n \t\t_startupinfo *si);\n \n-static NORETURN void die_startup()\n+static NORETURN void die_startup(void)\n {\n \tfputs(\"fatal: not enough memory for initialization\", stderr);\n \texit(128);\n@@ -2224,7 +2224,7 @@ static char *wcstoutfdup_startup(char *buffer, const wchar_t *wcs, size_t len)\n \treturn memcpy(malloc_startup(len), buffer, len);\n }\n \n-void mingw_startup()\n+void mingw_startup(void)\n {\n \tint i, maxlen, argc;\n \tchar *buffer;\ndiff --git a/compat/mingw.h b/compat/mingw.h\nindex 69bb43d..9a8803b 100644\n--- a/compat/mingw.h\n+++ b/compat/mingw.h\n@@ -532,8 +532,8 @@ extern CRITICAL_SECTION pinfo_cs;\n  * A replacement of main() that adds win32 specific initialization.\n  */\n \n-void mingw_startup();\n-#define main(c,v) dummy_decl_mingw_main(); \\\n+void mingw_startup(void);\n+#define main(c,v) dummy_decl_mingw_main(void); \\\n static int mingw_main(c,v); \\\n int main(int argc, char **argv) \\\n { \\\ndiff --git a/compat/winansi.c b/compat/winansi.c\nindex 3be60ce..db4a5b0 100644\n--- a/compat/winansi.c\n+++ b/compat/winansi.c\n@@ -492,7 +492,7 @@ static inline ioinfo* _pioinfo(int fd)\n \t\t\t(fd & (IOINFO_ARRAY_ELTS - 1)) * sizeof_ioinfo);\n }\n \n-static int init_sizeof_ioinfo()\n+static int init_sizeof_ioinfo(void)\n {\n \tint istty, wastty;\n \t/* don't init twice */\n-- \n2.9.0.119.gb7b8d21\n\nbase-commit: 05219a1276341e72d8082d76b7f5ed394b7437a4\n"},{"id":"289692","messageId":"xmqqinx3u14g.fsf@gitster.mtv.corp.google.com","threadId":"42651","inReplyTo":"200865f29df65ccc53ed76029c7f38578430e487.1466253284.git.johannes.schindelin@gmx.de","subject":"Re: [PATCH] mingw: let the build succeed with DEVELOPER=1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-06-20T19:11:11Z","receivedAt":"2016-06-20T19:11:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <johannes.schindelin@gmx.de> writes:\n\n> The recently introduced developer flags identified a couple of\n> old-style function declarations in the Windows-specific code where\n> the parameter list was left empty instead of specifying \"void\"\n> explicitly. Let's just fix them.\n\nThanks.  It's about time for them to be cleaned up.\n\nWill queue.\n\n>\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n>\n> \tThis came up when working on the rebase--helper changes.\n>\n> Published-As: https://github.com/dscho/git/releases/tag/mingw-dev-flags-v1\n>  compat/mingw.c   | 6 +++---\n>  compat/mingw.h   | 4 ++--\n>  compat/winansi.c | 2 +-\n>  3 files changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/compat/mingw.c b/compat/mingw.c\n> index a8218e6..2b5467d 100644\n> --- a/compat/mingw.c\n> +++ b/compat/mingw.c\n> @@ -2162,7 +2162,7 @@ int xwcstoutf(char *utf, const wchar_t *wcs, size_t utflen)\n>  \treturn -1;\n>  }\n>  \n> -static void setup_windows_environment()\n> +static void setup_windows_environment(void)\n>  {\n>  \tchar *tmp = getenv(\"TMPDIR\");\n>  \n> @@ -2204,7 +2204,7 @@ typedef struct {\n>  extern int __wgetmainargs(int *argc, wchar_t ***argv, wchar_t ***env, int glob,\n>  \t\t_startupinfo *si);\n>  \n> -static NORETURN void die_startup()\n> +static NORETURN void die_startup(void)\n>  {\n>  \tfputs(\"fatal: not enough memory for initialization\", stderr);\n>  \texit(128);\n> @@ -2224,7 +2224,7 @@ static char *wcstoutfdup_startup(char *buffer, const wchar_t *wcs, size_t len)\n>  \treturn memcpy(malloc_startup(len), buffer, len);\n>  }\n>  \n> -void mingw_startup()\n> +void mingw_startup(void)\n>  {\n>  \tint i, maxlen, argc;\n>  \tchar *buffer;\n> diff --git a/compat/mingw.h b/compat/mingw.h\n> index 69bb43d..9a8803b 100644\n> --- a/compat/mingw.h\n> +++ b/compat/mingw.h\n> @@ -532,8 +532,8 @@ extern CRITICAL_SECTION pinfo_cs;\n>   * A replacement of main() that adds win32 specific initialization.\n>   */\n>  \n> -void mingw_startup();\n> -#define main(c,v) dummy_decl_mingw_main(); \\\n> +void mingw_startup(void);\n> +#define main(c,v) dummy_decl_mingw_main(void); \\\n>  static int mingw_main(c,v); \\\n>  int main(int argc, char **argv) \\\n>  { \\\n> diff --git a/compat/winansi.c b/compat/winansi.c\n> index 3be60ce..db4a5b0 100644\n> --- a/compat/winansi.c\n> +++ b/compat/winansi.c\n> @@ -492,7 +492,7 @@ static inline ioinfo* _pioinfo(int fd)\n>  \t\t\t(fd & (IOINFO_ARRAY_ELTS - 1)) * sizeof_ioinfo);\n>  }\n>  \n> -static int init_sizeof_ioinfo()\n> +static int init_sizeof_ioinfo(void)\n>  {\n>  \tint istty, wastty;\n>  \t/* don't init twice */\n"},{"id":"289762","messageId":"alpine.DEB.2.20.1606211401530.22630@virtualbox","threadId":"42651","inReplyTo":"xmqqinx3u14g.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] mingw: let the build succeed with DEVELOPER=1","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-06-21T12:02:02Z","receivedAt":"2016-06-21T12:02:40Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Mon, 20 Jun 2016, Junio C Hamano wrote:\n\n> Johannes Schindelin <johannes.schindelin@gmx.de> writes:\n> \n> > The recently introduced developer flags identified a couple of\n> > old-style function declarations in the Windows-specific code where\n> > the parameter list was left empty instead of specifying \"void\"\n> > explicitly. Let's just fix them.\n> \n> Thanks.  It's about time for them to be cleaned up.\n> \n> Will queue.\n\nThanks!\nDscho\n"}]}