{"thread":{"id":"42643","subject":"[PATCH] run-command: mark file-local symbols static","startedAt":"2016-06-17T21:01:37Z","lastAt":"2016-06-18T00:58:21Z","messageCount":3,"participants":["Ramsay Jones","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"289510","messageId":"57646524.7040708@ramsayjones.plus.com","threadId":"42643","inReplyTo":null,"subject":"[PATCH] run-command: mark file-local symbols static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-06-17T21:01:24Z","receivedAt":"2016-06-17T21:01:37Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Jeff,\n\nIf you need to re-roll your 'jk/gpg-interface-cleanup' branch, could\nyou please squash this into the relevant patch (commit 74287e34,\n\"run-command: add pipe_command helper\", 16-06-2016).\n\nBTW, also on that branch, commit 6fec0a89 (\"verify_signed_buffer: use\ntempfile object\", 16-06-2016) removes the last use of the git_mkstemp()\nfunction. Should it be removed?\n\nThanks!\n\nATB,\nRamsay Jones\n\n run-command.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/run-command.c b/run-command.c\nindex 609fa4c..33bc63a 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -886,7 +886,7 @@ struct io_pump {\n \tstruct pollfd *pfd;\n };\n \n-int pump_io_round(struct io_pump *slots, int nr, struct pollfd *pfd)\n+static int pump_io_round(struct io_pump *slots, int nr, struct pollfd *pfd)\n {\n \tint pollsize = 0;\n \tint i;\n@@ -950,7 +950,7 @@ int pump_io_round(struct io_pump *slots, int nr, struct pollfd *pfd)\n \treturn 1;\n }\n \n-int pump_io(struct io_pump *slots, int nr)\n+static int pump_io(struct io_pump *slots, int nr)\n {\n \tstruct pollfd *pfd;\n \tint i;\n-- \n2.9.0\n"},{"id":"289531","messageId":"20160617233309.GB26564@sigill.intra.peff.net","threadId":"42643","inReplyTo":"57646524.7040708@ramsayjones.plus.com","subject":"Re: [PATCH] run-command: mark file-local symbols static","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-06-17T23:33:10Z","receivedAt":"2016-06-17T23:33:15Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jun 17, 2016 at 10:01:24PM +0100, Ramsay Jones wrote:\n\n> If you need to re-roll your 'jk/gpg-interface-cleanup' branch, could\n> you please squash this into the relevant patch (commit 74287e34,\n> \"run-command: add pipe_command helper\", 16-06-2016).\n\nThanks, yes.\n\n> BTW, also on that branch, commit 6fec0a89 (\"verify_signed_buffer: use\n> tempfile object\", 16-06-2016) removes the last use of the git_mkstemp()\n> function. Should it be removed?\n\nI think so. We still have git_mkstemp_mode and friends, so in that sense\nthis is part of a family of commands that somebody might use again. But:\n\n  1. Unlike the others in the family, where we implement mkstemp\n     ourselves, this one uses the system mkstemp. Which probably behaves\n     in totally the same way, but it's kind of weird and oddball.\n\n  2. I think we should be steering people towards tempfile.c anyway, for\n     its auto-cleanup properties.\n\nWant to do a patch on top?\n\n-Peff\n"},{"id":"289543","messageId":"57649CA1.8010109@ramsayjones.plus.com","threadId":"42643","inReplyTo":"20160617233309.GB26564@sigill.intra.peff.net","subject":"Re: [PATCH] run-command: mark file-local symbols static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-06-18T00:58:09Z","receivedAt":"2016-06-18T00:58:21Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 18/06/16 00:33, Jeff King wrote:\n> On Fri, Jun 17, 2016 at 10:01:24PM +0100, Ramsay Jones wrote:\n> \n>> If you need to re-roll your 'jk/gpg-interface-cleanup' branch, could\n>> you please squash this into the relevant patch (commit 74287e34,\n>> \"run-command: add pipe_command helper\", 16-06-2016).\n> \n> Thanks, yes.\n> \n>> BTW, also on that branch, commit 6fec0a89 (\"verify_signed_buffer: use\n>> tempfile object\", 16-06-2016) removes the last use of the git_mkstemp()\n>> function. Should it be removed?\n> \n> I think so. We still have git_mkstemp_mode and friends, so in that sense\n> this is part of a family of commands that somebody might use again. But:\n> \n>   1. Unlike the others in the family, where we implement mkstemp\n>      ourselves, this one uses the system mkstemp. Which probably behaves\n>      in totally the same way, but it's kind of weird and oddball.\n> \n>   2. I think we should be steering people towards tempfile.c anyway, for\n>      its auto-cleanup properties.\n> \n> Want to do a patch on top?\n\nOK, will do. (tomorrow, it is 2am here ...)\n\nATB,\nRamsay Jones\n\n\n"}]}