{"thread":{"id":"42640","subject":"[PATCH] completion: add \"diff.compactionHeuristic\" to git config","startedAt":"2016-06-17T16:42:06Z","lastAt":"2016-06-17T17:04:26Z","messageCount":2,"participants":["Martin Vladev","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"289455","messageId":"20160617164223.79500-1-martin.vladev@gmail.com","threadId":"42640","inReplyTo":null,"subject":"[PATCH] completion: add \"diff.compactionHeuristic\" to git config","fromName":"Martin Vladev","fromEmail":"martinvladev@gmail.com","sentAt":"2016-06-17T16:42:23Z","receivedAt":"2016-06-17T16:42:06Z","isPatch":true,"sender":{"key":"martinvladev@gmail.com","avatar":null},"body":"Signed-off-by: Martin Vladev <martin.vladev@gmail.com>\n---\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 3402475..55862d6 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2066,6 +2066,7 @@ _git_config ()\n \t\tcore.whitespace\n \t\tcore.worktree\n \t\tdiff.autorefreshindex\n+\t\tdiff.compactionHeuristic\n \t\tdiff.external\n \t\tdiff.ignoreSubmodules\n \t\tdiff.mnemonicprefix\n-- \n2.9.0\n\n"},{"id":"289458","messageId":"xmqqshwb21de.fsf@gitster.mtv.corp.google.com","threadId":"42640","inReplyTo":"20160617164223.79500-1-martin.vladev@gmail.com","subject":"Re: [PATCH] completion: add \"diff.compactionHeuristic\" to git config","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-06-17T17:04:13Z","receivedAt":"2016-06-17T17:04:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Vladev <martinvladev@gmail.com> writes:\n\n> Signed-off-by: Martin Vladev <martin.vladev@gmail.com>\n> ---\n\nThe reason why existing documentation marks this feature as\nexperimental is because we would eventually want to end the\nexperiment (and use the better heuristics, if the experiment yields\none, unconditionally).\n\nMaking it more discoverable by completing like this will make it\nharder to end the experiment, so I am moderately negative on this\nchange.\n\nThanks.\n\n>  contrib/completion/git-completion.bash | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 3402475..55862d6 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -2066,6 +2066,7 @@ _git_config ()\n>  \t\tcore.whitespace\n>  \t\tcore.worktree\n>  \t\tdiff.autorefreshindex\n> +\t\tdiff.compactionHeuristic\n>  \t\tdiff.external\n>  \t\tdiff.ignoreSubmodules\n>  \t\tdiff.mnemonicprefix\n"}]}