{"thread":{"id":"42604","subject":"[PATCH] gnome-keyring: Don't hard-code pkg-config executable","startedAt":"2016-06-16T06:55:52Z","lastAt":"2016-06-16T18:56:19Z","messageCount":3,"participants":["Heiko Becker","Jeff King","Brandon Casey"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"289211","messageId":"20160614112705.7162-1-heirecka@exherbo.org","threadId":"42604","inReplyTo":null,"subject":"[PATCH] gnome-keyring: Don't hard-code pkg-config executable","fromName":"Heiko Becker","fromEmail":"heirecka@exherbo.org","sentAt":"2016-06-14T11:27:05Z","receivedAt":"2016-06-16T06:55:52Z","isPatch":true,"sender":{"key":"heirecka@exherbo.org","avatar":null},"body":"Helpful if your pkg-config executable has a prefix based on the\narchitecture, for example.\n\nSigned-off-by: Heiko Becker <heirecka@exherbo.org>\n---\n contrib/credential/gnome-keyring/Makefile | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/credential/gnome-keyring/Makefile b/contrib/credential/gnome-keyring/Makefile\nindex c3c7c98..22c19df 100644\n--- a/contrib/credential/gnome-keyring/Makefile\n+++ b/contrib/credential/gnome-keyring/Makefile\n@@ -4,12 +4,13 @@ all:: $(MAIN)\n CC = gcc\n RM = rm -f\n CFLAGS = -g -O2 -Wall\n+PKG_CONFIG = pkg-config\n \n -include ../../../config.mak.autogen\n -include ../../../config.mak\n \n-INCS:=$(shell pkg-config --cflags gnome-keyring-1 glib-2.0)\n-LIBS:=$(shell pkg-config --libs gnome-keyring-1 glib-2.0)\n+INCS:=$(shell $(PKG_CONFIG) --cflags gnome-keyring-1 glib-2.0)\n+LIBS:=$(shell $(PKG_CONFIG) --libs gnome-keyring-1 glib-2.0)\n \n SRCS:=$(MAIN).c\n OBJS:=$(SRCS:.c=.o)\n-- \n2.9.0\n"},{"id":"289349","messageId":"20160616095001.GI15851@sigill.intra.peff.net","threadId":"42604","inReplyTo":"20160614112705.7162-1-heirecka@exherbo.org","subject":"Re: [PATCH] gnome-keyring: Don't hard-code pkg-config executable","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2016-06-16T09:50:01Z","receivedAt":"2016-06-16T09:50:09Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Jun 14, 2016 at 01:27:05PM +0200, Heiko Becker wrote:\n\n> Helpful if your pkg-config executable has a prefix based on the\n> architecture, for example.\n> \n> Signed-off-by: Heiko Becker <heirecka@exherbo.org>\n\nSounds like a reasonable thing to want to do...\n\n> diff --git a/contrib/credential/gnome-keyring/Makefile b/contrib/credential/gnome-keyring/Makefile\n> index c3c7c98..22c19df 100644\n> --- a/contrib/credential/gnome-keyring/Makefile\n> +++ b/contrib/credential/gnome-keyring/Makefile\n> @@ -4,12 +4,13 @@ all:: $(MAIN)\n>  CC = gcc\n>  RM = rm -f\n>  CFLAGS = -g -O2 -Wall\n> +PKG_CONFIG = pkg-config\n>  \n>  -include ../../../config.mak.autogen\n>  -include ../../../config.mak\n>  \n> -INCS:=$(shell pkg-config --cflags gnome-keyring-1 glib-2.0)\n> -LIBS:=$(shell pkg-config --libs gnome-keyring-1 glib-2.0)\n> +INCS:=$(shell $(PKG_CONFIG) --cflags gnome-keyring-1 glib-2.0)\n> +LIBS:=$(shell $(PKG_CONFIG) --libs gnome-keyring-1 glib-2.0)\n\n...and the implementation looks obviously correct.\n\nThanks.\n\n-Peff\n"},{"id":"289383","messageId":"CA+sFfMf_NQSqrz0FRPyTcD7zgfe7VbeHUoFccVCJzW3Bon3j5g@mail.gmail.com","threadId":"42604","inReplyTo":"20160616095001.GI15851@sigill.intra.peff.net","subject":"Re: [PATCH] gnome-keyring: Don't hard-code pkg-config executable","fromName":"Brandon Casey","fromEmail":"drafnel@gmail.com","sentAt":"2016-06-16T18:56:13Z","receivedAt":"2016-06-16T18:56:19Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"On Thu, Jun 16, 2016 at 2:50 AM, Jeff King <peff@peff.net> wrote:\n> On Tue, Jun 14, 2016 at 01:27:05PM +0200, Heiko Becker wrote:\n>\n>> Helpful if your pkg-config executable has a prefix based on the\n>> architecture, for example.\n>>\n>> Signed-off-by: Heiko Becker <heirecka@exherbo.org>\n>\n> Sounds like a reasonable thing to want to do...\n\nditto.\n\n> ...and the implementation looks obviously correct.\n\nditto.\n\n> Thanks.\n\nditto.\n\nSee I'm still alive, really!\n\n-Brandon\n"}]}