{"thread":{"id":"42552","subject":"t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","startedAt":"2016-06-07T08:27:22Z","lastAt":"2016-06-08T07:12:27Z","messageCount":7,"participants":["Pirate Praveen","Johannes Schindelin","Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"288535","messageId":"5756856A.4020406@debian.org","threadId":"42552","inReplyTo":null,"subject":"t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","fromName":"Pirate Praveen","fromEmail":"praveen@debian.org","sentAt":"2016-06-07T08:27:22Z","receivedAt":"2016-06-07T08:27:22Z","isPatch":false,"sender":{"key":"praveen@debian.org","avatar":null},"body":"Hi,\n\nI'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this\nerror (tests upto this succeeds).\n\nnot ok 32 - should avoid cleaning possible submodules\n\nI added debian stretch repo to apt sources.list and ran apt-get source\n-b git.\n\nYou can see the build options passed here\nhttp://repo.or.cz/git/debian.git/blob/HEAD:/debian/rules\n\nSince it is a working fine on debian sid/unstable, I did not want to\nreport it to debian package maintainers.\n\nI noticed the same failure for git 2.8.0-rc3 as well. I could ignore the\ntest failure and go ahead, but I'd like to fix this if possible.\n\nThanks\nPraveen\n\n"},{"id":"288545","messageId":"alpine.DEB.2.20.1606071229500.28610@virtualbox","threadId":"42552","inReplyTo":"5756856A.4020406@debian.org","subject":"Re: t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-06-07T10:30:56Z","receivedAt":"2016-06-07T10:30:56Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Pirate Praveen,\n\nOn Tue, 7 Jun 2016, Pirate Praveen wrote:\n\n> I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this\n> error (tests upto this succeeds).\n> \n> not ok 32 - should avoid cleaning possible submodules\n\nHow about re-running the script with -i -v -x? If the output is still\nnot shining enough light on it, maybe you want to paste the (relevant part\nof the) output into a reply?\n\nCiao,\nJohannes\n"},{"id":"288596","messageId":"5756C6F4.5050300@debian.org","threadId":"42552","inReplyTo":"alpine.DEB.2.20.1606071229500.28610@virtualbox","subject":"Re: t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","fromName":"Pirate Praveen","fromEmail":"praveen@debian.org","sentAt":"2016-06-07T13:07:00Z","receivedAt":"2016-06-07T13:07:00Z","isPatch":false,"sender":{"key":"praveen@debian.org","avatar":null},"body":"On Tuesday 07 June 2016 04:00 PM, Johannes Schindelin wrote:\n> Hi Pirate Praveen,\n> \n> On Tue, 7 Jun 2016, Pirate Praveen wrote:\n> \n>> I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this\n>> error (tests upto this succeeds).\n>>\n>> not ok 32 - should avoid cleaning possible submodules\n> \n> How about re-running the script with -i -v -x? If the output is still\n> not shining enough light on it, maybe you want to paste the (relevant part\n> of the) output into a reply?\n\n+ rm -fr to_clean possible_sub1\n+ mkdir to_clean possible_sub1\n+ test_when_finished rm -rf possible_sub*\n+ test 0 = 0\n+ test_cleanup={ rm -rf possible_sub*\n } && (exit \"$eval_ret\"); eval_ret=$?; :\n+ echo gitdir: foo\n+\n+ chmod 0 possible_sub1/.git\n+\n+ git clean -f -d\nSkipping repository baz/boo\n\nSkipping repository foo/\nRemoving possible_sub1/\nSkipping repository repo/\nSkipping repository sub2/\nRemoving to_clean/\n+ test_path_is_file possible_sub1/.git\n+ test -f possible_sub1/.git\n+ echo File possible_sub1/.git doesn't exist.\nFile possible_sub1/.git doesn't exist.\n+ false\nerror: last command exited with $?=1\nnot ok 32 - should avoid cleaning possible submodules\n#\n# rm -fr to_clean possible_sub1 &&\n# mkdir to_clean possible_sub1 &&\n# test_when_finished \"rm -rf possible_sub*\" &&\n# echo \"gitdir: foo\" >possible_sub1/.git &&\n# >possible_sub1/hello.world &&\n# chmod 0 possible_sub1/.git &&\n# >to_clean/should_clean.this &&\n# git clean -f -d &&\n# test_path_is_file possible_sub1/.git &&\n# test_path_is_file possible_sub1/hello.world &&\n# test_path_is_missing to_clean\n#\n\n> Ciao,\n> Johannes\n> \n\n\n"},{"id":"288614","messageId":"CAGZ79ka5J9xEW=ps6kM6Gm2NU67_hv792-dJThf=GOd0tZG-Mw@mail.gmail.com","threadId":"42552","inReplyTo":"5756C6F4.5050300@debian.org","subject":"Re: t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-06-07T15:43:59Z","receivedAt":"2016-06-07T15:43:59Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"http://thread.gmane.org/gmane.comp.version-control.git/293025\n\nTL;DR: don't run tests as root, or cherry-pick\ncadfbef98032fbc6874b5efd70d1e33dbeb4640d\n(Are you telling me that patch is faulty?)\n"},{"id":"288615","messageId":"CAGZ79kYb0+=fr_wp4FOMdCcNL2O0D9ktJLDqGs6DueRg+7aO9w@mail.gmail.com","threadId":"42552","inReplyTo":"CAGZ79ka5J9xEW=ps6kM6Gm2NU67_hv792-dJThf=GOd0tZG-Mw@mail.gmail.com","subject":"Re: t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-06-07T15:46:01Z","receivedAt":"2016-06-07T15:46:01Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Jun 7, 2016 at 8:43 AM, Stefan Beller wrote:\n> (Are you telling me that patch is faulty?)\n\nThe patch is not part of v2.8.1 but part of v2.8.3,\nso take a later version, or cherry-pick that patch manually.\n"},{"id":"288616","messageId":"1A6C20FA-43F0-43AF-B38D-E88EE760F96F@debian.org","threadId":"42552","inReplyTo":"CAGZ79kYb0+=fr_wp4FOMdCcNL2O0D9ktJLDqGs6DueRg+7aO9w@mail.gmail.com","subject":"Re: t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","fromName":"Pirate Praveen","fromEmail":"praveen@debian.org","sentAt":"2016-06-07T16:20:06Z","receivedAt":"2016-06-07T16:20:06Z","isPatch":false,"sender":{"key":"praveen@debian.org","avatar":null},"body":"\n\nOn 2016, ജൂൺ 7 9:16:01 PM IST, Stefan Beller wrote:\n>On Tue, Jun 7, 2016 at 8:43 AM, Stefan Beller \n>wrote:\n>> (Are you telling me that patch is faulty?)\n>\n>The patch is not part of v2.8.1 but part of v2.8.3,\n>so take a later version, or cherry-pick that patch manually.\n\nThanks! I have ignored that test failure for now. Good to know its fixed in 2.8.3.\n"},{"id":"288680","messageId":"alpine.DEB.2.20.1606080911440.2680@virtualbox","threadId":"42552","inReplyTo":"5756C6F4.5050300@debian.org","subject":"Re: t7300-clean.sh fails \"not ok 32 - should avoid cleaning possible submodules\" on debian jessie","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2016-06-08T07:12:27Z","receivedAt":"2016-06-08T07:12:27Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Pirate Praveen,\n\nOn Tue, 7 Jun 2016, Pirate Praveen wrote:\n\n> On Tuesday 07 June 2016 04:00 PM, Johannes Schindelin wrote:\n> > Hi Pirate Praveen,\n> > \n> > On Tue, 7 Jun 2016, Pirate Praveen wrote:\n> > \n> >> I'm trying to rebuild git 2.8.1 on debian jessie/stable and I get this\n> >> error (tests upto this succeeds).\n> >>\n> >> not ok 32 - should avoid cleaning possible submodules\n> > \n> > How about re-running the script with -i -v -x? If the output is still\n> > not shining enough light on it, maybe you want to paste the (relevant part\n> > of the) output into a reply?\n> \n> + rm -fr to_clean possible_sub1\n> [...]\n\nSorry, I must have missed your diligent analysis.\n\nCiao,\nJohannes\n"}]}