{"thread":{"id":"4254","subject":"Make more commands builtin","startedAt":"2006-05-23T08:23:27Z","lastAt":"2006-05-23T08:41:52Z","messageCount":2,"participants":["Peter Eriksen","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"20520","messageId":"35036.1277036884$1148372628@news.gmane.org","threadId":"4254","inReplyTo":null,"subject":"Make more commands builtin","fromName":"Peter Eriksen","fromEmail":"s022018@student.dtu.dk","sentAt":"2006-05-23T08:23:27Z","receivedAt":"2006-05-23T08:23:27Z","isPatch":false,"sender":{"key":"s022018@student.dtu.dk","avatar":null},"body":"\n Makefile                               |   26 +++++++++++++++-----------\n apply.c => builtin-apply.c             |    3 ++-\n commit-tree.c => builtin-commit-tree.c |    3 ++-\n diff-files.c => builtin-diff-files.c   |    3 ++-\n diff-index.c => builtin-diff-index.c   |    3 ++-\n diff-stages.c => builtin-diff-stages.c |    3 ++-\n diff-tree.c => builtin-diff-tree.c     |    3 ++-\n ls-files.c => builtin-ls-files.c       |    3 ++-\n ls-tree.c => builtin-ls-tree.c         |    3 ++-\n read-tree.c => builtin-read-tree.c     |    3 ++-\n show-branch.c => builtin-show-branch.c |    3 ++-\n tar-tree.c => builtin-tar-tree.c       |    3 ++-\n builtin.h                              |   12 ++++++++++++\n git.c                                  |   13 ++++++++++++-\n\nI've tried to follow the trend of making commands builtin.\nAll patches have the same form.  This is my first use\nof git-send-email, so this might come out wrong.\n\nPeter Eriksen <s022018@student.dtu.dk>\n"},{"id":"20530","messageId":"7vac995e0f.fsf@assigned-by-dhcp.cox.net","threadId":"4254","inReplyTo":"35036.1277036884$1148372628@news.gmane.org","subject":"Re: Make more commands builtin","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-05-23T08:41:52Z","receivedAt":"2006-05-23T08:41:52Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Peter Eriksen\" <s022018@student.dtu.dk> writes:\n\n>  Makefile                               |   26 +++++++++++++++-----------\n>  apply.c => builtin-apply.c             |    3 ++-\n>  commit-tree.c => builtin-commit-tree.c |    3 ++-\n>  diff-files.c => builtin-diff-files.c   |    3 ++-\n>  diff-index.c => builtin-diff-index.c   |    3 ++-\n>  diff-stages.c => builtin-diff-stages.c |    3 ++-\n>  diff-tree.c => builtin-diff-tree.c     |    3 ++-\n>  ls-files.c => builtin-ls-files.c       |    3 ++-\n>  ls-tree.c => builtin-ls-tree.c         |    3 ++-\n>  read-tree.c => builtin-read-tree.c     |    3 ++-\n>  show-branch.c => builtin-show-branch.c |    3 ++-\n>  tar-tree.c => builtin-tar-tree.c       |    3 ++-\n>  builtin.h                              |   12 ++++++++++++\n>  git.c                                  |   13 ++++++++++++-\n>\n> I've tried to follow the trend of making commands builtin.\n> All patches have the same form.  This is my first use\n> of git-send-email, so this might come out wrong.\n>\n> Peter Eriksen <s022018@student.dtu.dk>\n\nWas this intentional?\n\n\tReply-To: Patches/@bohr.gbar.dtu.dk\n\tReply-To: Patches/0001-Builtin-git-ls-files.txt@bohr.gbar.dtu.dk\n\nOtherwise the form looks OK, except that with this particular\nseries, I would have much preferred to see these with\n\"format-patch -M\"; it is really hard to review otherwise.\n\nBTW, I already have tar-tree built-in in \"next\" branch.\n\nI'll go to bed now, so please expect review Ack/Nack until\nevening my time (it is 01:40 here) from me.\n"}]}